From: Steven Rostedt <rostedt@goodmis.org>
To: Patrick McLean <chutzpah@gentoo.org>
Cc: Yordan Karadzhov <ykaradzhov@vmware.com>,
linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] kernel-shark: Reorder the priority when searching for trace-cmd libs
Date: Mon, 18 Mar 2019 14:47:09 -0400 [thread overview]
Message-ID: <20190318144709.3551d48b@gandalf.local.home> (raw)
In-Reply-To: <20190313114235.7fc6ce3b@patrickm>
On Wed, 13 Mar 2019 11:42:35 -0700
Patrick McLean <chutzpah@gentoo.org> wrote:
> On Wed, 13 Mar 2019 17:22:18 +0200
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
>
> > The CMAKE build system of KernelShark performs automated search for
> > the trace-cmd libraries, headers and executable before building the
> > GUI. The new order of the list of directories to search in is the
> > following:
> >
> > 1. ${TRACE_CMD}/ ($TRACE_CMD is an environment variable)
> >
> > 2. CMAKE_SOURCE_DIR/../
> >
> > 3. Platform / system specific locations
> >
>
> For system installs (especially when trace-cmd and trace-cmd are
> separate packages), it's nicer to have trace-cmd install a pkgconfig
> file. Then the kernelshark can cmake use pkgconfig for getting the
> build options to find the headers, libraries, and binaries.
>
> See https://people.freedesktop.org/~dbn/pkg-config-guide.html for
> documentation on pkgconfig and pkgconfig files.
Patrick,
Are you OK if I pull these patches in for now, and we sort out the
configurations later? I was holding this off, but found that some of
Yordan's other patches are dependent on this.
-- Steve
next prev parent reply other threads:[~2019-03-18 18:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 15:22 [PATCH v2 0/3] Tuning the KernelShark build system Yordan Karadzhov
2019-03-13 15:22 ` [PATCH v2 1/3] kernel-shark: Reorder the priority when searching for trace-cmd libs Yordan Karadzhov
2019-03-13 18:42 ` Patrick McLean
2019-03-13 19:06 ` Steven Rostedt
2019-03-13 20:32 ` Patrick McLean
2019-03-18 18:47 ` Steven Rostedt [this message]
2019-03-18 20:53 ` Patrick McLean
2019-03-26 12:58 ` Steven Rostedt
2019-03-26 13:35 ` Yordan Karadzhov (VMware)
2019-03-26 13:57 ` Steven Rostedt
2019-03-27 0:24 ` Patrick McLean
2019-03-26 15:08 ` Steven Rostedt
2019-03-13 15:22 ` [PATCH v2 2/3] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark Yordan Karadzhov
2019-03-26 20:51 ` Steven Rostedt
2019-03-27 8:58 ` Yordan Karadzhov
2019-03-27 13:07 ` Steven Rostedt
2019-03-13 15:22 ` [PATCH v2 3/3] kernel-shark: Set the configuration cache directory via env. variable Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318144709.3551d48b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=chutzpah@gentoo.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.