All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, Patrick McLean <chutzpah@gentoo.org>
Subject: Re: [PATCH v2 1/3] kernel-shark: Reorder the priority when searching for trace-cmd libs
Date: Tue, 26 Mar 2019 11:08:12 -0400	[thread overview]
Message-ID: <20190326110812.66d95306@gandalf.local.home> (raw)
In-Reply-To: <20190326085821.394b6de0@gandalf.local.home>

On Tue, 26 Mar 2019 08:58:21 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> I'm still confused. We shouldn't be looking for any paths at build time.
> This should be done at run time.
> 
> Now, we can check the local directory that kernelshark lives in. That
> is, if we are running from a fresh build, at start up, we can look at
> 
>  `pwd`/../lib | `pwd`/../../plugins
> 
> and see if those directories exist at run time. And if they do, we can
> use them (as we would assume that the exec is running from a local
> source tree).
> 
> I really don't want any build artifacts in the executable. This will
> mean that you need to do special arrangements to build kernelshark and
> then move it to another machine.

Note, I was confused as I was thinking this was about plugins and not
about the dynamic runtime / static libraries.

I see that this is about where to find those libraries. This is about
where to find libtracecmd (soon to be libftrace). Currently that's a
static library, and we want it to be a dynamic one in the future.

OK, I'm fine with this patch as is and will pull it in.


-- Steve

  parent reply	other threads:[~2019-03-26 15:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 15:22 [PATCH v2 0/3] Tuning the KernelShark build system Yordan Karadzhov
2019-03-13 15:22 ` [PATCH v2 1/3] kernel-shark: Reorder the priority when searching for trace-cmd libs Yordan Karadzhov
2019-03-13 18:42   ` Patrick McLean
2019-03-13 19:06     ` Steven Rostedt
2019-03-13 20:32       ` Patrick McLean
2019-03-18 18:47     ` Steven Rostedt
2019-03-18 20:53       ` Patrick McLean
2019-03-26 12:58   ` Steven Rostedt
2019-03-26 13:35     ` Yordan Karadzhov (VMware)
2019-03-26 13:57       ` Steven Rostedt
2019-03-27  0:24         ` Patrick McLean
2019-03-26 15:08     ` Steven Rostedt [this message]
2019-03-13 15:22 ` [PATCH v2 2/3] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark Yordan Karadzhov
2019-03-26 20:51   ` Steven Rostedt
2019-03-27  8:58     ` Yordan Karadzhov
2019-03-27 13:07       ` Steven Rostedt
2019-03-13 15:22 ` [PATCH v2 3/3] kernel-shark: Set the configuration cache directory via env. variable Yordan Karadzhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190326110812.66d95306@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=chutzpah@gentoo.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.