* [PATCH 2/6] drm/i915: Introduce i9xx_has_pfit()
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
@ 2019-03-18 16:56 ` Ville Syrjala
2019-03-19 13:24 ` Tvrtko Ursulin
2019-03-19 14:23 ` [PATCH v2 " Ville Syrjala
2019-03-18 16:56 ` [PATCH 3/6] drm/i915: Introduce i9xx_has_pps() Ville Syrjala
` (8 subsequent siblings)
9 siblings, 2 replies; 21+ messages in thread
From: Ville Syrjala @ 2019-03-18 16:56 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Make the code self-documenting by introducing i9xx_has_pfit().
Also make PNV an exceptional case so that we can unset
.is_mobile for the desktop variant.
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 61acbaf2af75..0ddd83dbd768 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7961,14 +7961,22 @@ static int vlv_crtc_compute_clock(struct intel_crtc *crtc,
return 0;
}
+static bool i9xx_has_pfit(struct drm_i915_private *dev_priv)
+{
+ if (IS_I830(dev_priv))
+ return false;
+
+ return IS_GEN(dev_priv, 4) ||
+ IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
+}
+
static void i9xx_get_pfit_config(struct intel_crtc *crtc,
struct intel_crtc_state *pipe_config)
{
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
u32 tmp;
- if (INTEL_GEN(dev_priv) <= 3 &&
- (IS_I830(dev_priv) || !IS_MOBILE(dev_priv)))
+ if (!i9xx_has_pfit(dev_priv))
return;
tmp = I915_READ(PFIT_CONTROL);
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 2/6] drm/i915: Introduce i9xx_has_pfit()
2019-03-18 16:56 ` [PATCH 2/6] drm/i915: Introduce i9xx_has_pfit() Ville Syrjala
@ 2019-03-19 13:24 ` Tvrtko Ursulin
2019-03-19 14:14 ` Ville Syrjälä
2019-03-19 14:23 ` [PATCH v2 " Ville Syrjala
1 sibling, 1 reply; 21+ messages in thread
From: Tvrtko Ursulin @ 2019-03-19 13:24 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On 18/03/2019 16:56, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Make the code self-documenting by introducing i9xx_has_pfit().
> Also make PNV an exceptional case so that we can unset
> .is_mobile for the desktop variant.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 61acbaf2af75..0ddd83dbd768 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7961,14 +7961,22 @@ static int vlv_crtc_compute_clock(struct intel_crtc *crtc,
> return 0;
> }
>
> +static bool i9xx_has_pfit(struct drm_i915_private *dev_priv)
> +{
> + if (IS_I830(dev_priv))
> + return false;
> +
> + return IS_GEN(dev_priv, 4) ||
Shouldn't this be INTEL_GEN() >= 4 || ... ? Or even this check alone as
first in the function.
> + IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
> +}
> +
> static void i9xx_get_pfit_config(struct intel_crtc *crtc,
> struct intel_crtc_state *pipe_config)
> {
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> u32 tmp;
>
> - if (INTEL_GEN(dev_priv) <= 3 &&
> - (IS_I830(dev_priv) || !IS_MOBILE(dev_priv)))
> + if (!i9xx_has_pfit(dev_priv))
> return;
>
> tmp = I915_READ(PFIT_CONTROL);
>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 2/6] drm/i915: Introduce i9xx_has_pfit()
2019-03-19 13:24 ` Tvrtko Ursulin
@ 2019-03-19 14:14 ` Ville Syrjälä
0 siblings, 0 replies; 21+ messages in thread
From: Ville Syrjälä @ 2019-03-19 14:14 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
On Tue, Mar 19, 2019 at 01:24:16PM +0000, Tvrtko Ursulin wrote:
>
> On 18/03/2019 16:56, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Make the code self-documenting by introducing i9xx_has_pfit().
> > Also make PNV an exceptional case so that we can unset
> > .is_mobile for the desktop variant.
> >
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++--
> > 1 file changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 61acbaf2af75..0ddd83dbd768 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -7961,14 +7961,22 @@ static int vlv_crtc_compute_clock(struct intel_crtc *crtc,
> > return 0;
> > }
> >
> > +static bool i9xx_has_pfit(struct drm_i915_private *dev_priv)
> > +{
> > + if (IS_I830(dev_priv))
> > + return false;
> > +
> > + return IS_GEN(dev_priv, 4) ||
>
> Shouldn't this be INTEL_GEN() >= 4 || ... ? Or even this check alone as
> first in the function.
Doh. I had it as >=4 initially, but then decided that ilk+ aren't
relevant here and tweaked it to gen4 only. Which means I totally
forgot about vlv/chv. v2 coming up.
>
> > + IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
> > +}
> > +
> > static void i9xx_get_pfit_config(struct intel_crtc *crtc,
> > struct intel_crtc_state *pipe_config)
> > {
> > struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> > u32 tmp;
> >
> > - if (INTEL_GEN(dev_priv) <= 3 &&
> > - (IS_I830(dev_priv) || !IS_MOBILE(dev_priv)))
> > + if (!i9xx_has_pfit(dev_priv))
> > return;
> >
> > tmp = I915_READ(PFIT_CONTROL);
> >
>
> Regards,
>
> Tvrtko
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2 2/6] drm/i915: Introduce i9xx_has_pfit()
2019-03-18 16:56 ` [PATCH 2/6] drm/i915: Introduce i9xx_has_pfit() Ville Syrjala
2019-03-19 13:24 ` Tvrtko Ursulin
@ 2019-03-19 14:23 ` Ville Syrjala
2019-03-20 7:19 ` Tvrtko Ursulin
1 sibling, 1 reply; 21+ messages in thread
From: Ville Syrjala @ 2019-03-19 14:23 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Make the code self-documenting by introducing i9xx_has_pfit().
Also make PNV an exceptional case so that we can unset
.is_mobile for the desktop variant.
v2: s/gen4/gen>=4/ (Tvrtko)
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 61acbaf2af75..98270d0cd763 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7961,14 +7961,22 @@ static int vlv_crtc_compute_clock(struct intel_crtc *crtc,
return 0;
}
+static bool i9xx_has_pfit(struct drm_i915_private *dev_priv)
+{
+ if (IS_I830(dev_priv))
+ return false;
+
+ return INTEL_GEN(dev_priv) >= 4 ||
+ IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
+}
+
static void i9xx_get_pfit_config(struct intel_crtc *crtc,
struct intel_crtc_state *pipe_config)
{
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
u32 tmp;
- if (INTEL_GEN(dev_priv) <= 3 &&
- (IS_I830(dev_priv) || !IS_MOBILE(dev_priv)))
+ if (!i9xx_has_pfit(dev_priv))
return;
tmp = I915_READ(PFIT_CONTROL);
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH v2 2/6] drm/i915: Introduce i9xx_has_pfit()
2019-03-19 14:23 ` [PATCH v2 " Ville Syrjala
@ 2019-03-20 7:19 ` Tvrtko Ursulin
0 siblings, 0 replies; 21+ messages in thread
From: Tvrtko Ursulin @ 2019-03-20 7:19 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On 19/03/2019 14:23, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Make the code self-documenting by introducing i9xx_has_pfit().
> Also make PNV an exceptional case so that we can unset
> .is_mobile for the desktop variant.
>
> v2: s/gen4/gen>=4/ (Tvrtko)
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 61acbaf2af75..98270d0cd763 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7961,14 +7961,22 @@ static int vlv_crtc_compute_clock(struct intel_crtc *crtc,
> return 0;
> }
>
> +static bool i9xx_has_pfit(struct drm_i915_private *dev_priv)
> +{
> + if (IS_I830(dev_priv))
> + return false;
> +
> + return INTEL_GEN(dev_priv) >= 4 ||
> + IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
> +}
> +
> static void i9xx_get_pfit_config(struct intel_crtc *crtc,
> struct intel_crtc_state *pipe_config)
> {
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> u32 tmp;
>
> - if (INTEL_GEN(dev_priv) <= 3 &&
> - (IS_I830(dev_priv) || !IS_MOBILE(dev_priv)))
> + if (!i9xx_has_pfit(dev_priv))
> return;
>
> tmp = I915_READ(PFIT_CONTROL);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/6] drm/i915: Introduce i9xx_has_pps()
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
2019-03-18 16:56 ` [PATCH 2/6] drm/i915: Introduce i9xx_has_pfit() Ville Syrjala
@ 2019-03-18 16:56 ` Ville Syrjala
2019-03-19 13:26 ` Tvrtko Ursulin
2019-03-18 16:56 ` [PATCH 4/6] drm/i915: Introduce i915_has_asle() Ville Syrjala
` (7 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Ville Syrjala @ 2019-03-18 16:56 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Add a small helper to determine if we have the panel power
sequencer or not. We'll make PNV an exceptional case so
that we can unset .is_mobile for the desktop variant.
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 0ddd83dbd768..2ba61181746d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1441,6 +1441,14 @@ static void chv_enable_pll(struct intel_crtc *crtc,
}
}
+static bool i9xx_has_pps(struct drm_i915_private *dev_priv)
+{
+ if (IS_I830(dev_priv))
+ return false;
+
+ return IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
+}
+
static void i9xx_enable_pll(struct intel_crtc *crtc,
const struct intel_crtc_state *crtc_state)
{
@@ -1452,7 +1460,7 @@ static void i9xx_enable_pll(struct intel_crtc *crtc,
assert_pipe_disabled(dev_priv, crtc->pipe);
/* PLL is protected by panel, make sure we can write it */
- if (IS_MOBILE(dev_priv) && !IS_I830(dev_priv))
+ if (i9xx_has_pps(dev_priv))
assert_panel_unlocked(dev_priv, crtc->pipe);
/*
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 3/6] drm/i915: Introduce i9xx_has_pps()
2019-03-18 16:56 ` [PATCH 3/6] drm/i915: Introduce i9xx_has_pps() Ville Syrjala
@ 2019-03-19 13:26 ` Tvrtko Ursulin
0 siblings, 0 replies; 21+ messages in thread
From: Tvrtko Ursulin @ 2019-03-19 13:26 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On 18/03/2019 16:56, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Add a small helper to determine if we have the panel power
> sequencer or not. We'll make PNV an exceptional case so
> that we can unset .is_mobile for the desktop variant.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 0ddd83dbd768..2ba61181746d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1441,6 +1441,14 @@ static void chv_enable_pll(struct intel_crtc *crtc,
> }
> }
>
> +static bool i9xx_has_pps(struct drm_i915_private *dev_priv)
> +{
> + if (IS_I830(dev_priv))
> + return false;
> +
> + return IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
> +}
> +
> static void i9xx_enable_pll(struct intel_crtc *crtc,
> const struct intel_crtc_state *crtc_state)
> {
> @@ -1452,7 +1460,7 @@ static void i9xx_enable_pll(struct intel_crtc *crtc,
> assert_pipe_disabled(dev_priv, crtc->pipe);
>
> /* PLL is protected by panel, make sure we can write it */
> - if (IS_MOBILE(dev_priv) && !IS_I830(dev_priv))
> + if (i9xx_has_pps(dev_priv))
> assert_panel_unlocked(dev_priv, crtc->pipe);
>
> /*
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 4/6] drm/i915: Introduce i915_has_asle()
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
2019-03-18 16:56 ` [PATCH 2/6] drm/i915: Introduce i9xx_has_pfit() Ville Syrjala
2019-03-18 16:56 ` [PATCH 3/6] drm/i915: Introduce i9xx_has_pps() Ville Syrjala
@ 2019-03-18 16:56 ` Ville Syrjala
2019-03-19 13:27 ` Tvrtko Ursulin
2019-03-18 16:56 ` [PATCH 5/6] drm/i915: Use HPLLVCO_MOBILE for all PNVs Ville Syrjala
` (6 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Ville Syrjala @ 2019-03-18 16:56 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We want to allow the desktop PNV to not have .is_mobile set. To
that end let's add a small helper to determine if the platform
has the ASLE interrupt (or equivalent). Supposdely both PNV
variants have it.
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 82d487189a34..1375bba45548 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -748,13 +748,21 @@ void i915_disable_pipestat(struct drm_i915_private *dev_priv,
POSTING_READ(reg);
}
+static bool i915_has_asle(struct drm_i915_private *dev_priv)
+{
+ if (!dev_priv->opregion.asle)
+ return false;
+
+ return IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
+}
+
/**
* i915_enable_asle_pipestat - enable ASLE pipestat for OpRegion
* @dev_priv: i915 device private
*/
static void i915_enable_asle_pipestat(struct drm_i915_private *dev_priv)
{
- if (!dev_priv->opregion.asle || !IS_MOBILE(dev_priv))
+ if (!i915_has_asle(dev_priv))
return;
spin_lock_irq(&dev_priv->irq_lock);
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 4/6] drm/i915: Introduce i915_has_asle()
2019-03-18 16:56 ` [PATCH 4/6] drm/i915: Introduce i915_has_asle() Ville Syrjala
@ 2019-03-19 13:27 ` Tvrtko Ursulin
0 siblings, 0 replies; 21+ messages in thread
From: Tvrtko Ursulin @ 2019-03-19 13:27 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On 18/03/2019 16:56, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We want to allow the desktop PNV to not have .is_mobile set. To
> that end let's add a small helper to determine if the platform
> has the ASLE interrupt (or equivalent). Supposdely both PNV
> variants have it.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 82d487189a34..1375bba45548 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -748,13 +748,21 @@ void i915_disable_pipestat(struct drm_i915_private *dev_priv,
> POSTING_READ(reg);
> }
>
> +static bool i915_has_asle(struct drm_i915_private *dev_priv)
> +{
> + if (!dev_priv->opregion.asle)
> + return false;
> +
> + return IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv);
> +}
> +
> /**
> * i915_enable_asle_pipestat - enable ASLE pipestat for OpRegion
> * @dev_priv: i915 device private
> */
> static void i915_enable_asle_pipestat(struct drm_i915_private *dev_priv)
> {
> - if (!dev_priv->opregion.asle || !IS_MOBILE(dev_priv))
> + if (!i915_has_asle(dev_priv))
> return;
>
> spin_lock_irq(&dev_priv->irq_lock);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 5/6] drm/i915: Use HPLLVCO_MOBILE for all PNVs
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
` (2 preceding siblings ...)
2019-03-18 16:56 ` [PATCH 4/6] drm/i915: Introduce i915_has_asle() Ville Syrjala
@ 2019-03-18 16:56 ` Ville Syrjala
2019-03-19 13:29 ` Tvrtko Ursulin
2019-03-18 16:56 ` [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout Ville Syrjala
` (5 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Ville Syrjala @ 2019-03-18 16:56 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
To allow unsetting .is_mobile for the desktop variant
of PNV fix up the cdclk code to select the mobile HPLLVCO register
for both PNV variants.
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_cdclk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c
index 21fb4e0d6c4e..d27ccd23d753 100644
--- a/drivers/gpu/drm/i915/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/intel_cdclk.c
@@ -234,7 +234,8 @@ static unsigned int intel_hpll_vco(struct drm_i915_private *dev_priv)
else
return 0;
- tmp = I915_READ(IS_MOBILE(dev_priv) ? HPLLVCO_MOBILE : HPLLVCO);
+ tmp = I915_READ(IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv) ?
+ HPLLVCO_MOBILE : HPLLVCO);
vco = vco_table[tmp & 0x7];
if (vco == 0)
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 5/6] drm/i915: Use HPLLVCO_MOBILE for all PNVs
2019-03-18 16:56 ` [PATCH 5/6] drm/i915: Use HPLLVCO_MOBILE for all PNVs Ville Syrjala
@ 2019-03-19 13:29 ` Tvrtko Ursulin
2019-03-20 15:27 ` Ville Syrjälä
0 siblings, 1 reply; 21+ messages in thread
From: Tvrtko Ursulin @ 2019-03-19 13:29 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On 18/03/2019 16:56, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> To allow unsetting .is_mobile for the desktop variant
> of PNV fix up the cdclk code to select the mobile HPLLVCO register
> for both PNV variants.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_cdclk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c
> index 21fb4e0d6c4e..d27ccd23d753 100644
> --- a/drivers/gpu/drm/i915/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/intel_cdclk.c
> @@ -234,7 +234,8 @@ static unsigned int intel_hpll_vco(struct drm_i915_private *dev_priv)
> else
> return 0;
>
> - tmp = I915_READ(IS_MOBILE(dev_priv) ? HPLLVCO_MOBILE : HPLLVCO);
> + tmp = I915_READ(IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv) ?
> + HPLLVCO_MOBILE : HPLLVCO);
>
> vco = vco_table[tmp & 0x7];
> if (vco == 0)
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 5/6] drm/i915: Use HPLLVCO_MOBILE for all PNVs
2019-03-19 13:29 ` Tvrtko Ursulin
@ 2019-03-20 15:27 ` Ville Syrjälä
0 siblings, 0 replies; 21+ messages in thread
From: Ville Syrjälä @ 2019-03-20 15:27 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
On Tue, Mar 19, 2019 at 01:29:58PM +0000, Tvrtko Ursulin wrote:
>
> On 18/03/2019 16:56, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > To allow unsetting .is_mobile for the desktop variant
> > of PNV fix up the cdclk code to select the mobile HPLLVCO register
> > for both PNV variants.
> >
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_cdclk.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c
> > index 21fb4e0d6c4e..d27ccd23d753 100644
> > --- a/drivers/gpu/drm/i915/intel_cdclk.c
> > +++ b/drivers/gpu/drm/i915/intel_cdclk.c
> > @@ -234,7 +234,8 @@ static unsigned int intel_hpll_vco(struct drm_i915_private *dev_priv)
> > else
> > return 0;
> >
> > - tmp = I915_READ(IS_MOBILE(dev_priv) ? HPLLVCO_MOBILE : HPLLVCO);
> > + tmp = I915_READ(IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv) ?
> > + HPLLVCO_MOBILE : HPLLVCO);
> >
> > vco = vco_table[tmp & 0x7];
> > if (vco == 0)
> >
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Pushed up to this one. Thanks for the review.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
` (3 preceding siblings ...)
2019-03-18 16:56 ` [PATCH 5/6] drm/i915: Use HPLLVCO_MOBILE for all PNVs Ville Syrjala
@ 2019-03-18 16:56 ` Ville Syrjala
2019-03-19 13:34 ` Tvrtko Ursulin
2019-03-18 23:35 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic Patchwork
` (4 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Ville Syrjala @ 2019-03-18 16:56 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The current gen2 DPLL readout code:
* assumes i845/i865 have LVDS which is not true
* assumes only pipe B can drive LVDS (true, but makes
the code appear a bit magical)
* hard to parse in general
Clean it up by checking for i85x (the only gen2 platform
with LVDS) and reusing intel_lvds_port_enabled().
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 2ba61181746d..9f31d94fc04b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -10809,7 +10809,6 @@ static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
{
struct drm_device *dev = crtc->base.dev;
struct drm_i915_private *dev_priv = to_i915(dev);
- int pipe = pipe_config->cpu_transcoder;
u32 dpll = pipe_config->dpll_hw_state.dpll;
u32 fp;
struct dpll clock;
@@ -10858,10 +10857,13 @@ static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
else
port_clock = i9xx_calc_dpll_params(refclk, &clock);
} else {
- u32 lvds = IS_I830(dev_priv) ? 0 : I915_READ(LVDS);
- bool is_lvds = (pipe == 1) && (lvds & LVDS_PORT_EN);
+ enum pipe lvds_pipe;
+
+ if (IS_I85X(dev_priv) &&
+ intel_lvds_port_enabled(dev_priv, LVDS, &lvds_pipe) &&
+ lvds_pipe == crtc->pipe) {
+ u32 lvds = I915_READ(LVDS);
- if (is_lvds) {
clock.p1 = ffs((dpll & DPLL_FPA01_P1_POST_DIV_MASK_I830_LVDS) >>
DPLL_FPA01_P1_POST_DIV_SHIFT);
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout
2019-03-18 16:56 ` [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout Ville Syrjala
@ 2019-03-19 13:34 ` Tvrtko Ursulin
2019-03-19 14:17 ` Ville Syrjälä
0 siblings, 1 reply; 21+ messages in thread
From: Tvrtko Ursulin @ 2019-03-19 13:34 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On 18/03/2019 16:56, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The current gen2 DPLL readout code:
> * assumes i845/i865 have LVDS which is not true
> * assumes only pipe B can drive LVDS (true, but makes
> the code appear a bit magical)
> * hard to parse in general
>
> Clean it up by checking for i85x (the only gen2 platform
> with LVDS) and reusing intel_lvds_port_enabled().
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 2ba61181746d..9f31d94fc04b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -10809,7 +10809,6 @@ static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
> {
> struct drm_device *dev = crtc->base.dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
> - int pipe = pipe_config->cpu_transcoder;
> u32 dpll = pipe_config->dpll_hw_state.dpll;
> u32 fp;
> struct dpll clock;
> @@ -10858,10 +10857,13 @@ static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
> else
> port_clock = i9xx_calc_dpll_params(refclk, &clock);
> } else {
> - u32 lvds = IS_I830(dev_priv) ? 0 : I915_READ(LVDS);
> - bool is_lvds = (pipe == 1) && (lvds & LVDS_PORT_EN);
> + enum pipe lvds_pipe;
> +
> + if (IS_I85X(dev_priv) &&
> + intel_lvds_port_enabled(dev_priv, LVDS, &lvds_pipe) &&
> + lvds_pipe == crtc->pipe) {
> + u32 lvds = I915_READ(LVDS);
>
> - if (is_lvds) {
> clock.p1 = ffs((dpll & DPLL_FPA01_P1_POST_DIV_MASK_I830_LVDS) >>
> DPLL_FPA01_P1_POST_DIV_SHIFT);
>
>
I defer to domain experts on this one.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout
2019-03-19 13:34 ` Tvrtko Ursulin
@ 2019-03-19 14:17 ` Ville Syrjälä
0 siblings, 0 replies; 21+ messages in thread
From: Ville Syrjälä @ 2019-03-19 14:17 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
On Tue, Mar 19, 2019 at 01:34:31PM +0000, Tvrtko Ursulin wrote:
>
> On 18/03/2019 16:56, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The current gen2 DPLL readout code:
> > * assumes i845/i865 have LVDS which is not true
> > * assumes only pipe B can drive LVDS (true, but makes
> > the code appear a bit magical)
> > * hard to parse in general
> >
> > Clean it up by checking for i85x (the only gen2 platform
> > with LVDS) and reusing intel_lvds_port_enabled().
> >
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 2ba61181746d..9f31d94fc04b 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -10809,7 +10809,6 @@ static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
> > {
> > struct drm_device *dev = crtc->base.dev;
> > struct drm_i915_private *dev_priv = to_i915(dev);
> > - int pipe = pipe_config->cpu_transcoder;
> > u32 dpll = pipe_config->dpll_hw_state.dpll;
> > u32 fp;
> > struct dpll clock;
> > @@ -10858,10 +10857,13 @@ static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
> > else
> > port_clock = i9xx_calc_dpll_params(refclk, &clock);
> > } else {
> > - u32 lvds = IS_I830(dev_priv) ? 0 : I915_READ(LVDS);
> > - bool is_lvds = (pipe == 1) && (lvds & LVDS_PORT_EN);
> > + enum pipe lvds_pipe;
> > +
> > + if (IS_I85X(dev_priv) &&
> > + intel_lvds_port_enabled(dev_priv, LVDS, &lvds_pipe) &&
> > + lvds_pipe == crtc->pipe) {
> > + u32 lvds = I915_READ(LVDS);
> >
> > - if (is_lvds) {
> > clock.p1 = ffs((dpll & DPLL_FPA01_P1_POST_DIV_MASK_I830_LVDS) >>
> > DPLL_FPA01_P1_POST_DIV_SHIFT);
> >
> >
>
> I defer to domain experts on this one.
Yeah. This wasn't really meant to be part of this series. It just
happened to live in the same branch where I had already typed up
some of the i9xx_has_pfit() etc. and hence got piggybacked to the
list.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
` (4 preceding siblings ...)
2019-03-18 16:56 ` [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout Ville Syrjala
@ 2019-03-18 23:35 ` Patchwork
2019-03-19 13:06 ` ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
9 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-03-18 23:35 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic
URL : https://patchwork.freedesktop.org/series/58139/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12503
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58139/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12503 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +55
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: PASS -> FAIL [fdo#108511]
* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@basic-flip-c:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
#### Warnings ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: DMESG-FAIL [fdo#105079] -> DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602]
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: DMESG-FAIL [fdo#103182] -> FAIL [fdo#103182]
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (44 -> 42)
------------------------------
Additional (2): fi-bsw-kefka fi-bsw-n3050
Missing (4): fi-kbl-soraka fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_5770 -> Patchwork_12503
CI_DRM_5770: 7f60fa0ec6f20661a49a3eeed6e4b0a175783cf6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12503: 86275809b133d66b53b93ee00791149cffe6daf3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
86275809b133 drm/i915: Clean up gen2 DPLL readout
5600a9b87faa drm/i915: Use HPLLVCO_MOBILE for all PNVs
2fe421be5753 drm/i915: Introduce i915_has_asle()
a04291fa0825 drm/i915: Introduce i9xx_has_pps()
fcad0efeb3c3 drm/i915: Introduce i9xx_has_pfit()
23f78e78cddc drm/i915: Reorder gen3/4 swizzle detection logic
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12503/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
` (5 preceding siblings ...)
2019-03-18 23:35 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic Patchwork
@ 2019-03-19 13:06 ` Patchwork
2019-03-19 13:15 ` [PATCH 1/6] " Tvrtko Ursulin
` (2 subsequent siblings)
9 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-03-19 13:06 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic
URL : https://patchwork.freedesktop.org/series/58139/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5770_full -> Patchwork_12503_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12503_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-clear:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@gem_ctx_param@invalid-param-get:
- shard-skl: NOTRUN -> FAIL [fdo#109559]
* igt@gem_ctx_param@invalid-param-set:
- shard-skl: NOTRUN -> FAIL [fdo#109674]
* igt@gem_exec_params@no-vebox:
- shard-iclb: NOTRUN -> SKIP [fdo#109283]
* igt@gem_mmap_gtt@hang:
- shard-iclb: PASS -> FAIL [fdo#109677]
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-iclb: PASS -> INCOMPLETE [fdo#109766] / [fdo#109801]
* igt@gem_pwrite@stolen-uncached:
- shard-iclb: NOTRUN -> SKIP [fdo#109277] +1
* igt@gem_tiled_fence_blits@normal:
- shard-iclb: PASS -> TIMEOUT [fdo#109673] +1
* igt@gem_tiled_pread_pwrite:
- shard-iclb: NOTRUN -> TIMEOUT [fdo#109673]
* igt@gem_userptr_blits@coherency-sync:
- shard-iclb: NOTRUN -> SKIP [fdo#109290]
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@i915_pm_rps@reset:
- shard-iclb: NOTRUN -> FAIL [fdo#108059]
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +12
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-skl: PASS -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +2
* igt@kms_busy@extended-modeset-hang-newfb-render-f:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@extended-pageflip-hang-newfb-render-b:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_chamelium@vga-edid-read:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +9
* igt@kms_color@pipe-a-ctm-max:
- shard-skl: NOTRUN -> FAIL [fdo#108147]
* igt@kms_color@pipe-a-degamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_color@pipe-b-gamma:
- shard-iclb: NOTRUN -> FAIL [fdo#104782] +1
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-skl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] +1
* igt@kms_cursor_crc@cursor-128x42-random:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +7
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-iclb: PASS -> FAIL [fdo#103355]
- shard-hsw: PASS -> FAIL [fdo#103355]
* igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_flip@flip-vs-suspend:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#109507]
* igt@kms_force_connector_basic@force-connector-state:
- shard-iclb: NOTRUN -> SKIP [fdo#109285]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
- shard-iclb: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +24
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: PASS -> FAIL [fdo#103167] / [fdo#105682]
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247] +1
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt:
- shard-skl: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: NOTRUN -> FAIL [fdo#109247] +1
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-iclb: PASS -> FAIL [fdo#109247] +16
* igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +18
* igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: NOTRUN -> INCOMPLETE [fdo#103665]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-f:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +10
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] / [fdo#109278]
* igt@kms_psr@primary_blt:
- shard-iclb: PASS -> FAIL [fdo#107383]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: NOTRUN -> SKIP [fdo#109441] +1
* igt@kms_setmode@basic:
- shard-skl: NOTRUN -> FAIL [fdo#99912]
- shard-iclb: NOTRUN -> FAIL [fdo#99912]
- shard-hsw: PASS -> FAIL [fdo#99912]
* igt@perf_pmu@busy-accuracy-98-vcs1:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +110
* igt@prime_nv_test@i915_import_pread_pwrite:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +3
* igt@prime_vgem@fence-flip-hang:
- shard-iclb: NOTRUN -> SKIP [fdo#109295]
* igt@prime_vgem@fence-wait-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +10
* igt@sw_sync@sync_busy_fork_unixsocket:
- shard-skl: NOTRUN -> FAIL [fdo#110150 ]
* igt@v3d_get_param@get-bad-param:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]
#### Possible fixes ####
* igt@gem_linear_blits@interruptible:
- shard-iclb: TIMEOUT [fdo#109673] -> PASS +1
* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-iclb: INCOMPLETE [fdo#109766] / [fdo#109801] -> PASS
* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: INCOMPLETE -> PASS
* igt@i915_pm_rpm@system-suspend:
- shard-iclb: DMESG-WARN -> PASS
* igt@kms_chv_cursor_fail@pipe-a-128x128-top-edge:
- shard-snb: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-iclb: FAIL [fdo#103355] -> PASS
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled:
- shard-skl: FAIL [fdo#103184] -> PASS
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-wc:
- shard-skl: FAIL [fdo#105682] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +5
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-pwrite:
- shard-iclb: FAIL [fdo#105682] / [fdo#109247] -> PASS +1
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#109247] -> PASS +17
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-skl: FAIL [fdo#103167] -> PASS +1
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- shard-skl: FAIL [fdo#107362] -> PASS
* {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
- shard-glk: SKIP [fdo#109271] -> PASS +1
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: FAIL [fdo#107815] / [fdo#108145] -> PASS
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-none}:
- shard-glk: FAIL [fdo#110037] -> PASS
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-x}:
- shard-iclb: FAIL [fdo#110037] -> PASS +2
* {igt@kms_plane_multiple@atomic-pipe-c-tiling-yf}:
- shard-apl: FAIL [fdo#110037] -> PASS +1
* igt@kms_psr@primary_render:
- shard-iclb: FAIL [fdo#107383] -> PASS +1
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: SKIP [fdo#109441] -> PASS
* igt@kms_setmode@basic:
- shard-glk: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
* igt@kms_vblank@pipe-b-wait-idle-hang:
- shard-snb: SKIP [fdo#109271] -> PASS +2
#### Warnings ####
* igt@i915_selftest@live_contexts:
- shard-iclb: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108059]: https://bugs.freedesktop.org/show_bug.cgi?id=108059
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109559]: https://bugs.freedesktop.org/show_bug.cgi?id=109559
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#109674]: https://bugs.freedesktop.org/show_bug.cgi?id=109674
[fdo#109677]: https://bugs.freedesktop.org/show_bug.cgi?id=109677
[fdo#109766]: https://bugs.freedesktop.org/show_bug.cgi?id=109766
[fdo#109801]: https://bugs.freedesktop.org/show_bug.cgi?id=109801
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
[fdo#110150 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110150
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5770 -> Patchwork_12503
CI_DRM_5770: 7f60fa0ec6f20661a49a3eeed6e4b0a175783cf6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12503: 86275809b133d66b53b93ee00791149cffe6daf3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12503/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
` (6 preceding siblings ...)
2019-03-19 13:06 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-19 13:15 ` Tvrtko Ursulin
2019-03-19 15:50 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic (rev2) Patchwork
2019-03-20 0:40 ` ✓ Fi.CI.IGT: " Patchwork
9 siblings, 0 replies; 21+ messages in thread
From: Tvrtko Ursulin @ 2019-03-19 13:15 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On 18/03/2019 16:56, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> g33/i964g/g45 are the exceptional cases when it comes to
> the swizzle detectiong. Let's reorder the code to handle
> them first and let everything else be handled by the
> else branch. This allows us to unset .is_mobile for the
> desktop PNV variant (which supposedly must follow the
> "mobile" path here).
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_fence_reg.c | 65 +++++++++++------------
> 1 file changed, 32 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_fence_reg.c b/drivers/gpu/drm/i915/i915_gem_fence_reg.c
> index 65624b8e4d15..9418ad499b7e 100644
> --- a/drivers/gpu/drm/i915/i915_gem_fence_reg.c
> +++ b/drivers/gpu/drm/i915/i915_gem_fence_reg.c
> @@ -585,8 +585,38 @@ i915_gem_detect_bit_6_swizzle(struct drm_i915_private *dev_priv)
> */
> swizzle_x = I915_BIT_6_SWIZZLE_NONE;
> swizzle_y = I915_BIT_6_SWIZZLE_NONE;
> - } else if (IS_MOBILE(dev_priv) ||
> - IS_I915G(dev_priv) || IS_I945G(dev_priv)) {
> + } else if (IS_G45(dev_priv) || IS_I965G(dev_priv) || IS_G33(dev_priv)) {
> + /* The 965, G33, and newer, have a very flexible memory
> + * configuration. It will enable dual-channel mode
> + * (interleaving) on as much memory as it can, and the GPU
> + * will additionally sometimes enable different bit 6
> + * swizzling for tiled objects from the CPU.
> + *
> + * Here's what I found on the G965:
> + * slot fill memory size swizzling
> + * 0A 0B 1A 1B 1-ch 2-ch
> + * 512 0 0 0 512 0 O
> + * 512 0 512 0 16 1008 X
> + * 512 0 0 512 16 1008 X
> + * 0 512 0 512 16 1008 X
> + * 1024 1024 1024 0 2048 1024 O
> + *
> + * We could probably detect this based on either the DRB
> + * matching, which was the case for the swizzling required in
> + * the table above, or from the 1-ch value being less than
> + * the minimum size of a rank.
> + *
> + * Reports indicate that the swizzling actually
> + * varies depending upon page placement inside the
> + * channels, i.e. we see swizzled pages where the
> + * banks of memory are paired and unswizzled on the
> + * uneven portion, so leave that as unknown.
> + */
> + if (I915_READ16(C0DRB3) == I915_READ16(C1DRB3)) {
> + swizzle_x = I915_BIT_6_SWIZZLE_9_10;
> + swizzle_y = I915_BIT_6_SWIZZLE_9;
> + }
> + } else {
> u32 dcc;
>
> /* On 9xx chipsets, channel interleave by the CPU is
> @@ -636,37 +666,6 @@ i915_gem_detect_bit_6_swizzle(struct drm_i915_private *dev_priv)
> swizzle_x = I915_BIT_6_SWIZZLE_UNKNOWN;
> swizzle_y = I915_BIT_6_SWIZZLE_UNKNOWN;
> }
> - } else {
> - /* The 965, G33, and newer, have a very flexible memory
> - * configuration. It will enable dual-channel mode
> - * (interleaving) on as much memory as it can, and the GPU
> - * will additionally sometimes enable different bit 6
> - * swizzling for tiled objects from the CPU.
> - *
> - * Here's what I found on the G965:
> - * slot fill memory size swizzling
> - * 0A 0B 1A 1B 1-ch 2-ch
> - * 512 0 0 0 512 0 O
> - * 512 0 512 0 16 1008 X
> - * 512 0 0 512 16 1008 X
> - * 0 512 0 512 16 1008 X
> - * 1024 1024 1024 0 2048 1024 O
> - *
> - * We could probably detect this based on either the DRB
> - * matching, which was the case for the swizzling required in
> - * the table above, or from the 1-ch value being less than
> - * the minimum size of a rank.
> - *
> - * Reports indicate that the swizzling actually
> - * varies depending upon page placement inside the
> - * channels, i.e. we see swizzled pages where the
> - * banks of memory are paired and unswizzled on the
> - * uneven portion, so leave that as unknown.
> - */
> - if (I915_READ16(C0DRB3) == I915_READ16(C1DRB3)) {
> - swizzle_x = I915_BIT_6_SWIZZLE_9_10;
> - swizzle_y = I915_BIT_6_SWIZZLE_9;
> - }
> }
>
> if (swizzle_x == I915_BIT_6_SWIZZLE_UNKNOWN ||
>
Old/new/future behaviour checks out as far as I can see.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread* ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic (rev2)
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
` (7 preceding siblings ...)
2019-03-19 13:15 ` [PATCH 1/6] " Tvrtko Ursulin
@ 2019-03-19 15:50 ` Patchwork
2019-03-20 0:40 ` ✓ Fi.CI.IGT: " Patchwork
9 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-03-19 15:50 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic (rev2)
URL : https://patchwork.freedesktop.org/series/58139/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5773 -> Patchwork_12515
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58139/revisions/2/mbox/
Known issues
------------
Here are the changes found in Patchwork_12515 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-cfl-guc: NOTRUN -> SKIP [fdo#109271] +49
* igt@gem_close_race@basic-process:
- fi-skl-6770hq: PASS -> DMESG-WARN [fdo#105541]
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76
* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@basic-flip-c:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
* igt@kms_force_connector_basic@force-load-detect:
- fi-bxt-j4205: NOTRUN -> SKIP [fdo#109271] +47
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
#### Possible fixes ####
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: DMESG-WARN [fdo#107709] -> PASS
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109638]: https://bugs.freedesktop.org/show_bug.cgi?id=109638
Participating hosts (43 -> 41)
------------------------------
Additional (4): fi-cfl-guc fi-bxt-j4205 fi-bsw-n3050 fi-pnv-d510
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5773 -> Patchwork_12515
CI_DRM_5773: b1f30d7018c1d5f9e9abfb5dc6b8d84c3148dd57 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4889: e3faf0fd49b7e3a763bf89e11fb4fdce81839da2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12515: 665759afae799b5e9acfa68256342652b0c0f406 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
665759afae79 drm/i915: Clean up gen2 DPLL readout
b78fc6aef66b drm/i915: Use HPLLVCO_MOBILE for all PNVs
c58b8fe1d55f drm/i915: Introduce i915_has_asle()
4f86f82f9a45 drm/i915: Introduce i9xx_has_pps()
b5d3b94a82d1 drm/i915: Introduce i9xx_has_pfit()
90f3794d0025 drm/i915: Reorder gen3/4 swizzle detection logic
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12515/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic (rev2)
2019-03-18 16:56 [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic Ville Syrjala
` (8 preceding siblings ...)
2019-03-19 15:50 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic (rev2) Patchwork
@ 2019-03-20 0:40 ` Patchwork
9 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-03-20 0:40 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic (rev2)
URL : https://patchwork.freedesktop.org/series/58139/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5773_full -> Patchwork_12515_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_12515_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_12515_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12515_full:
### IGT changes ###
#### Warnings ####
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: SKIP [fdo#109441] -> FAIL
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
- shard-iclb: PASS -> FAIL
Known issues
------------
Here are the changes found in Patchwork_12515_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries_display_off:
- shard-skl: PASS -> INCOMPLETE [fdo#104108]
* igt@gem_bad_reloc@negative-reloc-bsd2:
- shard-iclb: NOTRUN -> SKIP [fdo#109276]
* igt@gem_mmap_gtt@hang:
- shard-iclb: PASS -> FAIL [fdo#109677]
* igt@gem_pwrite@stolen-normal:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +80
* igt@gem_tiled_fence_blits@normal:
- shard-iclb: PASS -> TIMEOUT [fdo#109673]
* igt@i915_pm_rpm@i2c:
- shard-iclb: PASS -> DMESG-WARN [fdo#109982]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-pageflip-hang-newfb-render-f:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic:
- shard-iclb: PASS -> FAIL [fdo#107725]
* igt@kms_chv_cursor_fail@pipe-c-256x256-bottom-edge:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +11
* igt@kms_color@pipe-c-degamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-skl: PASS -> FAIL [fdo#103184] / [fdo#108472]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: NOTRUN -> FAIL [fdo#103833]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
- shard-snb: PASS -> SKIP [fdo#109271] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-skl: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-iclb: PASS -> FAIL [fdo#109247] +26
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_psr@no_drrs:
- shard-iclb: PASS -> FAIL [fdo#108341]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: PASS -> SKIP [fdo#109441] +2
* igt@kms_psr@sprite_blt:
- shard-iclb: PASS -> FAIL [fdo#107383] +4
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> FAIL [fdo#100047]
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540] +2
* igt@prime_nv_test@i915_import_gtt_mmap:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +70
#### Possible fixes ####
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-iclb: FAIL [fdo#107725] -> PASS
* igt@kms_chv_cursor_fail@pipe-c-256x256-left-edge:
- shard-skl: FAIL [fdo#104671] -> PASS
* igt@kms_cursor_crc@cursor-64x21-offscreen:
- shard-skl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: FAIL [fdo#103355] -> PASS
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled:
- shard-skl: FAIL [fdo#108472] -> PASS
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: INCOMPLETE [fdo#109507] -> PASS
* igt@kms_flip_tiling@flip-yf-tiled:
- shard-skl: FAIL [fdo#108145] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-iclb: FAIL [fdo#109247] -> PASS +12
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: FAIL [fdo#103167] -> PASS +11
* igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
- shard-skl: FAIL [fdo#103167] -> PASS +1
* {igt@kms_plane@pixel-format-pipe-c-planes}:
- shard-iclb: FAIL -> PASS
* {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-glk: SKIP [fdo#109271] -> PASS +1
- shard-iclb: DMESG-WARN [fdo#106885] -> PASS
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: INCOMPLETE [fdo#104108] -> PASS
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: FAIL [fdo#107815] / [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS
* {igt@kms_plane_multiple@atomic-pipe-a-tiling-y}:
- shard-iclb: FAIL [fdo#110037] -> PASS +4
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-none}:
- shard-apl: FAIL [fdo#110037] -> PASS +2
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: SKIP [fdo#109642] -> PASS
* igt@kms_psr@cursor_render:
- shard-iclb: FAIL [fdo#107383] -> PASS +1
* igt@kms_psr@psr2_dpms:
- shard-iclb: SKIP [fdo#109441] -> PASS +1
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-iclb: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-skl: INCOMPLETE [fdo#107807] -> SKIP [fdo#109271]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: SKIP [fdo#109349] -> FAIL [fdo#109358]
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-glk: FAIL [fdo#110098] -> SKIP [fdo#109271] / [fdo#109278]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109358]: https://bugs.freedesktop.org/show_bug.cgi?id=109358
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#109677]: https://bugs.freedesktop.org/show_bug.cgi?id=109677
[fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110098]: https://bugs.freedesktop.org/show_bug.cgi?id=110098
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5773 -> Patchwork_12515
CI_DRM_5773: b1f30d7018c1d5f9e9abfb5dc6b8d84c3148dd57 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4889: e3faf0fd49b7e3a763bf89e11fb4fdce81839da2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12515: 665759afae799b5e9acfa68256342652b0c0f406 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12515/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread