* [PATCH] rapidio: fix a NULL pointer dereference when create_workqueue fails
[not found] <002201d4dddc62129a02637ce0gmail.com>
@ 2019-03-19 17:53 ` Kangjie Lu
0 siblings, 0 replies; only message in thread
From: Kangjie Lu @ 2019-03-19 17:53 UTC (permalink / raw)
To: kjlu; +Cc: pakki001, Matt Porter, Alexandre Bounine, linux-kernel
In case create_workqueue fails, the fix releases resources and
returns -ENOMEM to avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/rapidio/rio_cm.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index cf45829585cb..b29fc258eeba 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -2147,6 +2147,14 @@ static int riocm_add_mport(struct device *dev,
mutex_init(&cm->rx_lock);
riocm_rx_fill(cm, RIOCM_RX_RING_SIZE);
cm->rx_wq = create_workqueue(DRV_NAME "/rxq");
+ if (!cm->rx_wq) {
+ riocm_error("failed to allocate IBMBOX_%d on %s",
+ cmbox, mport->name);
+ rio_release_outb_mbox(mport, cmbox);
+ kfree(cm);
+ return -ENOMEM;
+ }
+
INIT_WORK(&cm->rx_work, rio_ibmsg_handler);
cm->tx_slot = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-03-19 17:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <002201d4dddc62129a02637ce0gmail.com>
2019-03-19 17:53 ` [PATCH] rapidio: fix a NULL pointer dereference when create_workqueue fails Kangjie Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.