[PATCH] Staging: mt7621-dma: Add blank line after declarations

[PATCH] Staging: mt7621-dma: Add blank line after declarations

[Wentao Cai]

Add a blank line after declaration to mute checkpatch.pl warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 97571f1d697b..beeff4258b19 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
 	struct device_dma_parameters dma_parms;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 
 	struct mtk_hsdma_chan chan[1];
-- 
2.11.0

Re: [PATCH] Staging: mt7621-dma: Add blank line after declarations

[Greg Kroah-Hartman]

On Tue, Mar 19, 2019 at 09:18:54PM -0700, Wentao Cai wrote:
> Add a blank line after declaration to mute checkpatch.pl warning:
> WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 97571f1d697b..beeff4258b19 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
>  	struct device_dma_parameters dma_parms;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;

Please look at what you did here and compare it to what the checkpatch
warning said it was doing.  Hint, checkpatch is wrong here...

Always use your brain when dealing with checkpatch as it is just a dumb
perl script :)

thanks,

greg k-h

Re: [PATCH] Staging: mt7621-dma: Add blank line after declarations

[Wentao Cai]

[-- Attachment #1.1: Type: text/plain, Size: 1229 bytes --]

On Tuesday, March 19, 2019 at 10:11:33 PM UTC-7, gregkh wrote:
>
> On Tue, Mar 19, 2019 at 09:18:54PM -0700, Wentao Cai wrote: 
> > Add a blank line after declaration to mute checkpatch.pl warning: 
> > WARNING: Missing a blank line after declarations 
> > 
> > Signed-off-by: Wentao Cai <etsa...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + 
> >  1 file changed, 1 insertion(+) 
> > 
> > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c 
> b/drivers/staging/mt7621-dma/mtk-hsdma.c 
> > index 97571f1d697b..beeff4258b19 100644 
> > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c 
> > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c 
> > @@ -157,6 +157,7 @@ struct mtk_hsdam_engine { 
> >          struct device_dma_parameters dma_parms; 
> >          void __iomem *base; 
> >          struct tasklet_struct task; 
> > + 
> >          volatile unsigned long chan_issued; 
>
> Please look at what you did here and compare it to what the checkpatch 
> warning said it was doing.  Hint, checkpatch is wrong here... 
>
> Always use your brain when dealing with checkpatch as it is just a dumb 
> perl script :) 
>
>  
Sorry, I'll be more careful next time.

Wentao
  

> thanks, 
>
> greg k-h 
>

[-- Attachment #1.2: Type: text/html, Size: 2354 bytes --]