* [PATCH 1/2] staging: pi433: fix line over 80 characters
@ 2019-03-20 23:00 Jules Irenge
2019-03-20 23:00 ` [PATCH 2/2] " Jules Irenge
0 siblings, 1 reply; 3+ messages in thread
From: Jules Irenge @ 2019-03-20 23:00 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Fix coding style issues which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index b2314636dc89..f537722395c6 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -479,7 +479,8 @@ pi433_receive(void *data)
/* length byte enabled? */
if (dev->rx_cfg.enable_length_byte == OPTION_ON) {
retval = wait_event_interruptible(dev->fifo_wait_queue,
- dev->free_in_fifo < FIFO_SIZE);
+ dev->free_in_fifo <
+ FIFO_SIZE);
if (retval) /* wait was interrupted */
goto abort;
@@ -500,7 +501,8 @@ pi433_receive(void *data)
bytes_total--;
retval = wait_event_interruptible(dev->fifo_wait_queue,
- dev->free_in_fifo < FIFO_SIZE);
+ dev->free_in_fifo <
+ FIFO_SIZE);
if (retval) /* wait was interrupted */
goto abort;
@@ -513,7 +515,8 @@ pi433_receive(void *data)
while (dev->rx_position < bytes_total) {
if (!rf69_get_flag(dev->spi, payload_ready)) {
retval = wait_event_interruptible(dev->fifo_wait_queue,
- dev->free_in_fifo < FIFO_SIZE);
+ dev->free_in_fifo <
+ FIFO_SIZE);
if (retval) /* wait was interrupted */
goto abort;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] staging: pi433: fix line over 80 characters
2019-03-20 23:00 [PATCH 1/2] staging: pi433: fix line over 80 characters Jules Irenge
@ 2019-03-20 23:00 ` Jules Irenge
2019-03-21 7:21 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jules Irenge @ 2019-03-20 23:00 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Fix coding style issues which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index f537722395c6..10245719b5cb 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -45,10 +45,10 @@
#include "pi433_if.h"
#include "rf69.h"
-#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
-#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
-#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
-#define NUM_DIO 2
+#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
+#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
+#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
+#define NUM_DIO 2
static dev_t pi433_dev;
static DEFINE_IDR(pi433_idr);
@@ -672,7 +672,8 @@ pi433_tx_thread(void *data)
if (retval < 0)
return retval;
if (tx_cfg.enable_length_byte == OPTION_ON) {
- retval = rf69_set_payload_length(spi, size * tx_cfg.repetitions);
+ retval = rf69_set_payload_length(spi, size *
+ tx_cfg.repetitions);
if (retval < 0)
return retval;
} else {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] staging: pi433: fix line over 80 characters
2019-03-20 23:00 ` [PATCH 2/2] " Jules Irenge
@ 2019-03-21 7:21 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-03-21 7:21 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel
On Wed, Mar 20, 2019 at 11:00:48PM +0000, Jules Irenge wrote:
> Fix coding style issues which solves checkpatch.pl warning:
> "WARNING: line over 80 characters".
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
You sent 2 patches that did different things, yet had the same subject
line :(
Please look at how other patch series are named and resend.
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index f537722395c6..10245719b5cb 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -45,10 +45,10 @@
> #include "pi433_if.h"
> #include "rf69.h"
>
> -#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
> -#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
> -#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
> -#define NUM_DIO 2
> +#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
> +#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
> +#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
> +#define NUM_DIO 2
>
> static dev_t pi433_dev;
> static DEFINE_IDR(pi433_idr);
> @@ -672,7 +672,8 @@ pi433_tx_thread(void *data)
> if (retval < 0)
> return retval;
> if (tx_cfg.enable_length_byte == OPTION_ON) {
> - retval = rf69_set_payload_length(spi, size * tx_cfg.repetitions);
> + retval = rf69_set_payload_length(spi, size *
> + tx_cfg.repetitions);
This should be broken at the , which makes it easier to understand.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-21 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 23:00 [PATCH 1/2] staging: pi433: fix line over 80 characters Jules Irenge
2019-03-20 23:00 ` [PATCH 2/2] " Jules Irenge
2019-03-21 7:21 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.