All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com,
	jakub.kicinski@netronome.com, f.fainelli@gmail.com,
	andrew@lunn.ch, vivien.didelot@gmail.com
Subject: [patch net-next 07/11] net: devlink: don't pass return value of __devlink_port_type_set()
Date: Thu, 21 Mar 2019 14:20:15 +0100	[thread overview]
Message-ID: <20190321132019.1426-8-jiri@resnulli.us> (raw)
In-Reply-To: <20190321132019.1426-1-jiri@resnulli.us>

From: Jiri Pirko <jiri@mellanox.com>

__devlink_port_type_set() returns void, it makes no sense to pass it on,
so don't do that.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 net/core/devlink.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index 1e125c3b890c..98ca788ffd97 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -5379,8 +5379,7 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port,
 void devlink_port_type_eth_set(struct devlink_port *devlink_port,
 			       struct net_device *netdev)
 {
-	return __devlink_port_type_set(devlink_port,
-				       DEVLINK_PORT_TYPE_ETH, netdev);
+	__devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_ETH, netdev);
 }
 EXPORT_SYMBOL_GPL(devlink_port_type_eth_set);
 
@@ -5393,8 +5392,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_eth_set);
 void devlink_port_type_ib_set(struct devlink_port *devlink_port,
 			      struct ib_device *ibdev)
 {
-	return __devlink_port_type_set(devlink_port,
-				       DEVLINK_PORT_TYPE_IB, ibdev);
+	__devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_IB, ibdev);
 }
 EXPORT_SYMBOL_GPL(devlink_port_type_ib_set);
 
@@ -5405,8 +5403,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_ib_set);
  */
 void devlink_port_type_clear(struct devlink_port *devlink_port)
 {
-	return __devlink_port_type_set(devlink_port,
-				       DEVLINK_PORT_TYPE_NOTSET, NULL);
+	__devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_NOTSET, NULL);
 }
 EXPORT_SYMBOL_GPL(devlink_port_type_clear);
 
-- 
2.17.2


  parent reply	other threads:[~2019-03-21 13:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 13:20 [patch net-next 00/11] devlink: small spring cleanup Jiri Pirko
2019-03-21 13:20 ` [patch net-next 01/11] net: devlink: add couple of missing mutex_destroy() calls Jiri Pirko
2019-03-21 13:20 ` [patch net-next 02/11] bnxt: add missing net/devlink.h include Jiri Pirko
2019-03-22  9:16   ` Vasundhara Volam
2019-03-22 13:38     ` Jiri Pirko
2019-03-21 13:20 ` [patch net-next 03/11] dsa: " Jiri Pirko
2019-03-21 14:12   ` Andrew Lunn
2019-03-21 13:20 ` [patch net-next 04/11] bnxt: set devlink port attrs properly Jiri Pirko
2019-03-21 13:20 ` [patch net-next 05/11] bnxt: call devlink_port_type_eth_set() before port register Jiri Pirko
2019-03-21 13:20 ` [patch net-next 06/11] net: devlink: don't take devlink_mutex for devlink_compat_* Jiri Pirko
2019-03-21 19:08   ` Jakub Kicinski
2019-03-22 13:44     ` Jiri Pirko
2019-03-21 13:20 ` Jiri Pirko [this message]
2019-03-21 13:20 ` [patch net-next 08/11] mlxsw: Move devlink_port_attrs_set() call before register Jiri Pirko
2019-03-21 13:20 ` [patch net-next 09/11] dsa: move " Jiri Pirko
2019-03-21 13:41   ` Andrew Lunn
2019-03-21 13:44     ` Jiri Pirko
2019-03-21 13:20 ` [patch net-next 10/11] net: devlink: disallow port_attrs_set() to be called " Jiri Pirko
2019-03-21 13:20 ` [patch net-next 11/11] net: devlink: add port type spinlock Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321132019.1426-8-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.