* [PATCH] spi: export tracepoint symbols to modules
@ 2019-03-21 12:42 Arnd Bergmann
2019-03-21 15:07 ` Mark Brown
2019-03-21 15:49 ` [PATCH] spi: export tracepoint symbols to modules Uwe Kleine-König
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2019-03-21 12:42 UTC (permalink / raw)
To: Mark Brown
Cc: Uwe Kleine-König, Arnd Bergmann, Boris Brezillon,
Geert Uytterhoeven, linux-spi, linux-kernel
The newly added tracepoints in the spi-mxs driver cause a link
error when the driver is a loadable module:
ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!
I'm not quite sure where to put the export statements, but
directly after the inclusion of the header seems as good as
any other place.
Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/spi/spi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 93986f879b09..e5d38152888a 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -36,6 +36,8 @@
#define CREATE_TRACE_POINTS
#include <trace/events/spi.h>
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_start);
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_stop);
#include "internals.h"
--
2.20.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Applied "spi: export tracepoint symbols to modules" to the spi tree
2019-03-21 12:42 [PATCH] spi: export tracepoint symbols to modules Arnd Bergmann
@ 2019-03-21 15:07 ` Mark Brown
2019-03-21 15:49 ` [PATCH] spi: export tracepoint symbols to modules Uwe Kleine-König
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-03-21 15:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Brown, Mark Brown, Uwe Kleine-König, Boris Brezillon,
Geert Uytterhoeven, linux-spi, linux-kernel, linux-spi
The patch
spi: export tracepoint symbols to modules
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From ca1438dcb34c7fcad63b6ce14ea63a870b92a69b Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 21 Mar 2019 13:42:25 +0100
Subject: [PATCH] spi: export tracepoint symbols to modules
The newly added tracepoints in the spi-mxs driver cause a link
error when the driver is a loadable module:
ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!
I'm not quite sure where to put the export statements, but
directly after the inclusion of the header seems as good as
any other place.
Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 2be394d3bc59..bd2a424672df 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -36,6 +36,8 @@
#define CREATE_TRACE_POINTS
#include <trace/events/spi.h>
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_start);
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_stop);
#include "internals.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Applied "spi: export tracepoint symbols to modules" to the spi tree
@ 2019-03-21 15:07 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-03-21 15:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Brown, Mark Brown, Uwe Kleine-König, Boris Brezillon,
Geert Uytterhoeven, linux-spi, linux-kernel, linux-spi
The patch
spi: export tracepoint symbols to modules
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From ca1438dcb34c7fcad63b6ce14ea63a870b92a69b Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 21 Mar 2019 13:42:25 +0100
Subject: [PATCH] spi: export tracepoint symbols to modules
The newly added tracepoints in the spi-mxs driver cause a link
error when the driver is a loadable module:
ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!
I'm not quite sure where to put the export statements, but
directly after the inclusion of the header seems as good as
any other place.
Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 2be394d3bc59..bd2a424672df 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -36,6 +36,8 @@
#define CREATE_TRACE_POINTS
#include <trace/events/spi.h>
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_start);
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_stop);
#include "internals.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] spi: export tracepoint symbols to modules
2019-03-21 12:42 [PATCH] spi: export tracepoint symbols to modules Arnd Bergmann
2019-03-21 15:07 ` Mark Brown
@ 2019-03-21 15:49 ` Uwe Kleine-König
1 sibling, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2019-03-21 15:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Brown, Boris Brezillon, Geert Uytterhoeven, linux-spi, linux-kernel
On Thu, Mar 21, 2019 at 01:42:25PM +0100, Arnd Bergmann wrote:
> The newly added tracepoints in the spi-mxs driver cause a link
> error when the driver is a loadable module:
>
> ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
> ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!
>
> I'm not quite sure where to put the export statements, but
> directly after the inclusion of the header seems as good as
> any other place.
I agree it looks a bit ugly, but I don't have a better idea either.
>
> Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks right:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks for finding and fixing that.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-21 15:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 12:42 [PATCH] spi: export tracepoint symbols to modules Arnd Bergmann
2019-03-21 15:07 ` Applied "spi: export tracepoint symbols to modules" to the spi tree Mark Brown
2019-03-21 15:07 ` Mark Brown
2019-03-21 15:49 ` [PATCH] spi: export tracepoint symbols to modules Uwe Kleine-König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.