* [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of
@ 2019-03-21 18:14 Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 1/5] staging: rtl8723bs: include: remove typedef for struct pno_nlo_info Himadri Pandya
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Himadri Pandya @ 2019-03-21 18:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Himadri Pandya
This patchset removes typedef from various structures defined in
/staging/rtl8723bs/include/rtw_pwrctl.h as
the linux kernel coding style guidelines discourage the use of typedef
for struct types.
V2:
- Remove extra whitespaces
Himadri Pandya (5):
staging: rtl8723bs: include: remove typedef for struct pno_nlo_info
staging: rtl8723bs: include: remove typedef for struct pno_ssid
staging: rtl8723bs: include: remove typedef for struct pno_ssid_list
staging: rtl8723bs: include: remove typedef for struct
pno_scan_channel_info
staging: rtl8723bs: include: remove typedef for struct pno_scan_info
.../staging/rtl8723bs/include/rtw_pwrctrl.h | 30 +++++++++----------
1 file changed, 15 insertions(+), 15 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/5] staging: rtl8723bs: include: remove typedef for struct pno_nlo_info
2019-03-21 18:14 [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Himadri Pandya
@ 2019-03-21 18:14 ` Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 2/5] staging: rtl8723bs: include: remove typedef for struct pno_ssid Himadri Pandya
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Himadri Pandya @ 2019-03-21 18:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Himadri Pandya
Remove typedef for struct pno_nlo_info as the Linux kernel coding style
guidelines discourage the use of typedefs for struct types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
Changes in V2:
- Remove extra whitespaces befor *pnlo_info
---
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
index e2a4c680125f..df85267363b8 100644
--- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
+++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
@@ -159,7 +159,7 @@ enum PS_DENY_REASON {
};
#ifdef CONFIG_PNO_SUPPORT
-typedef struct pno_nlo_info
+struct pno_nlo_info
{
u32 fast_scan_period; /* Fast scan period */
u32 ssid_num; /* number of entry */
@@ -168,7 +168,7 @@ typedef struct pno_nlo_info
u8 ssid_length[MAX_PNO_LIST_COUNT]; /* SSID Length Array */
u8 ssid_cipher_info[MAX_PNO_LIST_COUNT]; /* Cipher information for security */
u8 ssid_channel_info[MAX_PNO_LIST_COUNT]; /* channel information */
-}pno_nlo_info_t;
+};
typedef struct pno_ssid {
u32 SSID_len;
@@ -279,7 +279,7 @@ struct pwrctrl_priv
#ifdef CONFIG_PNO_SUPPORT
u8 pno_in_resume;
u8 pno_inited;
- pno_nlo_info_t *pnlo_info;
+ struct pno_nlo_info *pnlo_info;
pno_scan_info_t *pscan_info;
pno_ssid_list_t *pno_ssid_list;
#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/5] staging: rtl8723bs: include: remove typedef for struct pno_ssid
2019-03-21 18:14 [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 1/5] staging: rtl8723bs: include: remove typedef for struct pno_nlo_info Himadri Pandya
@ 2019-03-21 18:14 ` Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 3/5] staging: rtl8723bs: include: remove typedef for struct pno_ssid_list Himadri Pandya
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Himadri Pandya @ 2019-03-21 18:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Himadri Pandya
Remove typedef for struct pno_ssid as The Linux kernel coding style
guidelines discourage the use of typedefs for struct types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
index df85267363b8..ba79a98fdc67 100644
--- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
+++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
@@ -170,13 +170,13 @@ struct pno_nlo_info
u8 ssid_channel_info[MAX_PNO_LIST_COUNT]; /* channel information */
};
-typedef struct pno_ssid {
+struct pno_ssid {
u32 SSID_len;
u8 SSID[32];
-} pno_ssid_t;
+};
typedef struct pno_ssid_list {
- pno_ssid_t node[MAX_PNO_LIST_COUNT];
+ struct pno_ssid node[MAX_PNO_LIST_COUNT];
}pno_ssid_list_t;
typedef struct pno_scan_channel_info
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/5] staging: rtl8723bs: include: remove typedef for struct pno_ssid_list
2019-03-21 18:14 [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 1/5] staging: rtl8723bs: include: remove typedef for struct pno_nlo_info Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 2/5] staging: rtl8723bs: include: remove typedef for struct pno_ssid Himadri Pandya
@ 2019-03-21 18:14 ` Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 4/5] staging: rtl8723bs: include: remove typedef for struct pno_scan_channel_info Himadri Pandya
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Himadri Pandya @ 2019-03-21 18:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Himadri Pandya
Remove typedef from struct pno_ssid_list as The Linux kernel coding
style guidelines discourage the use of typedefs for struct types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
Changes in V2:
- Remove extra whitespaces before *pno_ssid_list
---
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
index ba79a98fdc67..8912182e229f 100644
--- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
+++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
@@ -175,9 +175,9 @@ struct pno_ssid {
u8 SSID[32];
};
-typedef struct pno_ssid_list {
+struct pno_ssid_list {
struct pno_ssid node[MAX_PNO_LIST_COUNT];
-}pno_ssid_list_t;
+};
typedef struct pno_scan_channel_info
{
@@ -281,7 +281,7 @@ struct pwrctrl_priv
u8 pno_inited;
struct pno_nlo_info *pnlo_info;
pno_scan_info_t *pscan_info;
- pno_ssid_list_t *pno_ssid_list;
+ struct pno_ssid_list *pno_ssid_list;
#endif
u32 wowlan_pattern_context[8][5];
u64 wowlan_fw_iv;
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 4/5] staging: rtl8723bs: include: remove typedef for struct pno_scan_channel_info
2019-03-21 18:14 [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Himadri Pandya
` (2 preceding siblings ...)
2019-03-21 18:14 ` [PATCH v2 3/5] staging: rtl8723bs: include: remove typedef for struct pno_ssid_list Himadri Pandya
@ 2019-03-21 18:14 ` Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 5/5] staging: rtl8723bs: include: remove typedef for struct pno_scan_info Himadri Pandya
2019-03-21 19:12 ` [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Greg KH
5 siblings, 0 replies; 7+ messages in thread
From: Himadri Pandya @ 2019-03-21 18:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Himadri Pandya
Remove typedef for struct pno_scan_channel_info as The Linux kernel
coding style guidelines discourage the use of typedefs for struct
types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
index 8912182e229f..3ea04bff0cbd 100644
--- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
+++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
@@ -179,13 +179,13 @@ struct pno_ssid_list {
struct pno_ssid node[MAX_PNO_LIST_COUNT];
};
-typedef struct pno_scan_channel_info
+struct pno_scan_channel_info
{
u8 channel;
u8 tx_power;
u8 timeout;
u8 active; /* set 1 means active scan, or pasivite scan. */
-}pno_scan_channel_info_t;
+};
typedef struct pno_scan_info
{
@@ -198,7 +198,7 @@ typedef struct pno_scan_info
u8 orig_ch; /* original channel */
u8 channel_num; /* number of channel */
u64 rfe_type; /* rfe_type && 0x00000000000000ff */
- pno_scan_channel_info_t ssid_channel_info[MAX_SCAN_LIST_COUNT];
+ struct pno_scan_channel_info ssid_channel_info[MAX_SCAN_LIST_COUNT];
}pno_scan_info_t;
#endif /* CONFIG_PNO_SUPPORT */
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 5/5] staging: rtl8723bs: include: remove typedef for struct pno_scan_info
2019-03-21 18:14 [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Himadri Pandya
` (3 preceding siblings ...)
2019-03-21 18:14 ` [PATCH v2 4/5] staging: rtl8723bs: include: remove typedef for struct pno_scan_channel_info Himadri Pandya
@ 2019-03-21 18:14 ` Himadri Pandya
2019-03-21 19:12 ` [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Greg KH
5 siblings, 0 replies; 7+ messages in thread
From: Himadri Pandya @ 2019-03-21 18:14 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Himadri Pandya
Remove typedef for struct pno_scan_info as The Linux kernel coding style
guidelines discourage the use of typedefs for struct types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
Changes in V2:
- Remove extra whitespaces befor *pscan_info
---
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
index 3ea04bff0cbd..2bc922ce5ae1 100644
--- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
+++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
@@ -187,7 +187,7 @@ struct pno_scan_channel_info
u8 active; /* set 1 means active scan, or pasivite scan. */
};
-typedef struct pno_scan_info
+struct pno_scan_info
{
u8 enableRFE; /* Enable RFE */
u8 period_scan_time; /* exclusive with fast_scan_period and slow_scan_period */
@@ -199,7 +199,7 @@ typedef struct pno_scan_info
u8 channel_num; /* number of channel */
u64 rfe_type; /* rfe_type && 0x00000000000000ff */
struct pno_scan_channel_info ssid_channel_info[MAX_SCAN_LIST_COUNT];
-}pno_scan_info_t;
+};
#endif /* CONFIG_PNO_SUPPORT */
struct pwrctrl_priv
@@ -280,7 +280,7 @@ struct pwrctrl_priv
u8 pno_in_resume;
u8 pno_inited;
struct pno_nlo_info *pnlo_info;
- pno_scan_info_t *pscan_info;
+ struct pno_scan_info *pscan_info;
struct pno_ssid_list *pno_ssid_list;
#endif
u32 wowlan_pattern_context[8][5];
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of
2019-03-21 18:14 [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Himadri Pandya
` (4 preceding siblings ...)
2019-03-21 18:14 ` [PATCH v2 5/5] staging: rtl8723bs: include: remove typedef for struct pno_scan_info Himadri Pandya
@ 2019-03-21 19:12 ` Greg KH
5 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2019-03-21 19:12 UTC (permalink / raw)
To: Himadri Pandya; +Cc: outreachy-kernel
On Thu, Mar 21, 2019 at 11:44:00PM +0530, Himadri Pandya wrote:
> This patchset removes typedef from various structures defined in
> /staging/rtl8723bs/include/rtw_pwrctl.h as
> the linux kernel coding style guidelines discourage the use of typedef
> for struct types.
>
> V2:
> - Remove extra whitespaces
Nice work, all now applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-21 19:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 18:14 [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 1/5] staging: rtl8723bs: include: remove typedef for struct pno_nlo_info Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 2/5] staging: rtl8723bs: include: remove typedef for struct pno_ssid Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 3/5] staging: rtl8723bs: include: remove typedef for struct pno_ssid_list Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 4/5] staging: rtl8723bs: include: remove typedef for struct pno_scan_channel_info Himadri Pandya
2019-03-21 18:14 ` [PATCH v2 5/5] staging: rtl8723bs: include: remove typedef for struct pno_scan_info Himadri Pandya
2019-03-21 19:12 ` [PATCH v2 0/5] staging: rtl8723bs: include: remove typedef of Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.