* [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools
@ 2019-03-19 18:15 luca.boccassi
2019-03-20 13:46 ` Tom Rini
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: luca.boccassi @ 2019-03-19 18:15 UTC (permalink / raw)
To: openembedded-core
From: Luca Boccassi <luca.boccassi@microsoft.com>
Dumpimage and fit_check_sign can be used to extract kernel and ramdisk from
a FIT file, verify them and kexec for a faster reboot.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
index ff26e32482..c487849bb2 100644
--- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
+++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
@@ -45,6 +45,14 @@ do_install () {
# mkenvimage
install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
+
+ # dumpimage
+ install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage
+ ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
+
+ # fit_check_sign
+ install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-fit_check_sign
+ ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
}
ALLOW_EMPTY_${PN} = "1"
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools
2019-03-19 18:15 [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools luca.boccassi
@ 2019-03-20 13:46 ` Tom Rini
2019-03-21 11:44 ` Richard Purdie
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Tom Rini @ 2019-03-20 13:46 UTC (permalink / raw)
To: luca.boccassi; +Cc: openembedded-core
On Tue, Mar 19, 2019 at 06:15:44PM +0000, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> Dumpimage and fit_check_sign can be used to extract kernel and ramdisk from
> a FIT file, verify them and kexec for a faster reboot.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools
2019-03-19 18:15 [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools luca.boccassi
2019-03-20 13:46 ` Tom Rini
@ 2019-03-21 11:44 ` Richard Purdie
2019-03-21 12:53 ` Luca Boccassi
2019-03-21 18:35 ` [PATCH v2] " luca.boccassi
2019-03-21 19:49 ` [PATCH v3] " luca.boccassi
3 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2019-03-21 11:44 UTC (permalink / raw)
To: luca.boccassi, openembedded-core; +Cc: Tom Rini
On Tue, 2019-03-19 at 18:15 +0000, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> Dumpimage and fit_check_sign can be used to extract kernel and
> ramdisk from
> a FIT file, verify them and kexec for a faster reboot.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> index ff26e32482..c487849bb2 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> @@ -45,6 +45,14 @@ do_install () {
> # mkenvimage
> install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
> ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
> +
> + # dumpimage
> + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage
> + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
> +
> + # fit_check_sign
> + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-
> fit_check_sign
> + ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
> }
>
> ALLOW_EMPTY_${PN} = "1"
Fails on musl:
https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/420
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/421
no-x11:
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/419
qemux86-world:
https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/412
so basically it looks like any world build fails with this.
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools
2019-03-21 11:44 ` Richard Purdie
@ 2019-03-21 12:53 ` Luca Boccassi
0 siblings, 0 replies; 8+ messages in thread
From: Luca Boccassi @ 2019-03-21 12:53 UTC (permalink / raw)
To: Richard Purdie, openembedded-core; +Cc: Tom Rini
On Thu, 2019-03-21 at 11:44 +0000, Richard Purdie wrote:
> On Tue, 2019-03-19 at 18:15 +0000, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > Dumpimage and fit_check_sign can be used to extract kernel and
> > ramdisk from
> > a FIT file, verify them and kexec for a faster reboot.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > index ff26e32482..c487849bb2 100644
> > --- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > +++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > @@ -45,6 +45,14 @@ do_install () {
> > # mkenvimage
> > install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
> > ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
> > +
> > + # dumpimage
> > + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage
> > + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
> > +
> > + # fit_check_sign
> > + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-
> > fit_check_sign
> > + ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
> > }
> >
> > ALLOW_EMPTY_${PN} = "1"
>
> Fails on musl:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/420
> https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/421
> no-x11:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/419
> qemux86-world:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/412
>
> so basically it looks like any world build fails with this.
>
> Cheers,
>
> Richard
Hi,
Sorry about that, this recipe has changed a bit since sumo - it seems
the files need to be also listed individually in FILES_${PN}:
ERROR: u-boot-tools-1_2019.01-r0 do_package: QA Issue: u-boot-tools:
Files/directories were installed but not shipped in any package:
/usr/bin/uboot-dumpimage
/usr/bin/fit_check_sign
/usr/bin/dumpimage
/usr/bin/uboot-fit_check_sign
Please set FILES such that these items are packaged. Alternatively if
they are unneeded, avoid installing them or delete them within
do_install.
eg:
-FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage"
+FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage {bindir}/uboot-dumpimage ${bindir}/dumpimage {bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
Is this the right solution? Or should it be a new package?
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] u-boot: install dumpimage and fit_check_sign in u-boot-tools
2019-03-19 18:15 [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools luca.boccassi
2019-03-20 13:46 ` Tom Rini
2019-03-21 11:44 ` Richard Purdie
@ 2019-03-21 18:35 ` luca.boccassi
2019-03-21 19:30 ` Alex Kiernan
2019-03-21 19:49 ` [PATCH v3] " luca.boccassi
3 siblings, 1 reply; 8+ messages in thread
From: luca.boccassi @ 2019-03-21 18:35 UTC (permalink / raw)
To: openembedded-core
From: Luca Boccassi <luca.boccassi@microsoft.com>
Dumpimage and fit_check_sign can be used to extract kernel and ramdisk from
a FIT file, verify them and kexec for a faster reboot.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
v2: add dumpimage and fit_check_sign to FILES_${PN}-mkimage to fix build.
Not sure if it's preferable to do this or to add a new package, please
advise if the other is better.
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
index ff26e32482..b72033a566 100644
--- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
+++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
@@ -45,11 +45,19 @@ do_install () {
# mkenvimage
install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
+
+ # dumpimage
+ install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage
+ ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
+
+ # fit_check_sign
+ install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-fit_check_sign
+ ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
}
ALLOW_EMPTY_${PN} = "1"
FILES_${PN} = ""
-FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage"
+FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage {bindir}/uboot-dumpimage ${bindir}/dumpimage {bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage ${bindir}/mkenvimage"
RDEPENDS_${PN}-mkimage += "dtc"
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] u-boot: install dumpimage and fit_check_sign in u-boot-tools
2019-03-21 18:35 ` [PATCH v2] " luca.boccassi
@ 2019-03-21 19:30 ` Alex Kiernan
2019-03-21 19:49 ` Luca Boccassi
0 siblings, 1 reply; 8+ messages in thread
From: Alex Kiernan @ 2019-03-21 19:30 UTC (permalink / raw)
To: luca.boccassi; +Cc: Patches and discussions about the oe-core layer
On Thu, Mar 21, 2019 at 6:36 PM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> Dumpimage and fit_check_sign can be used to extract kernel and ramdisk from
> a FIT file, verify them and kexec for a faster reboot.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> v2: add dumpimage and fit_check_sign to FILES_${PN}-mkimage to fix build.
> Not sure if it's preferable to do this or to add a new package, please
> advise if the other is better.
>
> meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> index ff26e32482..b72033a566 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> @@ -45,11 +45,19 @@ do_install () {
> # mkenvimage
> install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
> ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
> +
> + # dumpimage
> + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage
> + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
> +
> + # fit_check_sign
> + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-fit_check_sign
> + ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
> }
>
> ALLOW_EMPTY_${PN} = "1"
> FILES_${PN} = ""
> -FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage"
> +FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage
> {bindir}/uboot-dumpimage ${bindir}/dumpimage
There's no $ here
> {bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
or here
> FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage ${bindir}/mkenvimage"
>
> RDEPENDS_${PN}-mkimage += "dtc"
--
Alex Kiernan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] u-boot: install dumpimage and fit_check_sign in u-boot-tools
2019-03-19 18:15 [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools luca.boccassi
` (2 preceding siblings ...)
2019-03-21 18:35 ` [PATCH v2] " luca.boccassi
@ 2019-03-21 19:49 ` luca.boccassi
3 siblings, 0 replies; 8+ messages in thread
From: luca.boccassi @ 2019-03-21 19:49 UTC (permalink / raw)
To: openembedded-core
From: Luca Boccassi <luca.boccassi@microsoft.com>
Dumpimage and fit_check_sign can be used to extract kernel and ramdisk from
a FIT file, verify them and kexec for a faster reboot.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
v2: add dumpimage and fit_check_sign to FILES_${PN}-mkimage to fix build.
Not sure if it's preferable to do this or to add a new package, please
advise if the other is better.
v3: fix copypasta
meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
index ff26e32482..bede984ef7 100644
--- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
+++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
@@ -45,11 +45,19 @@ do_install () {
# mkenvimage
install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
+
+ # dumpimage
+ install -m 0755 tools/dumpimage ${D}${bindir}/uboot-dumpimage
+ ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
+
+ # fit_check_sign
+ install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-fit_check_sign
+ ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
}
ALLOW_EMPTY_${PN} = "1"
FILES_${PN} = ""
-FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage"
+FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage ${bindir}/uboot-dumpimage ${bindir}/dumpimage ${bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage ${bindir}/mkenvimage"
RDEPENDS_${PN}-mkimage += "dtc"
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] u-boot: install dumpimage and fit_check_sign in u-boot-tools
2019-03-21 19:30 ` Alex Kiernan
@ 2019-03-21 19:49 ` Luca Boccassi
0 siblings, 0 replies; 8+ messages in thread
From: Luca Boccassi @ 2019-03-21 19:49 UTC (permalink / raw)
To: Alex Kiernan; +Cc: Patches and discussions about the oe-core layer
On Thu, 2019-03-21 at 19:30 +0000, Alex Kiernan wrote:
> On Thu, Mar 21, 2019 at 6:36 PM <luca.boccassi@gmail.com> wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > Dumpimage and fit_check_sign can be used to extract kernel and
> > ramdisk from
> > a FIT file, verify them and kexec for a faster reboot.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > v2: add dumpimage and fit_check_sign to FILES_${PN}-mkimage to fix
> > build.
> > Not sure if it's preferable to do this or to add a new package,
> > please
> > advise if the other is better.
> >
> > meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > index ff26e32482..b72033a566 100644
> > --- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > +++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > @@ -45,11 +45,19 @@ do_install () {
> > # mkenvimage
> > install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-
> > mkenvimage
> > ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
> > +
> > + # dumpimage
> > + install -m 0755 tools/dumpimage ${D}${bindir}/uboot-
> > dumpimage
> > + ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
> > +
> > + # fit_check_sign
> > + install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-
> > fit_check_sign
> > + ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
> > }
> >
> > ALLOW_EMPTY_${PN} = "1"
> > FILES_${PN} = ""
> > -FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage"
> > +FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage
> > {bindir}/uboot-dumpimage ${bindir}/dumpimage
>
> There's no $ here
>
> > {bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
>
> or here
>
> > FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage
> > ${bindir}/mkenvimage"
> >
> > RDEPENDS_${PN}-mkimage += "dtc"
D'oh, copypasta! Thanks, fixed in v3
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-21 19:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 18:15 [PATCH] u-boot: install dumpimage and fit_check_sign in u-boot-tools luca.boccassi
2019-03-20 13:46 ` Tom Rini
2019-03-21 11:44 ` Richard Purdie
2019-03-21 12:53 ` Luca Boccassi
2019-03-21 18:35 ` [PATCH v2] " luca.boccassi
2019-03-21 19:30 ` Alex Kiernan
2019-03-21 19:49 ` Luca Boccassi
2019-03-21 19:49 ` [PATCH v3] " luca.boccassi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.