[igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Run basic test on simulation

[igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Run basic test on simulation

[Prathap Kumar Valsan]

Basic test don't take long to complete, so allow basic test to
run on simulation.
---
 tests/i915/gem_exec_gttfill.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
index efd612bb..92c3cf62 100644
--- a/tests/i915/gem_exec_gttfill.c
+++ b/tests/i915/gem_exec_gttfill.c
@@ -144,7 +144,8 @@ static void fillgtt(int fd, unsigned ring, int timeout)
 	count = size / BATCH_SIZE + 1;
 	igt_debug("Using %'d batches to fill %'llu aperture on %d engines\n",
 		  count, (long long)size, nengine);
-	intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
+	if (!igt_run_in_simulation())
+		intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
 	intel_detect_and_clear_missed_interrupts(fd);
 
 	memset(&execbuf, 0, sizeof(execbuf));
@@ -210,8 +211,6 @@ igt_main
 	const struct intel_execution_engine *e;
 	int device = -1;
 
-	igt_skip_on_simulation();
-
 	igt_fixture {
 		device = drm_open_driver(DRIVER_INTEL);
 		igt_require_gem(device);
@@ -223,11 +222,15 @@ igt_main
 		fillgtt(device, 0, 1); /* just enough to run a single pass */
 
 	for (e = intel_execution_engines; e->name; e++)
-		igt_subtest_f("%s", e->name)
+		igt_subtest_f("%s", e->name) {
+			igt_skip_on_simulation();
 			fillgtt(device, e->exec_id | e->flags, 20);
+		}
 
-	igt_subtest("all")
+	igt_subtest("all") {
+		igt_skip_on_simulation();
 		fillgtt(device, 0, 150);
+	}
 
 	igt_fixture {
 		igt_stop_hang_detector();
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_gttfill: Run basic test on simulation

[Patchwork]

== Series Details ==

Series: i915/gem_exec_gttfill: Run basic test on simulation
URL   : https://patchwork.freedesktop.org/series/58383/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5791 -> IGTPW_2687
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58383/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2687 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_basic@basic-bsd2:
    - fi-kbl-7500u:       NOTRUN -> SKIP [fdo#109271] +9

  * igt@gem_exec_basic@readonly-bsd1:
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] +57

  * igt@i915_selftest@live_evict:
    - fi-bsw-kefka:       PASS -> DMESG-WARN [fdo#107709]

  * igt@i915_selftest@live_uncore:
    - fi-ivb-3770:        PASS -> DMESG-FAIL [fdo#110210]

  * igt@kms_busy@basic-flip-c:
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-skl-6700k2:      PASS -> INCOMPLETE [fdo#104108]

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       NOTRUN -> DMESG-WARN [fdo#103841]

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          PASS -> FAIL [fdo#103167]

  * igt@kms_psr@primary_mmap_gtt:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] +27

  * igt@prime_vgem@basic-fence-flip:
    - fi-gdg-551:         PASS -> DMESG-FAIL [fdo#103182]

  * igt@runner@aborted:
    - fi-kbl-7500u:       NOTRUN -> FAIL [fdo#103841]
    - fi-bsw-kefka:       NOTRUN -> FAIL [fdo#107709]
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

  
#### Possible fixes ####

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
  [fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210


Participating hosts (44 -> 38)
------------------------------

  Additional (2): fi-snb-2520m fi-kbl-7500u 
  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4897 -> IGTPW_2687

  CI_DRM_5791: 3b6d09692ea282a3487bdf972a068d312a67ca00 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2687: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2687/
  IGT_4897: e12d69496a6bef09ac6c0f792b8d60a65cf5e0bf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2687/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Run basic test on simulation

[Chris Wilson]

Quoting Prathap Kumar Valsan (2019-03-21 23:06:13)
> Basic test don't take long to complete, so allow basic test to
> run on simulation.
> ---
>  tests/i915/gem_exec_gttfill.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
> index efd612bb..92c3cf62 100644
> --- a/tests/i915/gem_exec_gttfill.c
> +++ b/tests/i915/gem_exec_gttfill.c
> @@ -144,7 +144,8 @@ static void fillgtt(int fd, unsigned ring, int timeout)
>         count = size / BATCH_SIZE + 1;
>         igt_debug("Using %'d batches to fill %'llu aperture on %d engines\n",
>                   count, (long long)size, nengine);
> -       intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
> +       if (!igt_run_in_simulation())
> +               intel_require_memory(count, BATCH_SIZE, CHECK_RAM);

No. That is too ugly. You are basically saying that memory limits don't
matter for simulation -- unless the reader is aware of the convoluted
story in the setup and that we've previously marked as anything that
requires to check memory is not suitable for the slow simulator.

Why do you want to run this on the simulator? Write that test.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Run basic test on simulation

[Chris Wilson]

Quoting Kumar Valsan, Prathap (2019-03-22 13:58:52)
> On Fri, Mar 22, 2019 at 07:19:01AM +0000, Chris Wilson wrote:
> > Quoting Prathap Kumar Valsan (2019-03-21 23:06:13)
> > > Basic test don't take long to complete, so allow basic test to
> > > run on simulation.
> > > ---
> > >  tests/i915/gem_exec_gttfill.c | 13 ++++++++-----
> > >  1 file changed, 8 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
> > > index efd612bb..92c3cf62 100644
> > > --- a/tests/i915/gem_exec_gttfill.c
> > > +++ b/tests/i915/gem_exec_gttfill.c
> > > @@ -144,7 +144,8 @@ static void fillgtt(int fd, unsigned ring, int timeout)
> > >         count = size / BATCH_SIZE + 1;
> > >         igt_debug("Using %'d batches to fill %'llu aperture on %d engines\n",
> > >                   count, (long long)size, nengine);
> > > -       intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
> > > +       if (!igt_run_in_simulation())
> > > +               intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
> > 
> > No. That is too ugly. You are basically saying that memory limits don't
> > matter for simulation -- unless the reader is aware of the convoluted
> > story in the setup and that we've previously marked as anything that
> > requires to check memory is not suitable for the slow simulator.
> > 
> Chris,
> gem_exec_gtfill@basic has been marked as a test that we need to run on
> simulation. https://jira.devtools.intel.com/browse/VLK-1649
> This is the intention behind trying to enable this test.

This particular test is a eviction test; we run it against mock HW
inside selftests/ (and as live test). That alone should be enough to
indicate that we don't care about the nuances of HW here, it is pure
software (give or take the usual layering over HW and any serendipity
therein.)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Run basic test on simulation

[Kumar Valsan, Prathap]

On Fri, Mar 22, 2019 at 07:19:01AM +0000, Chris Wilson wrote:
> Quoting Prathap Kumar Valsan (2019-03-21 23:06:13)
> > Basic test don't take long to complete, so allow basic test to
> > run on simulation.
> > ---
> >  tests/i915/gem_exec_gttfill.c | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
> > index efd612bb..92c3cf62 100644
> > --- a/tests/i915/gem_exec_gttfill.c
> > +++ b/tests/i915/gem_exec_gttfill.c
> > @@ -144,7 +144,8 @@ static void fillgtt(int fd, unsigned ring, int timeout)
> >         count = size / BATCH_SIZE + 1;
> >         igt_debug("Using %'d batches to fill %'llu aperture on %d engines\n",
> >                   count, (long long)size, nengine);
> > -       intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
> > +       if (!igt_run_in_simulation())
> > +               intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
> 
> No. That is too ugly. You are basically saying that memory limits don't
> matter for simulation -- unless the reader is aware of the convoluted
> story in the setup and that we've previously marked as anything that
> requires to check memory is not suitable for the slow simulator.
> 
Chris,
gem_exec_gtfill@basic has been marked as a test that we need to run on
simulation. https://jira.devtools.intel.com/browse/VLK-1649
This is the intention behind trying to enable this test.

Will follow-up in the Jira to understand what we need to run for this
test.
> Why do you want to run this on the simulator? Write that test.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev