All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed
@ 2019-03-21 23:18 Dhinakaran Pandiyan
  2019-03-21 23:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Dhinakaran Pandiyan @ 2019-03-21 23:18 UTC (permalink / raw)
  To: igt-dev; +Cc: Dhinakaran Pandiyan

The test leaves the debugfs flag enabled if the driver failed to enable
DSC. And is it turns out, the feature gets enabled only after the test
completes and consequently affects PSR2 tests that follow. Let's make sure
the test cleans up correctly, even if the DSC test itself needs to be
fixed.

Also included some formatting fixes within the function.

Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 tests/kms_dp_dsc.c | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c
index 9792be33..da93cd74 100644
--- a/tests/kms_dp_dsc.c
+++ b/tests/kms_dp_dsc.c
@@ -157,14 +157,16 @@ static void update_display(data_t *data, enum dsc_test_type test_type)
 
 	if (data->connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
 	    data->pipe == PIPE_A) {
-		igt_debug ("DSC not supported on Pipe A on external DP\n");
+		igt_debug("DSC not supported on Pipe A on external DP\n");
 		return;
 	}
 
 	if (test_type == test_basic_dsc_enable) {
-		igt_debug ("DSC is supported on %s\n",
-			   data->conn_name);
+		bool enabled;
+
+		igt_debug("DSC is supported on %s\n", data->conn_name);
 		force_dp_dsc_enable(data);
+
 		igt_create_pattern_fb(data->drm_fd, data->mode->hdisplay,
 				      data->mode->vdisplay,
 				      DRM_FORMAT_XRGB8888,
@@ -174,13 +176,20 @@ static void update_display(data_t *data, enum dsc_test_type test_type)
 						    DRM_PLANE_TYPE_PRIMARY);
 		igt_plane_set_fb(primary, &data->fb_test_pattern);
 		igt_display_commit(&data->display);
-		/* Until we have CRC check support, manually check if RGB test pattern has no corruption */
-		manual ("RGB test pattern without corruption");
-		igt_assert_f(is_dp_dsc_enabled(data),
+
+		/*
+		 * Until we have CRC check support, manually check if RGB test
+		 * pattern has no corruption.
+		 */
+		manual("RGB test pattern without corruption");
+
+		enabled = is_dp_dsc_enabled(data);
+		clear_dp_dsc_enable(data);
+
+		igt_assert_f(enabled,
 			     "Default DSC enable failed on Connector: %s Pipe: %s",
 			     data->conn_name,
 			     kmstest_pipe_name(data->pipe));
-		clear_dp_dsc_enable(data);
 	} else {
 		igt_assert(!"Unknown test type\n");
 	}
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed
  2019-03-21 23:18 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Dhinakaran Pandiyan
@ 2019-03-21 23:50 ` Patchwork
  2019-03-22 19:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2) Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-21 23:50 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: igt-dev

== Series Details ==

Series: tests/kms_dp_dsc: Disable DSC even if enabling failed
URL   : https://patchwork.freedesktop.org/series/58384/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5791 -> IGTPW_2688
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58384/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2688 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_basic@basic-bsd2:
    - fi-kbl-7500u:       NOTRUN -> SKIP [fdo#109271] +9

  * igt@gem_exec_basic@readonly-bsd1:
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] +57

  * igt@kms_busy@basic-flip-c:
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       NOTRUN -> DMESG-WARN [fdo#103841]

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@runner@aborted:
    - fi-kbl-7500u:       NOTRUN -> FAIL [fdo#103841]

  
#### Possible fixes ####

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

  
  [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720


Participating hosts (44 -> 36)
------------------------------

  Additional (2): fi-snb-2520m fi-kbl-7500u 
  Missing    (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u3 fi-pnv-d510 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4897 -> IGTPW_2688

  CI_DRM_5791: 3b6d09692ea282a3487bdf972a068d312a67ca00 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2688: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2688/
  IGT_4897: e12d69496a6bef09ac6c0f792b8d60a65cf5e0bf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2688/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2)
  2019-03-21 23:18 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Dhinakaran Pandiyan
  2019-03-21 23:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-22 19:02 ` Patchwork
  2019-03-22 20:33 ` [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Souza, Jose
  2019-03-23 18:25 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2) Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-22 19:02 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: igt-dev

== Series Details ==

Series: tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2)
URL   : https://patchwork.freedesktop.org/series/58384/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5796 -> IGTPW_2692
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58384/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2692 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_basic@gtt-bsd:
    - fi-bwr-2160:        NOTRUN -> SKIP [fdo#109271] +103

  * igt@gem_exec_basic@readonly-bsd1:
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] +57

  * igt@kms_busy@basic-flip-c:
    - fi-bwr-2160:        NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          PASS -> FAIL [fdo#103167]

  
#### Possible fixes ####

  * igt@i915_selftest@live_evict:
    - fi-bsw-kefka:       DMESG-WARN [fdo#107709] -> PASS

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720


Participating hosts (40 -> 35)
------------------------------

  Additional (2): fi-bwr-2160 fi-snb-2520m 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4899 -> IGTPW_2692

  CI_DRM_5796: 2165d3631bdb91a7b80110b1f76633a19666d0f6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2692: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2692/
  IGT_4899: ba96339c238180b38d05d7fa2dca772d49eee332 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2692/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed
  2019-03-21 23:18 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Dhinakaran Pandiyan
  2019-03-21 23:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2019-03-22 19:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2) Patchwork
@ 2019-03-22 20:33 ` Souza, Jose
  2019-03-25 18:17   ` Dhinakaran Pandiyan
  2019-03-23 18:25 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2) Patchwork
  3 siblings, 1 reply; 6+ messages in thread
From: Souza, Jose @ 2019-03-22 20:33 UTC (permalink / raw)
  To: igt-dev, Pandiyan, Dhinakaran


[-- Attachment #1.1: Type: text/plain, Size: 2639 bytes --]

On Thu, 2019-03-21 at 16:18 -0700, Dhinakaran Pandiyan wrote:
> The test leaves the debugfs flag enabled if the driver failed to
> enable
> DSC. And is it turns out, the feature gets enabled only after the
> test
> completes and consequently affects PSR2 tests that follow. Let's make
> sure
> the test cleans up correctly, even if the DSC test itself needs to be
> fixed.
> 
> Also included some formatting fixes within the function.

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> 
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  tests/kms_dp_dsc.c | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c
> index 9792be33..da93cd74 100644
> --- a/tests/kms_dp_dsc.c
> +++ b/tests/kms_dp_dsc.c
> @@ -157,14 +157,16 @@ static void update_display(data_t *data, enum
> dsc_test_type test_type)
>  
>  	if (data->connector->connector_type ==
> DRM_MODE_CONNECTOR_DisplayPort &&
>  	    data->pipe == PIPE_A) {
> -		igt_debug ("DSC not supported on Pipe A on external
> DP\n");
> +		igt_debug("DSC not supported on Pipe A on external
> DP\n");
>  		return;
>  	}
>  
>  	if (test_type == test_basic_dsc_enable) {
> -		igt_debug ("DSC is supported on %s\n",
> -			   data->conn_name);
> +		bool enabled;
> +
> +		igt_debug("DSC is supported on %s\n", data->conn_name);
>  		force_dp_dsc_enable(data);
> +
>  		igt_create_pattern_fb(data->drm_fd, data->mode-
> >hdisplay,
>  				      data->mode->vdisplay,
>  				      DRM_FORMAT_XRGB8888,
> @@ -174,13 +176,20 @@ static void update_display(data_t *data, enum
> dsc_test_type test_type)
>  						    DRM_PLANE_TYPE_PRIM
> ARY);
>  		igt_plane_set_fb(primary, &data->fb_test_pattern);
>  		igt_display_commit(&data->display);
> -		/* Until we have CRC check support, manually check if
> RGB test pattern has no corruption */
> -		manual ("RGB test pattern without corruption");
> -		igt_assert_f(is_dp_dsc_enabled(data),
> +
> +		/*
> +		 * Until we have CRC check support, manually check if
> RGB test
> +		 * pattern has no corruption.
> +		 */
> +		manual("RGB test pattern without corruption");
> +
> +		enabled = is_dp_dsc_enabled(data);
> +		clear_dp_dsc_enable(data);
> +
> +		igt_assert_f(enabled,
>  			     "Default DSC enable failed on Connector:
> %s Pipe: %s",
>  			     data->conn_name,
>  			     kmstest_pipe_name(data->pipe));
> -		clear_dp_dsc_enable(data);
>  	} else {
>  		igt_assert(!"Unknown test type\n");

Ugr

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2)
  2019-03-21 23:18 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Dhinakaran Pandiyan
                   ` (2 preceding siblings ...)
  2019-03-22 20:33 ` [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Souza, Jose
@ 2019-03-23 18:25 ` Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-23 18:25 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: igt-dev

== Series Details ==

Series: tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2)
URL   : https://patchwork.freedesktop.org/series/58384/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5796_full -> IGTPW_2692_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58384/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2692_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_store@pages-bsd1:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +12

  * igt@kms_busy@extended-modeset-hang-newfb-render-a:
    - shard-snb:          PASS -> DMESG-WARN [fdo#110222]

  * igt@kms_busy@extended-modeset-hang-newfb-render-b:
    - shard-hsw:          PASS -> DMESG-WARN [fdo#110222] +3
    - shard-kbl:          PASS -> DMESG-WARN [fdo#110222] +2

  * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +73

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          PASS -> FAIL [fdo#105363]

  * igt@kms_flip@flip-vs-suspend:
    - shard-snb:          NOTRUN -> INCOMPLETE [fdo#105411]

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-blt:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +9

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_plane_scaling@pipe-a-scaler-with-rotation:
    - shard-glk:          PASS -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-kbl:          PASS -> FAIL [fdo#109016]

  * igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2

  * igt@kms_vblank@pipe-c-ts-continuation-idle:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4

  * igt@kms_vblank@pipe-c-ts-continuation-modeset:
    - shard-kbl:          PASS -> FAIL [fdo#104894]
    - shard-apl:          PASS -> FAIL [fdo#104894]

  * igt@prime_nv_test@nv_write_i915_cpu_mmap_read:
    - shard-hsw:          NOTRUN -> SKIP [fdo#109271] +1

  
#### Possible fixes ####

  * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
    - shard-apl:          FAIL [fdo#109660] -> PASS
    - shard-kbl:          FAIL [fdo#109660] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
    - shard-snb:          DMESG-WARN [fdo#110222] -> PASS

  * igt@kms_cursor_crc@cursor-256x256-random:
    - shard-hsw:          INCOMPLETE [fdo#103540] -> PASS

  * igt@kms_cursor_crc@cursor-64x64-onscreen:
    - shard-glk:          FAIL [fdo#103232] -> PASS

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
    - shard-hsw:          FAIL [fdo#105767] -> PASS

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS

  * igt@kms_setmode@basic:
    - shard-kbl:          FAIL [fdo#99912] -> PASS

  * igt@kms_vblank@pipe-b-ts-continuation-modeset:
    - shard-apl:          FAIL [fdo#104894] -> PASS +1

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-kbl:          FAIL [fdo#104894] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
  [fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 5)
------------------------------

  Missing    (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u 


Build changes
-------------

    * IGT: IGT_4899 -> IGTPW_2692
    * Piglit: piglit_4509 -> None

  CI_DRM_5796: 2165d3631bdb91a7b80110b1f76633a19666d0f6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2692: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2692/
  IGT_4899: ba96339c238180b38d05d7fa2dca772d49eee332 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2692/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed
  2019-03-22 20:33 ` [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Souza, Jose
@ 2019-03-25 18:17   ` Dhinakaran Pandiyan
  0 siblings, 0 replies; 6+ messages in thread
From: Dhinakaran Pandiyan @ 2019-03-25 18:17 UTC (permalink / raw)
  To: Souza, Jose, igt-dev

On Fri, 2019-03-22 at 13:33 -0700, Souza, Jose wrote:
> On Thu, 2019-03-21 at 16:18 -0700, Dhinakaran Pandiyan wrote:
> > The test leaves the debugfs flag enabled if the driver failed to
> > enable
> > DSC. And is it turns out, the feature gets enabled only after the
> > test
> > completes and consequently affects PSR2 tests that follow. Let's make
> > sure
> > the test cleans up correctly, even if the DSC test itself needs to be
> > fixed.
> > 
> > Also included some formatting fixes within the function.
> 
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

Pushed, thanks!

-DK

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-25 18:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 23:18 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Dhinakaran Pandiyan
2019-03-21 23:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-22 19:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2) Patchwork
2019-03-22 20:33 ` [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Disable DSC even if enabling failed Souza, Jose
2019-03-25 18:17   ` Dhinakaran Pandiyan
2019-03-23 18:25 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_dp_dsc: Disable DSC even if enabling failed (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.