All of lore.kernel.org
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com,
	linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kselftest@vger.kernel.org, Jon Mason <jdmason@kudzu.us>,
	Joerg Roedel <joro@8bytes.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Allen Hubbe <allenbh@gmail.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	Eric Pilmore <epilmore@gigaio.com>,
	Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH v3 02/10] PCI/switchtec: Add module parameter to request more interrupts
Date: Thu, 21 Mar 2019 18:06:37 -0600	[thread overview]
Message-ID: <20190322000645.15580-3-logang@deltatee.com> (raw)
In-Reply-To: <20190322000645.15580-1-logang@deltatee.com>

Seeing the we want to use more interrupts in the NTB MSI code
we need to be able allocate more (sometimes virtual) interrupts
in the switchtec driver. Therefore add a module parameter to
request to allocate additional interrupts.

This puts virtually no limit on the number of MSI interrupts available
to NTB clients.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/switch/switchtec.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index e22766c79fe9..8b1db78197d9 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -30,6 +30,10 @@ module_param(use_dma_mrpc, bool, 0644);
 MODULE_PARM_DESC(use_dma_mrpc,
 		 "Enable the use of the DMA MRPC feature");
 
+static int nirqs = 32;
+module_param(nirqs, int, 0644);
+MODULE_PARM_DESC(nirqs, "number of interrupts to allocate (more may be useful for NTB applications)");
+
 static dev_t switchtec_devt;
 static DEFINE_IDA(switchtec_minor_ida);
 
@@ -1247,8 +1251,12 @@ static int switchtec_init_isr(struct switchtec_dev *stdev)
 	int dma_mrpc_irq;
 	int rc;
 
-	nvecs = pci_alloc_irq_vectors(stdev->pdev, 1, 4,
-				      PCI_IRQ_MSIX | PCI_IRQ_MSI);
+	if (nirqs < 4)
+		nirqs = 4;
+
+	nvecs = pci_alloc_irq_vectors(stdev->pdev, 1, nirqs,
+				      PCI_IRQ_MSIX | PCI_IRQ_MSI |
+				      PCI_IRQ_VIRTUAL);
 	if (nvecs < 0)
 		return nvecs;
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: logang at deltatee.com (Logan Gunthorpe)
Subject: [PATCH v3 02/10] PCI/switchtec: Add module parameter to request more interrupts
Date: Thu, 21 Mar 2019 18:06:37 -0600	[thread overview]
Message-ID: <20190322000645.15580-3-logang@deltatee.com> (raw)
In-Reply-To: <20190322000645.15580-1-logang@deltatee.com>

Seeing the we want to use more interrupts in the NTB MSI code
we need to be able allocate more (sometimes virtual) interrupts
in the switchtec driver. Therefore add a module parameter to
request to allocate additional interrupts.

This puts virtually no limit on the number of MSI interrupts available
to NTB clients.

Signed-off-by: Logan Gunthorpe <logang at deltatee.com>
Cc: Bjorn Helgaas <bhelgaas at google.com>
---
 drivers/pci/switch/switchtec.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index e22766c79fe9..8b1db78197d9 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -30,6 +30,10 @@ module_param(use_dma_mrpc, bool, 0644);
 MODULE_PARM_DESC(use_dma_mrpc,
 		 "Enable the use of the DMA MRPC feature");
 
+static int nirqs = 32;
+module_param(nirqs, int, 0644);
+MODULE_PARM_DESC(nirqs, "number of interrupts to allocate (more may be useful for NTB applications)");
+
 static dev_t switchtec_devt;
 static DEFINE_IDA(switchtec_minor_ida);
 
@@ -1247,8 +1251,12 @@ static int switchtec_init_isr(struct switchtec_dev *stdev)
 	int dma_mrpc_irq;
 	int rc;
 
-	nvecs = pci_alloc_irq_vectors(stdev->pdev, 1, 4,
-				      PCI_IRQ_MSIX | PCI_IRQ_MSI);
+	if (nirqs < 4)
+		nirqs = 4;
+
+	nvecs = pci_alloc_irq_vectors(stdev->pdev, 1, nirqs,
+				      PCI_IRQ_MSIX | PCI_IRQ_MSI |
+				      PCI_IRQ_VIRTUAL);
 	if (nvecs < 0)
 		return nvecs;
 
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: logang@deltatee.com (Logan Gunthorpe)
Subject: [PATCH v3 02/10] PCI/switchtec: Add module parameter to request more interrupts
Date: Thu, 21 Mar 2019 18:06:37 -0600	[thread overview]
Message-ID: <20190322000645.15580-3-logang@deltatee.com> (raw)
Message-ID: <20190322000637.MFTKAc_sLvGC0yd0xogYFGMlLwl1Y68WGf_IAr3xw74@z> (raw)
In-Reply-To: <20190322000645.15580-1-logang@deltatee.com>

Seeing the we want to use more interrupts in the NTB MSI code
we need to be able allocate more (sometimes virtual) interrupts
in the switchtec driver. Therefore add a module parameter to
request to allocate additional interrupts.

This puts virtually no limit on the number of MSI interrupts available
to NTB clients.

Signed-off-by: Logan Gunthorpe <logang at deltatee.com>
Cc: Bjorn Helgaas <bhelgaas at google.com>
---
 drivers/pci/switch/switchtec.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index e22766c79fe9..8b1db78197d9 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -30,6 +30,10 @@ module_param(use_dma_mrpc, bool, 0644);
 MODULE_PARM_DESC(use_dma_mrpc,
 		 "Enable the use of the DMA MRPC feature");
 
+static int nirqs = 32;
+module_param(nirqs, int, 0644);
+MODULE_PARM_DESC(nirqs, "number of interrupts to allocate (more may be useful for NTB applications)");
+
 static dev_t switchtec_devt;
 static DEFINE_IDA(switchtec_minor_ida);
 
@@ -1247,8 +1251,12 @@ static int switchtec_init_isr(struct switchtec_dev *stdev)
 	int dma_mrpc_irq;
 	int rc;
 
-	nvecs = pci_alloc_irq_vectors(stdev->pdev, 1, 4,
-				      PCI_IRQ_MSIX | PCI_IRQ_MSI);
+	if (nirqs < 4)
+		nirqs = 4;
+
+	nvecs = pci_alloc_irq_vectors(stdev->pdev, 1, nirqs,
+				      PCI_IRQ_MSIX | PCI_IRQ_MSI |
+				      PCI_IRQ_VIRTUAL);
 	if (nvecs < 0)
 		return nvecs;
 
-- 
2.20.1

  parent reply	other threads:[~2019-03-22  0:06 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22  0:06 [PATCH v3 00/10] Support using MSI interrupts in ntb_transport Logan Gunthorpe
2019-03-22  0:06 ` Logan Gunthorpe
2019-03-22  0:06 ` logang
2019-03-22  0:06 ` [PATCH v3 01/10] PCI/MSI: Support allocating virtual MSI interrupts Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22  0:06 ` Logan Gunthorpe [this message]
2019-03-22  0:06   ` [PATCH v3 02/10] PCI/switchtec: Add module parameter to request more interrupts Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22  0:06 ` [PATCH v3 03/10] NTB: Introduce helper functions to calculate logical port number Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22 16:51   ` Bjorn Helgaas
2019-03-22 16:51     ` Bjorn Helgaas
2019-03-22 16:51     ` helgaas
2019-03-22  0:06 ` [PATCH v3 04/10] NTB: Introduce functions to calculate multi-port resource index Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22  0:06 ` [PATCH v3 05/10] NTB: Rename ntb.c to support multiple source files in the module Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22  0:06 ` [PATCH v3 06/10] NTB: Introduce MSI library Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22  0:06 ` [PATCH v3 07/10] NTB: Introduce NTB MSI Test Client Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22  0:06 ` [PATCH v3 08/10] NTB: Add ntb_msi_test support to ntb_test Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22  0:06 ` [PATCH v3 09/10] NTB: Add MSI interrupt support to ntb_transport Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang
2019-03-22 16:47   ` Bjorn Helgaas
2019-03-22 16:47     ` Bjorn Helgaas
2019-03-22 16:47     ` helgaas
2019-03-25 19:08     ` Logan Gunthorpe
2019-03-25 19:08       ` Logan Gunthorpe
2019-03-25 19:08       ` Logan Gunthorpe
2019-03-25 19:08       ` logang
2019-03-22  0:06 ` [PATCH v3 10/10] NTB: Describe the ntb_msi_test client in the documentation Logan Gunthorpe
2019-03-22  0:06   ` Logan Gunthorpe
2019-03-22  0:06   ` logang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322000645.15580-3-logang@deltatee.com \
    --to=logang@deltatee.com \
    --cc=allenbh@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=dave.jiang@intel.com \
    --cc=epilmore@gigaio.com \
    --cc=fancer.lancer@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jdmason@kudzu.us \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.