From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Stanislav Fomichev <sdf@fomichev.me>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Stanislav Fomichev <sdf@google.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection
Date: Fri, 22 Mar 2019 11:46:52 +0900 [thread overview]
Message-ID: <20190322024652.GA3679@jagdpanzerIV> (raw)
In-Reply-To: <20190321154928.GT7431@mini-arch.hsd1.ca.comcast.net>
On (03/21/19 08:49), Stanislav Fomichev wrote:
> On 03/21, Sergey Senozhatsky wrote:
> > On (03/20/19 20:24), Alexei Starovoitov wrote:
> > > On Wed, Mar 20, 2019 at 09:53:33PM +0900, Sergey Senozhatsky wrote:
> > > > Not all compilers have __builtin_bswap16() and __builtin_bswap32(),
> > > > thus not all compilers are able to compile the following code:
> > > >
> > > > (__builtin_constant_p(x) ? \
> > > > ___constant_swab16(x) : __builtin_bswap16(x))
> > > >
> > > > That's the reason why bpf_ntohl() doesn't work on GCC < 4.8, for
> > > > instance:
> > >
> > > nack to fixes to support such old compilers.
> >
> > Fair enough.
> What is too old? Documentation/process/changes.rst says that minimum
> supported gcc is 4.6, do we lift that requirement for the tests?
Hmm, good point, Stanislav. I thought it was gcc 4.9 which introduced
asm goto and hence 4.9 is the minimum supported version. But it seems
that it was 4.5/4.6, so the min supported gcc version is 4.6. Which
means that those bpf defines won't work on some compilers.
Alexei, does your NACK still stand?
-ss
WARNING: multiple messages have this Message-ID (diff)
From: sergey.senozhatsky.work at gmail.com (Sergey Senozhatsky)
Subject: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection
Date: Fri, 22 Mar 2019 11:46:52 +0900 [thread overview]
Message-ID: <20190322024652.GA3679@jagdpanzerIV> (raw)
In-Reply-To: <20190321154928.GT7431@mini-arch.hsd1.ca.comcast.net>
On (03/21/19 08:49), Stanislav Fomichev wrote:
> On 03/21, Sergey Senozhatsky wrote:
> > On (03/20/19 20:24), Alexei Starovoitov wrote:
> > > On Wed, Mar 20, 2019 at 09:53:33PM +0900, Sergey Senozhatsky wrote:
> > > > Not all compilers have __builtin_bswap16() and __builtin_bswap32(),
> > > > thus not all compilers are able to compile the following code:
> > > >
> > > > (__builtin_constant_p(x) ? \
> > > > ___constant_swab16(x) : __builtin_bswap16(x))
> > > >
> > > > That's the reason why bpf_ntohl() doesn't work on GCC < 4.8, for
> > > > instance:
> > >
> > > nack to fixes to support such old compilers.
> >
> > Fair enough.
> What is too old? Documentation/process/changes.rst says that minimum
> supported gcc is 4.6, do we lift that requirement for the tests?
Hmm, good point, Stanislav. I thought it was gcc 4.9 which introduced
asm goto and hence 4.9 is the minimum supported version. But it seems
that it was 4.5/4.6, so the min supported gcc version is 4.6. Which
means that those bpf defines won't work on some compilers.
Alexei, does your NACK still stand?
-ss
WARNING: multiple messages have this Message-ID (diff)
From: sergey.senozhatsky.work@gmail.com (Sergey Senozhatsky)
Subject: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection
Date: Fri, 22 Mar 2019 11:46:52 +0900 [thread overview]
Message-ID: <20190322024652.GA3679@jagdpanzerIV> (raw)
Message-ID: <20190322024652.sLOTM5ELtxurv1CkHFXtVlXDI7FTjMMKmqASzC4l4Sc@z> (raw)
In-Reply-To: <20190321154928.GT7431@mini-arch.hsd1.ca.comcast.net>
On (03/21/19 08:49), Stanislav Fomichev wrote:
> On 03/21, Sergey Senozhatsky wrote:
> > On (03/20/19 20:24), Alexei Starovoitov wrote:
> > > On Wed, Mar 20, 2019@09:53:33PM +0900, Sergey Senozhatsky wrote:
> > > > Not all compilers have __builtin_bswap16() and __builtin_bswap32(),
> > > > thus not all compilers are able to compile the following code:
> > > >
> > > > (__builtin_constant_p(x) ? \
> > > > ___constant_swab16(x) : __builtin_bswap16(x))
> > > >
> > > > That's the reason why bpf_ntohl() doesn't work on GCC < 4.8, for
> > > > instance:
> > >
> > > nack to fixes to support such old compilers.
> >
> > Fair enough.
> What is too old? Documentation/process/changes.rst says that minimum
> supported gcc is 4.6, do we lift that requirement for the tests?
Hmm, good point, Stanislav. I thought it was gcc 4.9 which introduced
asm goto and hence 4.9 is the minimum supported version. But it seems
that it was 4.5/4.6, so the min supported gcc version is 4.6. Which
means that those bpf defines won't work on some compilers.
Alexei, does your NACK still stand?
-ss
next prev parent reply other threads:[~2019-03-22 2:46 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 12:53 [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection Sergey Senozhatsky
2019-03-20 12:53 ` Sergey Senozhatsky
2019-03-20 12:53 ` sergey.senozhatsky
2019-03-20 12:53 ` [PATCHv2 bpf-next 2/3] bpf, tests: drop unused __bpf_constant_foo defines Sergey Senozhatsky
2019-03-20 12:53 ` Sergey Senozhatsky
2019-03-20 12:53 ` sergey.senozhatsky
2019-03-20 12:56 ` Sergey Senozhatsky
2019-03-20 12:56 ` Sergey Senozhatsky
2019-03-20 12:56 ` sergey.senozhatsky
2019-03-20 12:53 ` [PATCHv2 bpf-next 3/3] bpf, tests: don't use __bpf_constant_htons() Sergey Senozhatsky
2019-03-20 12:53 ` Sergey Senozhatsky
2019-03-20 12:53 ` sergey.senozhatsky
2019-03-20 12:55 ` Sergey Senozhatsky
2019-03-20 12:55 ` Sergey Senozhatsky
2019-03-20 12:55 ` sergey.senozhatsky
2019-03-20 17:13 ` [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection Stanislav Fomichev
2019-03-20 17:13 ` Stanislav Fomichev
2019-03-20 17:13 ` sdf
2019-03-20 22:20 ` Yonghong Song
2019-03-20 22:20 ` Yonghong Song
2019-03-20 22:20 ` yhs
2019-03-20 22:27 ` Stanislav Fomichev
2019-03-20 22:27 ` Stanislav Fomichev
2019-03-20 22:27 ` sdf
2019-03-20 22:45 ` Yonghong Song
2019-03-20 22:45 ` Yonghong Song
2019-03-20 22:45 ` yhs
2019-03-20 23:08 ` Daniel Borkmann
2019-03-20 23:08 ` Daniel Borkmann
2019-03-20 23:08 ` daniel
2019-03-21 0:03 ` Stanislav Fomichev
2019-03-21 0:03 ` Stanislav Fomichev
2019-03-21 0:03 ` sdf
2019-03-21 0:23 ` Yonghong Song
2019-03-21 0:23 ` Yonghong Song
2019-03-21 0:23 ` yhs
2019-03-21 0:34 ` Sergey Senozhatsky
2019-03-21 0:34 ` Sergey Senozhatsky
2019-03-21 0:34 ` sergey.senozhatsky.work
2019-03-21 0:22 ` Sergey Senozhatsky
2019-03-21 0:22 ` Sergey Senozhatsky
2019-03-21 0:22 ` sergey.senozhatsky.work
2019-03-21 3:24 ` Alexei Starovoitov
2019-03-21 3:24 ` Alexei Starovoitov
2019-03-21 3:24 ` alexei.starovoitov
2019-03-21 5:08 ` Sergey Senozhatsky
2019-03-21 5:08 ` Sergey Senozhatsky
2019-03-21 5:08 ` sergey.senozhatsky.work
2019-03-21 15:49 ` Stanislav Fomichev
2019-03-21 15:49 ` Stanislav Fomichev
2019-03-21 15:49 ` sdf
2019-03-22 2:46 ` Sergey Senozhatsky [this message]
2019-03-22 2:46 ` Sergey Senozhatsky
2019-03-22 2:46 ` sergey.senozhatsky.work
2019-03-22 3:12 ` Alexei Starovoitov
2019-03-22 3:12 ` Alexei Starovoitov
2019-03-22 3:12 ` alexei.starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322024652.GA3679@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=sdf@google.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.