* [PATCH net-next] tcp: add documentation for tcp_ca_state
@ 2019-03-22 14:59 Soheil Hassas Yeganeh
2019-03-22 15:03 ` Sowmini Varadhan
2019-03-24 1:50 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Soheil Hassas Yeganeh @ 2019-03-22 14:59 UTC (permalink / raw)
To: davem, netdev
Cc: edumazet, ycheng, ncardwell, Soheil Hassas Yeganeh, Sowmini Varadhan
From: Soheil Hassas Yeganeh <soheil@google.com>
Add documentation to the tcp_ca_state enum, since this enum is
exposed in uapi.
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Cc: Sowmini Varadhan <sowmini05@gmail.com>
---
include/uapi/linux/tcp.h | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h
index 8bb6cc5f3235..b521464ea962 100644
--- a/include/uapi/linux/tcp.h
+++ b/include/uapi/linux/tcp.h
@@ -160,15 +160,42 @@ enum {
#define TCPI_OPT_ECN_SEEN 16 /* we received at least one packet with ECT */
#define TCPI_OPT_SYN_DATA 32 /* SYN-ACK acked data in SYN sent or rcvd */
+/*
+ * Sender's congestion state indicating normal or abnormal situations
+ * in the last round of packets sent. The state is driven by the ACK
+ * information and timer events.
+ */
enum tcp_ca_state {
+ /*
+ * Nothing bad has been observed recently.
+ * No apparent reordering, packet loss, or ECN marks.
+ */
TCP_CA_Open = 0,
#define TCPF_CA_Open (1<<TCP_CA_Open)
+ /*
+ * The sender enters disordered state when it has received DUPACKs or
+ * SACKs in the last round of packets sent. This could be due to packet
+ * loss or reordering but needs further information to confirm packets
+ * have been lost.
+ */
TCP_CA_Disorder = 1,
#define TCPF_CA_Disorder (1<<TCP_CA_Disorder)
+ /*
+ * The sender enters Congestion Window Reduction (CWR) state when it
+ * has received ACKs with ECN-ECE marks, or has experienced congestion
+ * or packet discard on the sender host (e.g. qdisc).
+ */
TCP_CA_CWR = 2,
#define TCPF_CA_CWR (1<<TCP_CA_CWR)
+ /*
+ * The sender is in fast recovery and retransmitting lost packets,
+ * typically triggered by ACK events.
+ */
TCP_CA_Recovery = 3,
#define TCPF_CA_Recovery (1<<TCP_CA_Recovery)
+ /*
+ * The sender is in loss recovery triggered by retransmission timeout.
+ */
TCP_CA_Loss = 4
#define TCPF_CA_Loss (1<<TCP_CA_Loss)
};
--
2.21.0.392.gf8f6787159e-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] tcp: add documentation for tcp_ca_state
2019-03-22 14:59 [PATCH net-next] tcp: add documentation for tcp_ca_state Soheil Hassas Yeganeh
@ 2019-03-22 15:03 ` Sowmini Varadhan
2019-03-24 1:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sowmini Varadhan @ 2019-03-22 15:03 UTC (permalink / raw)
To: Soheil Hassas Yeganeh
Cc: davem, netdev, edumazet, ycheng, ncardwell, Soheil Hassas Yeganeh
On (03/22/19 10:59), Soheil Hassas Yeganeh wrote:
>
> Add documentation to the tcp_ca_state enum, since this enum is
> exposed in uapi.
Acked-by: Sowmini Varadhan <sowmini05@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] tcp: add documentation for tcp_ca_state
2019-03-22 14:59 [PATCH net-next] tcp: add documentation for tcp_ca_state Soheil Hassas Yeganeh
2019-03-22 15:03 ` Sowmini Varadhan
@ 2019-03-24 1:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-03-24 1:50 UTC (permalink / raw)
To: soheil.kdev; +Cc: netdev, edumazet, ycheng, ncardwell, soheil, sowmini05
From: Soheil Hassas Yeganeh <soheil.kdev@gmail.com>
Date: Fri, 22 Mar 2019 10:59:47 -0400
> From: Soheil Hassas Yeganeh <soheil@google.com>
>
> Add documentation to the tcp_ca_state enum, since this enum is
> exposed in uapi.
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
> Cc: Sowmini Varadhan <sowmini05@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-24 1:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 14:59 [PATCH net-next] tcp: add documentation for tcp_ca_state Soheil Hassas Yeganeh
2019-03-22 15:03 ` Sowmini Varadhan
2019-03-24 1:50 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.