* [PATCH lttng-tools v3 1/8] Fix: lttng_poll_mod calls compat_(e)poll_add
@ 2019-03-22 18:19 Yannick Lamarre
0 siblings, 0 replies; 2+ messages in thread
From: Yannick Lamarre @ 2019-03-22 18:19 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
lttng_poll_mod should call compat_(e)poll_mod.
Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
---
src/common/compat/poll.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/common/compat/poll.h b/src/common/compat/poll.h
index d4bd87f5..fde54ddb 100644
--- a/src/common/compat/poll.h
+++ b/src/common/compat/poll.h
@@ -177,7 +177,7 @@ extern int compat_epoll_del(struct lttng_poll_event *events, int fd);
extern int compat_epoll_mod(struct lttng_poll_event *events,
int fd, uint32_t req_events);
#define lttng_poll_mod(events, fd, req_events) \
- compat_epoll_add(events, fd, req_events)
+ compat_epoll_mod(events, fd, req_events)
/*
* Set up the poll set limits variable poll_max_size
@@ -361,7 +361,7 @@ extern int compat_poll_del(struct lttng_poll_event *events, int fd);
extern int compat_poll_mod(struct lttng_poll_event *events,
int fd, uint32_t req_events);
#define lttng_poll_mod(events, fd, req_events) \
- compat_poll_add(events, fd, req_events)
+ compat_poll_mod(events, fd, req_events)
/*
* Set up the poll set limits variable poll_max_size
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH lttng-tools v3 1/8] Fix: lttng_poll_mod calls compat_(e)poll_add
[not found] <20190322181928.6186-1-ylamarre@efficios.com>
@ 2019-03-22 18:50 ` Jonathan Rajotte-Julien
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Rajotte-Julien @ 2019-03-22 18:50 UTC (permalink / raw)
To: Yannick Lamarre; +Cc: lttng-dev, jgalar
Hi,
I do not see any information regarding what changed between each versions.
Next time, please add a "high level" delta of the change between vN and vN+1.
This also act as a check list to see if previous comments were addressed. It
should ease the review process.
On Fri, Mar 22, 2019 at 02:19:21PM -0400, Yannick Lamarre wrote:
> lttng_poll_mod should call compat_(e)poll_mod.
>
> Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
> ---
As mentioned in person, the "high level" delta can be added here as long as you
are before the diff start. [1]
[1] https://stackoverflow.com/questions/18979120/is-it-possible-to-add-a-comment-to-a-diff-file-unified
Normally you can simply add a "---" and compose the message between the "---".
> src/common/compat/poll.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/common/compat/poll.h b/src/common/compat/poll.h
> index d4bd87f5..fde54ddb 100644
> --- a/src/common/compat/poll.h
> +++ b/src/common/compat/poll.h
> @@ -177,7 +177,7 @@ extern int compat_epoll_del(struct lttng_poll_event *events, int fd);
> extern int compat_epoll_mod(struct lttng_poll_event *events,
> int fd, uint32_t req_events);
> #define lttng_poll_mod(events, fd, req_events) \
> - compat_epoll_add(events, fd, req_events)
> + compat_epoll_mod(events, fd, req_events)
>
> /*
> * Set up the poll set limits variable poll_max_size
> @@ -361,7 +361,7 @@ extern int compat_poll_del(struct lttng_poll_event *events, int fd);
> extern int compat_poll_mod(struct lttng_poll_event *events,
> int fd, uint32_t req_events);
> #define lttng_poll_mod(events, fd, req_events) \
> - compat_poll_add(events, fd, req_events)
> + compat_poll_mod(events, fd, req_events)
>
> /*
> * Set up the poll set limits variable poll_max_size
> --
> 2.11.0
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Jonathan Rajotte-Julien
EfficiOS
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-22 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 18:19 [PATCH lttng-tools v3 1/8] Fix: lttng_poll_mod calls compat_(e)poll_add Yannick Lamarre
[not found] <20190322181928.6186-1-ylamarre@efficios.com>
2019-03-22 18:50 ` Jonathan Rajotte-Julien
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.