* usb: core: Add PM runtime calls to usb_hcd_platform_shutdown
@ 2019-03-22 21:54 Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2019-03-22 21:54 UTC (permalink / raw)
To: Alan Stern; +Cc: Greg Kroah-Hartman, linux-usb, linux-omap
If ohci-platform is runtime suspended, we can currently get an "imprecise
external abort" on reboot with ohci-platform loaded when PM runtime
is implemented for the SoC.
Let's fix this by adding PM runtime support to usb_hcd_platform_shutdown.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/usb/core/hcd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -3017,6 +3017,9 @@ usb_hcd_platform_shutdown(struct platform_device *dev)
{
struct usb_hcd *hcd = platform_get_drvdata(dev);
+ /* No need for pm_runtime_put(), we're shutting down */
+ pm_runtime_get_sync(&dev->dev);
+
if (hcd->driver->shutdown)
hcd->driver->shutdown(hcd);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* usb: core: Add PM runtime calls to usb_hcd_platform_shutdown
@ 2019-03-23 15:22 Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2019-03-23 15:22 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Greg Kroah-Hartman, linux-usb, linux-omap
On Fri, 22 Mar 2019, Tony Lindgren wrote:
> If ohci-platform is runtime suspended, we can currently get an "imprecise
> external abort" on reboot with ohci-platform loaded when PM runtime
> is implemented for the SoC.
>
> Let's fix this by adding PM runtime support to usb_hcd_platform_shutdown.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/usb/core/hcd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -3017,6 +3017,9 @@ usb_hcd_platform_shutdown(struct platform_device *dev)
> {
> struct usb_hcd *hcd = platform_get_drvdata(dev);
>
> + /* No need for pm_runtime_put(), we're shutting down */
> + pm_runtime_get_sync(&dev->dev);
> +
> if (hcd->driver->shutdown)
> hcd->driver->shutdown(hcd);
> }
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-23 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 21:54 usb: core: Add PM runtime calls to usb_hcd_platform_shutdown Tony Lindgren
2019-03-23 15:22 Alan Stern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.