* [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation
@ 2019-03-19 20:19 ` Janusz Krzysztofik
0 siblings, 0 replies; 6+ messages in thread
From: Janusz Krzysztofik @ 2019-03-19 20:19 UTC (permalink / raw)
To: Tony Lindgren
Cc: Aaro Koskinen, linux-omap, linux-arm-kernel, linux-kernel,
Janusz Krzysztofik, stable
In order to request dynamic allocationn of GPIO IDs, a negative number
should be passed as a base GPIO ID via platform data. Unfortuntely,
commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
GPIO numbers") didn't follow that rule while switching to dynamically
allocated GPIO IDs for Amstrad Delta latches, making their IDs
overlapping with those already assigned to OMAP GPIO devices. Fix it.
Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: stable@vger.kernel.org
---
arch/arm/mach-omap1/board-ams-delta.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index be30c3c061b4..1b15d593837e 100644
--- a/arch/arm/mach-omap1/board-ams-delta.c
+++ b/arch/arm/mach-omap1/board-ams-delta.c
@@ -182,6 +182,7 @@ static struct resource latch1_resources[] = {
static struct bgpio_pdata latch1_pdata = {
.label = LATCH1_LABEL,
+ .base = -1,
.ngpio = LATCH1_NGPIO,
};
@@ -219,6 +220,7 @@ static struct resource latch2_resources[] = {
static struct bgpio_pdata latch2_pdata = {
.label = LATCH2_LABEL,
+ .base = -1,
.ngpio = LATCH2_NGPIO,
};
--
2.19.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation
@ 2019-03-19 20:19 ` Janusz Krzysztofik
0 siblings, 0 replies; 6+ messages in thread
From: Janusz Krzysztofik @ 2019-03-19 20:19 UTC (permalink / raw)
To: Tony Lindgren
Cc: Aaro Koskinen, Janusz Krzysztofik, linux-kernel, stable,
linux-omap, linux-arm-kernel
In order to request dynamic allocationn of GPIO IDs, a negative number
should be passed as a base GPIO ID via platform data. Unfortuntely,
commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
GPIO numbers") didn't follow that rule while switching to dynamically
allocated GPIO IDs for Amstrad Delta latches, making their IDs
overlapping with those already assigned to OMAP GPIO devices. Fix it.
Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: stable@vger.kernel.org
---
arch/arm/mach-omap1/board-ams-delta.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index be30c3c061b4..1b15d593837e 100644
--- a/arch/arm/mach-omap1/board-ams-delta.c
+++ b/arch/arm/mach-omap1/board-ams-delta.c
@@ -182,6 +182,7 @@ static struct resource latch1_resources[] = {
static struct bgpio_pdata latch1_pdata = {
.label = LATCH1_LABEL,
+ .base = -1,
.ngpio = LATCH1_NGPIO,
};
@@ -219,6 +220,7 @@ static struct resource latch2_resources[] = {
static struct bgpio_pdata latch2_pdata = {
.label = LATCH2_LABEL,
+ .base = -1,
.ngpio = LATCH2_NGPIO,
};
--
2.19.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation
2019-03-19 20:19 ` Janusz Krzysztofik
@ 2019-03-20 1:01 ` Aaro Koskinen
-1 siblings, 0 replies; 6+ messages in thread
From: Aaro Koskinen @ 2019-03-20 1:01 UTC (permalink / raw)
To: Janusz Krzysztofik
Cc: Tony Lindgren, linux-omap, linux-arm-kernel, linux-kernel, stable
On Tue, Mar 19, 2019 at 09:19:52PM +0100, Janusz Krzysztofik wrote:
> In order to request dynamic allocationn of GPIO IDs, a negative number
> should be passed as a base GPIO ID via platform data. Unfortuntely,
> commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
> GPIO numbers") didn't follow that rule while switching to dynamically
> allocated GPIO IDs for Amstrad Delta latches, making their IDs
> overlapping with those already assigned to OMAP GPIO devices. Fix it.
>
> Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> Cc: stable@vger.kernel.org
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation
@ 2019-03-20 1:01 ` Aaro Koskinen
0 siblings, 0 replies; 6+ messages in thread
From: Aaro Koskinen @ 2019-03-20 1:01 UTC (permalink / raw)
To: Janusz Krzysztofik
Cc: Tony Lindgren, stable, linux-omap, linux-kernel, linux-arm-kernel
On Tue, Mar 19, 2019 at 09:19:52PM +0100, Janusz Krzysztofik wrote:
> In order to request dynamic allocationn of GPIO IDs, a negative number
> should be passed as a base GPIO ID via platform data. Unfortuntely,
> commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
> GPIO numbers") didn't follow that rule while switching to dynamically
> allocated GPIO IDs for Amstrad Delta latches, making their IDs
> overlapping with those already assigned to OMAP GPIO devices. Fix it.
>
> Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> Cc: stable@vger.kernel.org
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation
2019-03-20 1:01 ` Aaro Koskinen
@ 2019-03-22 22:21 ` Tony Lindgren
-1 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2019-03-22 22:21 UTC (permalink / raw)
To: Aaro Koskinen
Cc: Janusz Krzysztofik, linux-omap, linux-arm-kernel, linux-kernel, stable
* Aaro Koskinen <aaro.koskinen@iki.fi> [190320 01:02]:
> On Tue, Mar 19, 2019 at 09:19:52PM +0100, Janusz Krzysztofik wrote:
> > In order to request dynamic allocationn of GPIO IDs, a negative number
> > should be passed as a base GPIO ID via platform data. Unfortuntely,
> > commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
> > GPIO numbers") didn't follow that rule while switching to dynamically
> > allocated GPIO IDs for Amstrad Delta latches, making their IDs
> > overlapping with those already assigned to OMAP GPIO devices. Fix it.
> >
> > Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
> > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> > Cc: stable@vger.kernel.org
>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Applying into omap-for-v5.1/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation
@ 2019-03-22 22:21 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2019-03-22 22:21 UTC (permalink / raw)
To: Aaro Koskinen
Cc: stable, linux-omap, Janusz Krzysztofik, linux-kernel, linux-arm-kernel
* Aaro Koskinen <aaro.koskinen@iki.fi> [190320 01:02]:
> On Tue, Mar 19, 2019 at 09:19:52PM +0100, Janusz Krzysztofik wrote:
> > In order to request dynamic allocationn of GPIO IDs, a negative number
> > should be passed as a base GPIO ID via platform data. Unfortuntely,
> > commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global
> > GPIO numbers") didn't follow that rule while switching to dynamically
> > allocated GPIO IDs for Amstrad Delta latches, making their IDs
> > overlapping with those already assigned to OMAP GPIO devices. Fix it.
> >
> > Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers")
> > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> > Cc: stable@vger.kernel.org
>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Applying into omap-for-v5.1/fixes thanks.
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-22 22:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 20:19 [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation Janusz Krzysztofik
2019-03-19 20:19 ` Janusz Krzysztofik
2019-03-20 1:01 ` Aaro Koskinen
2019-03-20 1:01 ` Aaro Koskinen
2019-03-22 22:21 ` Tony Lindgren
2019-03-22 22:21 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.