[PATCH resend] staging: pi433: break line after comparison operator to fix checkpatch warning

[PATCH resend] staging: pi433: break line after comparison operator to fix checkpatch warning

[Jules Irenge]

 Break line after comparison operator to solve checkpatch.pl warning:
"WARNING: line over 80 characters".

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/staging/pi433/pi433_if.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index b2314636dc89..f537722395c6 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -479,7 +479,8 @@ pi433_receive(void *data)
 	/* length byte enabled? */
 	if (dev->rx_cfg.enable_length_byte == OPTION_ON) {
 		retval = wait_event_interruptible(dev->fifo_wait_queue,
-						  dev->free_in_fifo < FIFO_SIZE);
+						  dev->free_in_fifo <
+						  FIFO_SIZE);
 		if (retval) /* wait was interrupted */
 			goto abort;
 
@@ -500,7 +501,8 @@ pi433_receive(void *data)
 		bytes_total--;
 
 		retval = wait_event_interruptible(dev->fifo_wait_queue,
-						  dev->free_in_fifo < FIFO_SIZE);
+						  dev->free_in_fifo <
+						  FIFO_SIZE);
 		if (retval) /* wait was interrupted */
 			goto abort;
 
@@ -513,7 +515,8 @@ pi433_receive(void *data)
 	while (dev->rx_position < bytes_total) {
 		if (!rf69_get_flag(dev->spi, payload_ready)) {
 			retval = wait_event_interruptible(dev->fifo_wait_queue,
-							  dev->free_in_fifo < FIFO_SIZE);
+							  dev->free_in_fifo <
+							  FIFO_SIZE);
 			if (retval) /* wait was interrupted */
 				goto abort;
 		}
-- 
2.20.1

Re: [Outreachy kernel] [PATCH resend] staging: pi433: break line after comparison operator to fix checkpatch warning

[Julia Lawall]

On Sat, 23 Mar 2019, Jules Irenge wrote:

>  Break line after comparison operator to solve checkpatch.pl warning:
> "WARNING: line over 80 characters".

Don't add a newline in the middle of an expression.

It is only the semicolon that goes over.  I don't think it harms
readability very much.

julia

>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index b2314636dc89..f537722395c6 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -479,7 +479,8 @@ pi433_receive(void *data)
>  	/* length byte enabled? */
>  	if (dev->rx_cfg.enable_length_byte == OPTION_ON) {
>  		retval = wait_event_interruptible(dev->fifo_wait_queue,
> -						  dev->free_in_fifo < FIFO_SIZE);
> +						  dev->free_in_fifo <
> +						  FIFO_SIZE);
>  		if (retval) /* wait was interrupted */
>  			goto abort;
>
> @@ -500,7 +501,8 @@ pi433_receive(void *data)
>  		bytes_total--;
>
>  		retval = wait_event_interruptible(dev->fifo_wait_queue,
> -						  dev->free_in_fifo < FIFO_SIZE);
> +						  dev->free_in_fifo <
> +						  FIFO_SIZE);
>  		if (retval) /* wait was interrupted */
>  			goto abort;
>
> @@ -513,7 +515,8 @@ pi433_receive(void *data)
>  	while (dev->rx_position < bytes_total) {
>  		if (!rf69_get_flag(dev->spi, payload_ready)) {
>  			retval = wait_event_interruptible(dev->fifo_wait_queue,
> -							  dev->free_in_fifo < FIFO_SIZE);
> +							  dev->free_in_fifo <
> +							  FIFO_SIZE);
>  			if (retval) /* wait was interrupted */
>  				goto abort;
>  		}
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190323002555.5280-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>