Please backport 25432eba9cd8f2ef (4.15, 4.16, 4.17) ("openvswitch: meter: Fix setting meter id for new entries")

Please backport 25432eba9cd8f2ef (4.15, 4.16, 4.17) ("openvswitch: meter: Fix setting meter id for new entries")

[Yifeng Sun]

commit upstream 25432eba9cd8f2ef5afef55be811b010a004b5fa

This commit ("openvswitch: meter: Fix setting meter id for new entries") fixes an issue that makes OVS meter malfunction. This fix is already in upstream 4.18 and later.

It is a low risk fix, since it only passes the missed value of meter_id to new meter entries.

Thanks a lot,
Yifeng

Re: Please backport 25432eba9cd8f2ef (4.15, 4.16, 4.17) ("openvswitch: meter: Fix setting meter id for new entries")

[Greg KH]

On Fri, Mar 22, 2019 at 02:35:40PM -0700, Yifeng Sun wrote:
> commit upstream 25432eba9cd8f2ef5afef55be811b010a004b5fa
> 
> This commit ("openvswitch: meter: Fix setting meter id for new entries") fixes an issue that makes OVS meter malfunction. This fix is already in upstream 4.18 and later.
> 
> It is a low risk fix, since it only passes the missed value of meter_id to new meter entries.

4.15, 4.16, and 4.17 are all long end-of-life kernels, so I don't know
what we can do here with this commit.

Do you need it in 4.14?  4.9?  4.4?

Always look at the kernel.org releases page to see the currently-alive
kernel versions.

thanks,

greg k-h

Re: Please backport 25432eba9cd8f2ef (4.15, 4.16, 4.17) ("openvswitch: meter: Fix setting meter id for new entries")

[Yifeng Sun]

Hi Greg,

Thanks a lot for the clarification. I had no idea of the concept of
alive or "end-of-life" kernels before, sorry about that.

We wanted to apply this patch because we saw that Ubuntu continues
releasing bug fixes for some of those old branches. If we see any
problems in Red Hat or Ubuntu, we'll just contact them directly.

OVS's meter was only introduced since 4.15, so there is no need for
kernels before that.

Thanks again,
Yifeng


On Fri, Mar 22, 2019 at 10:51 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Mar 22, 2019 at 02:35:40PM -0700, Yifeng Sun wrote:
> > commit upstream 25432eba9cd8f2ef5afef55be811b010a004b5fa
> >
> > This commit ("openvswitch: meter: Fix setting meter id for new entries") fixes an issue that makes OVS meter malfunction. This fix is already in upstream 4.18 and later.
> >
> > It is a low risk fix, since it only passes the missed value of meter_id to new meter entries.
>
> 4.15, 4.16, and 4.17 are all long end-of-life kernels, so I don't know
> what we can do here with this commit.
>
> Do you need it in 4.14?  4.9?  4.4?
>
> Always look at the kernel.org releases page to see the currently-alive
> kernel versions.
>
> thanks,
>
> greg k-h