* [PATCH] staging: rtl8723bs: include: Fix identation issue
@ 2019-03-23 22:09 Vatsala Narang
0 siblings, 0 replies; 4+ messages in thread
From: Vatsala Narang @ 2019-03-23 22:09 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Vatsala Narang
Corrected the identation of switch case to get rid of checkpatch error
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
drivers/staging/rtl8723bs/include/wifi.h | 72 ++++++++++++------------
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
index 559bf2606fb7..ee1994ecbf18 100644
--- a/drivers/staging/rtl8723bs/include/wifi.h
+++ b/drivers/staging/rtl8723bs/include/wifi.h
@@ -374,18 +374,18 @@ __inline static unsigned char * get_da(unsigned char *pframe)
unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
switch (to_fr_ds) {
- case 0x00: /* ToDs = 0, FromDs = 0 */
- da = GetAddr1Ptr(pframe);
- break;
- case 0x01: /* ToDs = 0, FromDs = 1 */
- da = GetAddr1Ptr(pframe);
- break;
- case 0x02: /* ToDs = 1, FromDs = 0 */
- da = GetAddr3Ptr(pframe);
- break;
- default: /* ToDs = 1, FromDs = 1 */
- da = GetAddr3Ptr(pframe);
- break;
+ case 0x00: /* ToDs = 0, FromDs = 0 */
+ da = GetAddr1Ptr(pframe);
+ break;
+ case 0x01: /* ToDs = 0, FromDs = 1 */
+ da = GetAddr1Ptr(pframe);
+ break;
+ case 0x02: /* ToDs = 1, FromDs = 0 */
+ da = GetAddr3Ptr(pframe);
+ break;
+ default: /* ToDs = 1, FromDs = 1 */
+ da = GetAddr3Ptr(pframe);
+ break;
}
return da;
@@ -398,18 +398,18 @@ __inline static unsigned char * get_sa(unsigned char *pframe)
unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
switch (to_fr_ds) {
- case 0x00: /* ToDs = 0, FromDs = 0 */
- sa = GetAddr2Ptr(pframe);
- break;
- case 0x01: /* ToDs = 0, FromDs = 1 */
- sa = GetAddr3Ptr(pframe);
- break;
- case 0x02: /* ToDs = 1, FromDs = 0 */
- sa = GetAddr2Ptr(pframe);
- break;
- default: /* ToDs = 1, FromDs = 1 */
- sa = GetAddr4Ptr(pframe);
- break;
+ case 0x00: /* ToDs = 0, FromDs = 0 */
+ sa = GetAddr2Ptr(pframe);
+ break;
+ case 0x01: /* ToDs = 0, FromDs = 1 */
+ sa = GetAddr3Ptr(pframe);
+ break;
+ case 0x02: /* ToDs = 1, FromDs = 0 */
+ sa = GetAddr2Ptr(pframe);
+ break;
+ default: /* ToDs = 1, FromDs = 1 */
+ sa = GetAddr4Ptr(pframe);
+ break;
}
return sa;
@@ -421,18 +421,18 @@ __inline static unsigned char * get_hdr_bssid(unsigned char *pframe)
unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
switch (to_fr_ds) {
- case 0x00: /* ToDs = 0, FromDs = 0 */
- sa = GetAddr3Ptr(pframe);
- break;
- case 0x01: /* ToDs = 0, FromDs = 1 */
- sa = GetAddr2Ptr(pframe);
- break;
- case 0x02: /* ToDs = 1, FromDs = 0 */
- sa = GetAddr1Ptr(pframe);
- break;
- case 0x03: /* ToDs = 1, FromDs = 1 */
- sa = GetAddr1Ptr(pframe);
- break;
+ case 0x00: /* ToDs = 0, FromDs = 0 */
+ sa = GetAddr3Ptr(pframe);
+ break;
+ case 0x01: /* ToDs = 0, FromDs = 1 */
+ sa = GetAddr2Ptr(pframe);
+ break;
+ case 0x02: /* ToDs = 1, FromDs = 0 */
+ sa = GetAddr1Ptr(pframe);
+ break;
+ case 0x03: /* ToDs = 1, FromDs = 1 */
+ sa = GetAddr1Ptr(pframe);
+ break;
}
return sa;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8723bs: include: Fix identation issue
2019-03-29 16:13 ` Greg KH
@ 2019-03-29 16:17 ` Vatsala Narang
0 siblings, 0 replies; 4+ messages in thread
From: Vatsala Narang @ 2019-03-29 16:17 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 41 bytes --]
Okay, I will resend it.
thanks,
Vatsala
[-- Attachment #1.2: Type: text/html, Size: 101 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8723bs: include: Fix identation issue
2019-03-28 18:45 Vatsala Narang
@ 2019-03-29 16:13 ` Greg KH
2019-03-29 16:17 ` Vatsala Narang
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-03-29 16:13 UTC (permalink / raw)
To: Vatsala Narang; +Cc: outreachy-kernel
On Fri, Mar 29, 2019 at 12:15:23AM +0530, Vatsala Narang wrote:
> Corrected the identation of switch case to get rid of checkpatch error
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/wifi.h | 72 ++++++++++++------------
> 1 file changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
> index 559bf2606fb7..ee1994ecbf18 100644
> --- a/drivers/staging/rtl8723bs/include/wifi.h
> +++ b/drivers/staging/rtl8723bs/include/wifi.h
> @@ -374,18 +374,18 @@ __inline static unsigned char * get_da(unsigned char *pframe)
> unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
>
> switch (to_fr_ds) {
> - case 0x00: /* ToDs = 0, FromDs = 0 */
> - da = GetAddr1Ptr(pframe);
> - break;
> - case 0x01: /* ToDs = 0, FromDs = 1 */
> - da = GetAddr1Ptr(pframe);
> - break;
> - case 0x02: /* ToDs = 1, FromDs = 0 */
> - da = GetAddr3Ptr(pframe);
> - break;
> - default: /* ToDs = 1, FromDs = 1 */
> - da = GetAddr3Ptr(pframe);
> - break;
> + case 0x00: /* ToDs = 0, FromDs = 0 */
> + da = GetAddr1Ptr(pframe);
> + break;
> + case 0x01: /* ToDs = 0, FromDs = 1 */
> + da = GetAddr1Ptr(pframe);
> + break;
> + case 0x02: /* ToDs = 1, FromDs = 0 */
> + da = GetAddr3Ptr(pframe);
> + break;
> + default: /* ToDs = 1, FromDs = 1 */
> + da = GetAddr3Ptr(pframe);
> + break;
> }
>
> return da;
> @@ -398,18 +398,18 @@ __inline static unsigned char * get_sa(unsigned char *pframe)
> unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
>
> switch (to_fr_ds) {
> - case 0x00: /* ToDs = 0, FromDs = 0 */
> - sa = GetAddr2Ptr(pframe);
> - break;
> - case 0x01: /* ToDs = 0, FromDs = 1 */
> - sa = GetAddr3Ptr(pframe);
> - break;
> - case 0x02: /* ToDs = 1, FromDs = 0 */
> - sa = GetAddr2Ptr(pframe);
> - break;
> - default: /* ToDs = 1, FromDs = 1 */
> - sa = GetAddr4Ptr(pframe);
> - break;
> + case 0x00: /* ToDs = 0, FromDs = 0 */
> + sa = GetAddr2Ptr(pframe);
> + break;
> + case 0x01: /* ToDs = 0, FromDs = 1 */
> + sa = GetAddr3Ptr(pframe);
> + break;
> + case 0x02: /* ToDs = 1, FromDs = 0 */
> + sa = GetAddr2Ptr(pframe);
> + break;
> + default: /* ToDs = 1, FromDs = 1 */
> + sa = GetAddr4Ptr(pframe);
> + break;
> }
>
> return sa;
> @@ -421,18 +421,18 @@ __inline static unsigned char * get_hdr_bssid(unsigned char *pframe)
> unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
>
> switch (to_fr_ds) {
> - case 0x00: /* ToDs = 0, FromDs = 0 */
> - sa = GetAddr3Ptr(pframe);
> - break;
> - case 0x01: /* ToDs = 0, FromDs = 1 */
> - sa = GetAddr2Ptr(pframe);
> - break;
> - case 0x02: /* ToDs = 1, FromDs = 0 */
> - sa = GetAddr1Ptr(pframe);
> - break;
> - case 0x03: /* ToDs = 1, FromDs = 1 */
> - sa = GetAddr1Ptr(pframe);
> - break;
> + case 0x00: /* ToDs = 0, FromDs = 0 */
> + sa = GetAddr3Ptr(pframe);
> + break;
> + case 0x01: /* ToDs = 0, FromDs = 1 */
> + sa = GetAddr2Ptr(pframe);
> + break;
> + case 0x02: /* ToDs = 1, FromDs = 0 */
> + sa = GetAddr1Ptr(pframe);
> + break;
> + case 0x03: /* ToDs = 1, FromDs = 1 */
> + sa = GetAddr1Ptr(pframe);
> + break;
> }
>
> return sa;
> --
> 2.17.1
>
Patch does not apply to my staging-next branch. Please rebase and
resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: rtl8723bs: include: Fix identation issue
@ 2019-03-28 18:45 Vatsala Narang
2019-03-29 16:13 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Vatsala Narang @ 2019-03-28 18:45 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Vatsala Narang
Corrected the identation of switch case to get rid of checkpatch error
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
drivers/staging/rtl8723bs/include/wifi.h | 72 ++++++++++++------------
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
index 559bf2606fb7..ee1994ecbf18 100644
--- a/drivers/staging/rtl8723bs/include/wifi.h
+++ b/drivers/staging/rtl8723bs/include/wifi.h
@@ -374,18 +374,18 @@ __inline static unsigned char * get_da(unsigned char *pframe)
unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
switch (to_fr_ds) {
- case 0x00: /* ToDs = 0, FromDs = 0 */
- da = GetAddr1Ptr(pframe);
- break;
- case 0x01: /* ToDs = 0, FromDs = 1 */
- da = GetAddr1Ptr(pframe);
- break;
- case 0x02: /* ToDs = 1, FromDs = 0 */
- da = GetAddr3Ptr(pframe);
- break;
- default: /* ToDs = 1, FromDs = 1 */
- da = GetAddr3Ptr(pframe);
- break;
+ case 0x00: /* ToDs = 0, FromDs = 0 */
+ da = GetAddr1Ptr(pframe);
+ break;
+ case 0x01: /* ToDs = 0, FromDs = 1 */
+ da = GetAddr1Ptr(pframe);
+ break;
+ case 0x02: /* ToDs = 1, FromDs = 0 */
+ da = GetAddr3Ptr(pframe);
+ break;
+ default: /* ToDs = 1, FromDs = 1 */
+ da = GetAddr3Ptr(pframe);
+ break;
}
return da;
@@ -398,18 +398,18 @@ __inline static unsigned char * get_sa(unsigned char *pframe)
unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
switch (to_fr_ds) {
- case 0x00: /* ToDs = 0, FromDs = 0 */
- sa = GetAddr2Ptr(pframe);
- break;
- case 0x01: /* ToDs = 0, FromDs = 1 */
- sa = GetAddr3Ptr(pframe);
- break;
- case 0x02: /* ToDs = 1, FromDs = 0 */
- sa = GetAddr2Ptr(pframe);
- break;
- default: /* ToDs = 1, FromDs = 1 */
- sa = GetAddr4Ptr(pframe);
- break;
+ case 0x00: /* ToDs = 0, FromDs = 0 */
+ sa = GetAddr2Ptr(pframe);
+ break;
+ case 0x01: /* ToDs = 0, FromDs = 1 */
+ sa = GetAddr3Ptr(pframe);
+ break;
+ case 0x02: /* ToDs = 1, FromDs = 0 */
+ sa = GetAddr2Ptr(pframe);
+ break;
+ default: /* ToDs = 1, FromDs = 1 */
+ sa = GetAddr4Ptr(pframe);
+ break;
}
return sa;
@@ -421,18 +421,18 @@ __inline static unsigned char * get_hdr_bssid(unsigned char *pframe)
unsigned int to_fr_ds = (GetToDs(pframe) << 1) | GetFrDs(pframe);
switch (to_fr_ds) {
- case 0x00: /* ToDs = 0, FromDs = 0 */
- sa = GetAddr3Ptr(pframe);
- break;
- case 0x01: /* ToDs = 0, FromDs = 1 */
- sa = GetAddr2Ptr(pframe);
- break;
- case 0x02: /* ToDs = 1, FromDs = 0 */
- sa = GetAddr1Ptr(pframe);
- break;
- case 0x03: /* ToDs = 1, FromDs = 1 */
- sa = GetAddr1Ptr(pframe);
- break;
+ case 0x00: /* ToDs = 0, FromDs = 0 */
+ sa = GetAddr3Ptr(pframe);
+ break;
+ case 0x01: /* ToDs = 0, FromDs = 1 */
+ sa = GetAddr2Ptr(pframe);
+ break;
+ case 0x02: /* ToDs = 1, FromDs = 0 */
+ sa = GetAddr1Ptr(pframe);
+ break;
+ case 0x03: /* ToDs = 1, FromDs = 1 */
+ sa = GetAddr1Ptr(pframe);
+ break;
}
return sa;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-29 16:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-23 22:09 [PATCH] staging: rtl8723bs: include: Fix identation issue Vatsala Narang
2019-03-28 18:45 Vatsala Narang
2019-03-29 16:13 ` Greg KH
2019-03-29 16:17 ` Vatsala Narang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.