[igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Uma Shankar]

Due to Gamma/Degamma limitation with precision (lack of
exact 1.0 representation) due to ABI restriction, applying
linear gamma affects crc. This patch fixes the same by making
ctm tests independant of gamma/degamma.

v2: Disable degamma/gamma programming for ctm max test as it
leads to crc mimsmatch. Limiting it to this test case alone as
other tests need it to be enabled, hence not touching those
scenarios.

v3: Fixed a fumble with compilation.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
 tests/kms_color.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2..dcc86ad 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -696,8 +696,15 @@ static bool test_pipe_ctm(data_t *data,
 		igt_assert(fb_modeset_id);
 		igt_plane_set_fb(primary, &fb_modeset);
 
-		set_degamma(data, primary->pipe, degamma_linear);
-		set_gamma(data, primary->pipe, gamma_linear);
+		/*
+		 * Don't program LUT's for max CTM cases as limitation of
+		 * representing 1.0 due to ABI limits causes crc mismatch
+		 */
+		if (memcmp(before, after, sizeof(color_t))) {
+			set_degamma(data, primary->pipe, degamma_linear);
+			set_gamma(data, primary->pipe, gamma_linear);
+		}
+
 		disable_ctm(primary->pipe);
 		igt_display_commit(&data->display);
 
@@ -1005,6 +1012,11 @@ run_tests_for_pipe(data_t *data, enum pipe p)
 		 * produce with an 8 bits per color framebuffer. */
 		igt_require(!IS_CHERRYVIEW(data->devid));
 
+		/* Disable and let default luts be applied by kernel */
+		disable_degamma(primary->pipe);
+		disable_gamma(primary->pipe);
+		igt_display_commit(&data->display);
+
 		igt_assert(test_pipe_ctm(data, primary, red_green_blue,
 					 full_rgb, ctm));
 	}
-- 
1.9.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Fix CRC mismatch issues with ctm test (rev4)

[Patchwork]

== Series Details ==

Series: tests/kms_color: Fix CRC mismatch issues with ctm test (rev4)
URL   : https://patchwork.freedesktop.org/series/58412/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5808 -> IGTPW_2698
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_2698 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2698, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/4/mbox/


Changes
-------

  No changes found


Participating hosts (36 -> 5)
------------------------------

  ERROR: It appears as if the changes made in IGTPW_2698 prevented too many machines from booting.

  Missing    (31): fi-skl-6770hq fi-bdw-gvtdvm fi-snb-2520m fi-apl-guc fi-bxt-j4205 fi-icl-u3 fi-pnv-d510 fi-skl-lmem fi-blb-e6850 fi-byt-n2820 fi-skl-6600u fi-hsw-4770r fi-bxt-dsi fi-bwr-2160 fi-ilk-650 fi-kbl-7500u fi-hsw-4770 fi-ivb-3770 fi-skl-6700k2 fi-kbl-7567u fi-ilk-m540 fi-skl-gvtdvm fi-skl-guc fi-cfl-8700k fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-whl-u fi-cfl-8109u fi-skl-iommu fi-kbl-8809g 


Build changes
-------------

    * IGT: IGT_4902 -> IGTPW_2698

  CI_DRM_5808: 0053882c75f979b475f4d543c4b14cbbed218f38 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2698: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2698/
  IGT_4902: 3d325bb211d8cd84c6862c9945185a937395cb44 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2698/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Fix CRC mismatch issues with ctm test (rev5)

[Patchwork]

== Series Details ==

Series: tests/kms_color: Fix CRC mismatch issues with ctm test (rev5)
URL   : https://patchwork.freedesktop.org/series/58412/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5811 -> IGTPW_2701
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_2701 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2701, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/5/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2701 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_store@basic-bsd2:
    - fi-hsw-4770:        NOTRUN -> SKIP [fdo#109271] +41

  * igt@i915_selftest@live_hangcheck:
    - fi-skl-iommu:       NOTRUN -> INCOMPLETE [fdo#108602] / [fdo#108744]

  * igt@kms_busy@basic-flip-c:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@dp-edid-read:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] +76

  * igt@kms_psr@primary_mmap_gtt:
    - fi-cfl-guc:         NOTRUN -> SKIP [fdo#109271] +49

  * igt@kms_psr@sprite_plane_onoff:
    - fi-skl-iommu:       NOTRUN -> SKIP [fdo#109271] +45

  * igt@runner@aborted:
    - fi-skl-iommu:       NOTRUN -> FAIL [fdo#104108] / [fdo#108602]

  
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
  [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278


Participating hosts (18 -> 8)
------------------------------

  ERROR: It appears as if the changes made in IGTPW_2701 prevented too many machines from booting.

  Additional (4): fi-hsw-4770 fi-blb-e6850 fi-cfl-guc fi-skl-iommu 
  Missing    (14): fi-ilk-m540 fi-skl-gvtdvm fi-skl-guc fi-bdw-gvtdvm fi-cfl-8700k fi-kbl-guc fi-whl-u fi-bxt-j4205 fi-cfl-8109u fi-elk-e7500 fi-kbl-8809g fi-skl-lmem fi-byt-n2820 fi-skl-6700k2 


Build changes
-------------

    * IGT: IGT_4902 -> IGTPW_2701

  CI_DRM_5811: efeb64571b430e74fa6b755fd279b9a991538b9d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2701: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2701/
  IGT_4902: 3d325bb211d8cd84c6862c9945185a937395cb44 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2701/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev6)

[Patchwork]

== Series Details ==

Series: tests/kms_color: Fix CRC mismatch issues with ctm test (rev6)
URL   : https://patchwork.freedesktop.org/series/58412/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5813 -> IGTPW_2707
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/6/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2707 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-whl-u:           NOTRUN -> SKIP [fdo#109271] +41

  * igt@gem_exec_basic@readonly-bsd2:
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] +76

  * igt@i915_selftest@live_uncore:
    - fi-ivb-3770:        PASS -> DMESG-FAIL [fdo#110210]

  * igt@kms_busy@basic-flip-c:
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@dp-edid-read:
    - fi-skl-iommu:       NOTRUN -> SKIP [fdo#109271] +45

  * igt@kms_chamelium@vga-edid-read:
    - fi-skl-6600u:       NOTRUN -> SKIP [fdo#109271] +41

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-whl-u:           NOTRUN -> FAIL [fdo#103375] +3
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@kms_psr@cursor_plane_move:
    - fi-whl-u:           NOTRUN -> FAIL [fdo#107383] +3

  
#### Possible fixes ####

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      FAIL [fdo#108511] -> PASS

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

  * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
  [fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210


Participating hosts (41 -> 42)
------------------------------

  Additional (5): fi-whl-u fi-skl-iommu fi-pnv-d510 fi-icl-dsi fi-skl-6600u 
  Missing    (4): fi-ilk-m540 fi-byt-squawks fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

    * IGT: IGT_4903 -> IGTPW_2707

  CI_DRM_5813: 79df6ae8e7d6fc94965a14e1fa04898954d40316 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2707: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2707/
  IGT_4903: a4dc3d0f9ac6abf2a0ca6a4771255cb5dcb3b07b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2707/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Shankar, Uma]

>-----Original Message-----
>From: Shankar, Uma
>Sent: Monday, March 25, 2019 2:11 PM
>To: igt-dev@lists.freedesktop.org
>Cc: Shankar, Uma <uma.shankar@intel.com>
>Subject: [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
>
>Due to Gamma/Degamma limitation with precision (lack of exact 1.0 representation)
>due to ABI restriction, applying linear gamma affects crc. This patch fixes the same by
>making ctm tests independant of gamma/degamma.
>
>v2: Disable degamma/gamma programming for ctm max test as it leads to crc
>mimsmatch. Limiting it to this test case alone as other tests need it to be enabled,
>hence not touching those scenarios.
>
>v3: Fixed a fumble with compilation.

Hi Ville,
Can I keep your RB on this version. We have a clean CI result available now.

Thanks & Regards,
Uma Shankar

>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
>Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>---
> tests/kms_color.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
>diff --git a/tests/kms_color.c b/tests/kms_color.c index decf3c2..dcc86ad 100644
>--- a/tests/kms_color.c
>+++ b/tests/kms_color.c
>@@ -696,8 +696,15 @@ static bool test_pipe_ctm(data_t *data,
> 		igt_assert(fb_modeset_id);
> 		igt_plane_set_fb(primary, &fb_modeset);
>
>-		set_degamma(data, primary->pipe, degamma_linear);
>-		set_gamma(data, primary->pipe, gamma_linear);
>+		/*
>+		 * Don't program LUT's for max CTM cases as limitation of
>+		 * representing 1.0 due to ABI limits causes crc mismatch
>+		 */
>+		if (memcmp(before, after, sizeof(color_t))) {
>+			set_degamma(data, primary->pipe, degamma_linear);
>+			set_gamma(data, primary->pipe, gamma_linear);
>+		}
>+
> 		disable_ctm(primary->pipe);
> 		igt_display_commit(&data->display);
>
>@@ -1005,6 +1012,11 @@ run_tests_for_pipe(data_t *data, enum pipe p)
> 		 * produce with an 8 bits per color framebuffer. */
> 		igt_require(!IS_CHERRYVIEW(data->devid));
>
>+		/* Disable and let default luts be applied by kernel */
>+		disable_degamma(primary->pipe);
>+		disable_gamma(primary->pipe);
>+		igt_display_commit(&data->display);
>+
> 		igt_assert(test_pipe_ctm(data, primary, red_green_blue,
> 					 full_rgb, ctm));
> 	}
>--
>1.9.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_color: Fix CRC mismatch issues with ctm test (rev6)

[Patchwork]

== Series Details ==

Series: tests/kms_color: Fix CRC mismatch issues with ctm test (rev6)
URL   : https://patchwork.freedesktop.org/series/58412/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5813_full -> IGTPW_2707_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58412/revisions/6/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2707_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_tiled_swapping@non-threaded:
    - shard-hsw:          PASS -> FAIL [fdo#108686]

  * igt@kms_atomic_transition@plane-all-modeset-transition:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]
    - shard-apl:          PASS -> INCOMPLETE [fdo#103927] +1

  * igt@kms_busy@extended-modeset-hang-newfb-render-a:
    - shard-kbl:          PASS -> DMESG-WARN [fdo#110222] +2

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
    - shard-snb:          PASS -> DMESG-WARN [fdo#110222] +2
    - shard-hsw:          PASS -> DMESG-WARN [fdo#110222]

  * igt@kms_color@pipe-a-degamma:
    - shard-apl:          PASS -> FAIL [fdo#104782] / [fdo#108145]

  * igt@kms_cursor_crc@cursor-64x64-dpms:
    - shard-kbl:          PASS -> FAIL [fdo#103232]
    - shard-apl:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_crc@cursor-64x64-onscreen:
    - shard-glk:          PASS -> FAIL [fdo#103232]

  * igt@kms_flip@2x-flip-vs-panning:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +6

  * igt@kms_flip@flip-vs-blocking-wf-vblank:
    - shard-hsw:          PASS -> INCOMPLETE [fdo#103540] +1

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +13

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2

  * igt@kms_pipe_crc_basic@read-crc-pipe-f:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          PASS -> FAIL [fdo#109016]

  * igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

  * igt@kms_vblank@pipe-c-ts-continuation-modeset-hang:
    - shard-apl:          PASS -> FAIL [fdo#104894]
    - shard-kbl:          PASS -> FAIL [fdo#104894]

  * igt@perf_pmu@busy-accuracy-98-rcs0:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +44

  
#### Possible fixes ####

  * igt@kms_busy@extended-modeset-hang-newfb-render-b:
    - shard-hsw:          DMESG-WARN [fdo#110222] -> PASS +1

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
    - shard-kbl:          DMESG-WARN [fdo#110222] -> PASS +1
    - shard-snb:          DMESG-WARN [fdo#110222] -> PASS

  * igt@kms_color@pipe-c-ctm-max:
    - shard-glk:          FAIL [fdo#108147] -> PASS +2

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
    - shard-kbl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-glk:          FAIL [fdo#102887] / [fdo#105363] -> PASS

  * igt@kms_flip@modeset-vs-vblank-race-interruptible:
    - shard-glk:          FAIL [fdo#103060] -> PASS

  * igt@kms_setmode@basic:
    - shard-kbl:          FAIL [fdo#99912] -> PASS

  * igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
    - shard-apl:          FAIL [fdo#104894] -> PASS +1

  * igt@tools_test@sysfs_l3_parity:
    - shard-hsw:          SKIP [fdo#109271] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 5)
------------------------------

  Missing    (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u 


Build changes
-------------

    * IGT: IGT_4903 -> IGTPW_2707
    * Piglit: piglit_4509 -> None

  CI_DRM_5813: 79df6ae8e7d6fc94965a14e1fa04898954d40316 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2707: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2707/
  IGT_4903: a4dc3d0f9ac6abf2a0ca6a4771255cb5dcb3b07b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2707/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Ville Syrjälä]

On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Shankar, Uma
> >Sent: Monday, March 25, 2019 2:11 PM
> >To: igt-dev@lists.freedesktop.org
> >Cc: Shankar, Uma <uma.shankar@intel.com>
> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
> >
> >Due to Gamma/Degamma limitation with precision (lack of exact 1.0 representation)
> >due to ABI restriction, applying linear gamma affects crc. This patch fixes the same by
> >making ctm tests independant of gamma/degamma.
> >
> >v2: Disable degamma/gamma programming for ctm max test as it leads to crc
> >mimsmatch. Limiting it to this test case alone as other tests need it to be enabled,
> >hence not touching those scenarios.
> >
> >v3: Fixed a fumble with compilation.
> 
> Hi Ville,
> Can I keep your RB on this version. We have a clean CI result available now.

I'm confused. Why didn't disabling degamma+gamma work?

> 
> Thanks & Regards,
> Uma Shankar
> 
> >Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
> >Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> >---
> > tests/kms_color.c | 16 ++++++++++++++--
> > 1 file changed, 14 insertions(+), 2 deletions(-)
> >
> >diff --git a/tests/kms_color.c b/tests/kms_color.c index decf3c2..dcc86ad 100644
> >--- a/tests/kms_color.c
> >+++ b/tests/kms_color.c
> >@@ -696,8 +696,15 @@ static bool test_pipe_ctm(data_t *data,
> > 		igt_assert(fb_modeset_id);
> > 		igt_plane_set_fb(primary, &fb_modeset);
> >
> >-		set_degamma(data, primary->pipe, degamma_linear);
> >-		set_gamma(data, primary->pipe, gamma_linear);
> >+		/*
> >+		 * Don't program LUT's for max CTM cases as limitation of
> >+		 * representing 1.0 due to ABI limits causes crc mismatch
> >+		 */
> >+		if (memcmp(before, after, sizeof(color_t))) {
> >+			set_degamma(data, primary->pipe, degamma_linear);
> >+			set_gamma(data, primary->pipe, gamma_linear);
> >+		}
> >+
> > 		disable_ctm(primary->pipe);
> > 		igt_display_commit(&data->display);
> >
> >@@ -1005,6 +1012,11 @@ run_tests_for_pipe(data_t *data, enum pipe p)
> > 		 * produce with an 8 bits per color framebuffer. */
> > 		igt_require(!IS_CHERRYVIEW(data->devid));
> >
> >+		/* Disable and let default luts be applied by kernel */
> >+		disable_degamma(primary->pipe);
> >+		disable_gamma(primary->pipe);
> >+		igt_display_commit(&data->display);
> >+
> > 		igt_assert(test_pipe_ctm(data, primary, red_green_blue,
> > 					 full_rgb, ctm));
> > 	}
> >--
> >1.9.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Shankar, Uma]

>-----Original Message-----
>From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>Sent: Tuesday, March 26, 2019 10:16 PM
>To: Shankar, Uma <uma.shankar@intel.com>
>Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@intel.com>; Lankhorst,
>Maarten <maarten.lankhorst@intel.com>
>Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
>
>On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
>>
>>
>> >-----Original Message-----
>> >From: Shankar, Uma
>> >Sent: Monday, March 25, 2019 2:11 PM
>> >To: igt-dev@lists.freedesktop.org
>> >Cc: Shankar, Uma <uma.shankar@intel.com>
>> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
>> >
>> >Due to Gamma/Degamma limitation with precision (lack of exact 1.0
>> >representation) due to ABI restriction, applying linear gamma affects
>> >crc. This patch fixes the same by making ctm tests independant of
>gamma/degamma.
>> >
>> >v2: Disable degamma/gamma programming for ctm max test as it leads to
>> >crc mimsmatch. Limiting it to this test case alone as other tests
>> >need it to be enabled, hence not touching those scenarios.
>> >
>> >v3: Fixed a fumble with compilation.
>>
>> Hi Ville,
>> Can I keep your RB on this version. We have a clean CI result available now.
>
>I'm confused. Why didn't disabling degamma+gamma work?

We need to disable degamma/gamma and also make sure we don't set them again with
linear values, which was being done currently. Hence, disabled it and later made sure it's
kept at that.

Regards,
Uma Shankar

>>
>> Thanks & Regards,
>> Uma Shankar
>>
>> >Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
>> >Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>> >---
>> > tests/kms_color.c | 16 ++++++++++++++--
>> > 1 file changed, 14 insertions(+), 2 deletions(-)
>> >
>> >diff --git a/tests/kms_color.c b/tests/kms_color.c index
>> >decf3c2..dcc86ad 100644
>> >--- a/tests/kms_color.c
>> >+++ b/tests/kms_color.c
>> >@@ -696,8 +696,15 @@ static bool test_pipe_ctm(data_t *data,
>> > 		igt_assert(fb_modeset_id);
>> > 		igt_plane_set_fb(primary, &fb_modeset);
>> >
>> >-		set_degamma(data, primary->pipe, degamma_linear);
>> >-		set_gamma(data, primary->pipe, gamma_linear);
>> >+		/*
>> >+		 * Don't program LUT's for max CTM cases as limitation of
>> >+		 * representing 1.0 due to ABI limits causes crc mismatch
>> >+		 */
>> >+		if (memcmp(before, after, sizeof(color_t))) {
>> >+			set_degamma(data, primary->pipe, degamma_linear);
>> >+			set_gamma(data, primary->pipe, gamma_linear);
>> >+		}
>> >+
>> > 		disable_ctm(primary->pipe);
>> > 		igt_display_commit(&data->display);
>> >
>> >@@ -1005,6 +1012,11 @@ run_tests_for_pipe(data_t *data, enum pipe p)
>> > 		 * produce with an 8 bits per color framebuffer. */
>> > 		igt_require(!IS_CHERRYVIEW(data->devid));
>> >
>> >+		/* Disable and let default luts be applied by kernel */
>> >+		disable_degamma(primary->pipe);
>> >+		disable_gamma(primary->pipe);
>> >+		igt_display_commit(&data->display);
>> >+
>> > 		igt_assert(test_pipe_ctm(data, primary, red_green_blue,
>> > 					 full_rgb, ctm));
>> > 	}
>> >--
>> >1.9.1
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
>--
>Ville Syrjälä
>Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Ville Syrjälä]

On Wed, Mar 27, 2019 at 06:20:10AM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> >Sent: Tuesday, March 26, 2019 10:16 PM
> >To: Shankar, Uma <uma.shankar@intel.com>
> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@intel.com>; Lankhorst,
> >Maarten <maarten.lankhorst@intel.com>
> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
> >
> >On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
> >>
> >>
> >> >-----Original Message-----
> >> >From: Shankar, Uma
> >> >Sent: Monday, March 25, 2019 2:11 PM
> >> >To: igt-dev@lists.freedesktop.org
> >> >Cc: Shankar, Uma <uma.shankar@intel.com>
> >> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
> >> >
> >> >Due to Gamma/Degamma limitation with precision (lack of exact 1.0
> >> >representation) due to ABI restriction, applying linear gamma affects
> >> >crc. This patch fixes the same by making ctm tests independant of
> >gamma/degamma.
> >> >
> >> >v2: Disable degamma/gamma programming for ctm max test as it leads to
> >> >crc mimsmatch. Limiting it to this test case alone as other tests
> >> >need it to be enabled, hence not touching those scenarios.
> >> >
> >> >v3: Fixed a fumble with compilation.
> >>
> >> Hi Ville,
> >> Can I keep your RB on this version. We have a clean CI result available now.
> >
> >I'm confused. Why didn't disabling degamma+gamma work?
> 
> We need to disable degamma/gamma and also make sure we don't set them again with
> linear values, which was being done currently. Hence, disabled it and later made sure it's
> kept at that.

Who is turning it back on and why?

> 
> Regards,
> Uma Shankar
> 
> >>
> >> Thanks & Regards,
> >> Uma Shankar
> >>
> >> >Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
> >> >Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> >> >---
> >> > tests/kms_color.c | 16 ++++++++++++++--
> >> > 1 file changed, 14 insertions(+), 2 deletions(-)
> >> >
> >> >diff --git a/tests/kms_color.c b/tests/kms_color.c index
> >> >decf3c2..dcc86ad 100644
> >> >--- a/tests/kms_color.c
> >> >+++ b/tests/kms_color.c
> >> >@@ -696,8 +696,15 @@ static bool test_pipe_ctm(data_t *data,
> >> > 		igt_assert(fb_modeset_id);
> >> > 		igt_plane_set_fb(primary, &fb_modeset);
> >> >
> >> >-		set_degamma(data, primary->pipe, degamma_linear);
> >> >-		set_gamma(data, primary->pipe, gamma_linear);
> >> >+		/*
> >> >+		 * Don't program LUT's for max CTM cases as limitation of
> >> >+		 * representing 1.0 due to ABI limits causes crc mismatch
> >> >+		 */
> >> >+		if (memcmp(before, after, sizeof(color_t))) {
> >> >+			set_degamma(data, primary->pipe, degamma_linear);
> >> >+			set_gamma(data, primary->pipe, gamma_linear);
> >> >+		}
> >> >+
> >> > 		disable_ctm(primary->pipe);
> >> > 		igt_display_commit(&data->display);
> >> >
> >> >@@ -1005,6 +1012,11 @@ run_tests_for_pipe(data_t *data, enum pipe p)
> >> > 		 * produce with an 8 bits per color framebuffer. */
> >> > 		igt_require(!IS_CHERRYVIEW(data->devid));
> >> >
> >> >+		/* Disable and let default luts be applied by kernel */
> >> >+		disable_degamma(primary->pipe);
> >> >+		disable_gamma(primary->pipe);
> >> >+		igt_display_commit(&data->display);
> >> >+
> >> > 		igt_assert(test_pipe_ctm(data, primary, red_green_blue,
> >> > 					 full_rgb, ctm));
> >> > 	}
> >> >--
> >> >1.9.1
> >>
> >> _______________________________________________
> >> igt-dev mailing list
> >> igt-dev@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/igt-dev
> >
> >--
> >Ville Syrjälä
> >Intel

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Shankar, Uma]

>On Wed, Mar 27, 2019 at 06:20:10AM +0000, Shankar, Uma wrote:
>>
>>
>> >-----Original Message-----
>> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>> >Sent: Tuesday, March 26, 2019 10:16 PM
>> >To: Shankar, Uma <uma.shankar@intel.com>
>> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville
>> ><ville.syrjala@intel.com>; Lankhorst, Maarten
>> ><maarten.lankhorst@intel.com>
>> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues
>> >with ctm test
>> >
>> >On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
>> >>
>> >>
>> >> >-----Original Message-----
>> >> >From: Shankar, Uma
>> >> >Sent: Monday, March 25, 2019 2:11 PM
>> >> >To: igt-dev@lists.freedesktop.org
>> >> >Cc: Shankar, Uma <uma.shankar@intel.com>
>> >> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with ctm
>> >> >test
>> >> >
>> >> >Due to Gamma/Degamma limitation with precision (lack of exact 1.0
>> >> >representation) due to ABI restriction, applying linear gamma
>> >> >affects crc. This patch fixes the same by making ctm tests
>> >> >independant of
>> >gamma/degamma.
>> >> >
>> >> >v2: Disable degamma/gamma programming for ctm max test as it leads
>> >> >to crc mimsmatch. Limiting it to this test case alone as other
>> >> >tests need it to be enabled, hence not touching those scenarios.
>> >> >
>> >> >v3: Fixed a fumble with compilation.
>> >>
>> >> Hi Ville,
>> >> Can I keep your RB on this version. We have a clean CI result available now.
>> >
>> >I'm confused. Why didn't disabling degamma+gamma work?
>>
>> We need to disable degamma/gamma and also make sure we don't set them
>> again with linear values, which was being done currently. Hence,
>> disabled it and later made sure it's kept at that.
>
>Who is turning it back on and why?

When we call disable from IGT, it passes a NULL LUT. In this case, default linear LUT is
getting applied in kernel. I am not sure if we really disable the gamma/degamma fully in
driver. It just works with linear values and remains enabled.

>>
>> Regards,
>> Uma Shankar
>>
>> >>
>> >> Thanks & Regards,
>> >> Uma Shankar
>> >>
>> >> >Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
>> >> >Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>> >> >---
>> >> > tests/kms_color.c | 16 ++++++++++++++--
>> >> > 1 file changed, 14 insertions(+), 2 deletions(-)
>> >> >
>> >> >diff --git a/tests/kms_color.c b/tests/kms_color.c index
>> >> >decf3c2..dcc86ad 100644
>> >> >--- a/tests/kms_color.c
>> >> >+++ b/tests/kms_color.c
>> >> >@@ -696,8 +696,15 @@ static bool test_pipe_ctm(data_t *data,
>> >> > 		igt_assert(fb_modeset_id);
>> >> > 		igt_plane_set_fb(primary, &fb_modeset);
>> >> >
>> >> >-		set_degamma(data, primary->pipe, degamma_linear);
>> >> >-		set_gamma(data, primary->pipe, gamma_linear);
>> >> >+		/*
>> >> >+		 * Don't program LUT's for max CTM cases as limitation of
>> >> >+		 * representing 1.0 due to ABI limits causes crc mismatch
>> >> >+		 */
>> >> >+		if (memcmp(before, after, sizeof(color_t))) {
>> >> >+			set_degamma(data, primary->pipe, degamma_linear);
>> >> >+			set_gamma(data, primary->pipe, gamma_linear);
>> >> >+		}
>> >> >+
>> >> > 		disable_ctm(primary->pipe);
>> >> > 		igt_display_commit(&data->display);
>> >> >
>> >> >@@ -1005,6 +1012,11 @@ run_tests_for_pipe(data_t *data, enum pipe p)
>> >> > 		 * produce with an 8 bits per color framebuffer. */
>> >> > 		igt_require(!IS_CHERRYVIEW(data->devid));
>> >> >
>> >> >+		/* Disable and let default luts be applied by kernel */
>> >> >+		disable_degamma(primary->pipe);
>> >> >+		disable_gamma(primary->pipe);
>> >> >+		igt_display_commit(&data->display);
>> >> >+
>> >> > 		igt_assert(test_pipe_ctm(data, primary, red_green_blue,
>> >> > 					 full_rgb, ctm));
>> >> > 	}
>> >> >--
>> >> >1.9.1
>> >>
>> >> _______________________________________________
>> >> igt-dev mailing list
>> >> igt-dev@lists.freedesktop.org
>> >> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>> >
>> >--
>> >Ville Syrjälä
>> >Intel
>
>--
>Ville Syrjälä
>Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Ville Syrjälä]

On Wed, Mar 27, 2019 at 10:52:48AM +0000, Shankar, Uma wrote:
> 
> 
> >On Wed, Mar 27, 2019 at 06:20:10AM +0000, Shankar, Uma wrote:
> >>
> >>
> >> >-----Original Message-----
> >> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> >> >Sent: Tuesday, March 26, 2019 10:16 PM
> >> >To: Shankar, Uma <uma.shankar@intel.com>
> >> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville
> >> ><ville.syrjala@intel.com>; Lankhorst, Maarten
> >> ><maarten.lankhorst@intel.com>
> >> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues
> >> >with ctm test
> >> >
> >> >On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
> >> >>
> >> >>
> >> >> >-----Original Message-----
> >> >> >From: Shankar, Uma
> >> >> >Sent: Monday, March 25, 2019 2:11 PM
> >> >> >To: igt-dev@lists.freedesktop.org
> >> >> >Cc: Shankar, Uma <uma.shankar@intel.com>
> >> >> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with ctm
> >> >> >test
> >> >> >
> >> >> >Due to Gamma/Degamma limitation with precision (lack of exact 1.0
> >> >> >representation) due to ABI restriction, applying linear gamma
> >> >> >affects crc. This patch fixes the same by making ctm tests
> >> >> >independant of
> >> >gamma/degamma.
> >> >> >
> >> >> >v2: Disable degamma/gamma programming for ctm max test as it leads
> >> >> >to crc mimsmatch. Limiting it to this test case alone as other
> >> >> >tests need it to be enabled, hence not touching those scenarios.
> >> >> >
> >> >> >v3: Fixed a fumble with compilation.
> >> >>
> >> >> Hi Ville,
> >> >> Can I keep your RB on this version. We have a clean CI result available now.
> >> >
> >> >I'm confused. Why didn't disabling degamma+gamma work?
> >>
> >> We need to disable degamma/gamma and also make sure we don't set them
> >> again with linear values, which was being done currently. Hence,
> >> disabled it and later made sure it's kept at that.
> >
> >Who is turning it back on and why?
> 
> When we call disable from IGT, it passes a NULL LUT. In this case, default linear LUT is
> getting applied in kernel. I am not sure if we really disable the gamma/degamma fully in
> driver. It just works with linear values and remains enabled.

We would disable after https://patchwork.freedesktop.org/series/58137/

Hmm. Looks like one patch missing r-b. I should probably go respin that
with Matt's comment added.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Shankar, Uma]

>-----Original Message-----
>From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>Sent: Wednesday, March 27, 2019 5:05 PM
>To: Shankar, Uma <uma.shankar@intel.com>
>Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@intel.com>; Lankhorst,
>Maarten <maarten.lankhorst@intel.com>
>Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
>
>On Wed, Mar 27, 2019 at 10:52:48AM +0000, Shankar, Uma wrote:
>>
>>
>> >On Wed, Mar 27, 2019 at 06:20:10AM +0000, Shankar, Uma wrote:
>> >>
>> >>
>> >> >-----Original Message-----
>> >> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>> >> >Sent: Tuesday, March 26, 2019 10:16 PM
>> >> >To: Shankar, Uma <uma.shankar@intel.com>
>> >> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville
>> >> ><ville.syrjala@intel.com>; Lankhorst, Maarten
>> >> ><maarten.lankhorst@intel.com>
>> >> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch
>> >> >issues with ctm test
>> >> >
>> >> >On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
>> >> >>
>> >> >>
>> >> >> >-----Original Message-----
>> >> >> >From: Shankar, Uma
>> >> >> >Sent: Monday, March 25, 2019 2:11 PM
>> >> >> >To: igt-dev@lists.freedesktop.org
>> >> >> >Cc: Shankar, Uma <uma.shankar@intel.com>
>> >> >> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with ctm
>> >> >> >test
>> >> >> >
>> >> >> >Due to Gamma/Degamma limitation with precision (lack of exact
>> >> >> >1.0
>> >> >> >representation) due to ABI restriction, applying linear gamma
>> >> >> >affects crc. This patch fixes the same by making ctm tests
>> >> >> >independant of
>> >> >gamma/degamma.
>> >> >> >
>> >> >> >v2: Disable degamma/gamma programming for ctm max test as it
>> >> >> >leads to crc mimsmatch. Limiting it to this test case alone as
>> >> >> >other tests need it to be enabled, hence not touching those scenarios.
>> >> >> >
>> >> >> >v3: Fixed a fumble with compilation.
>> >> >>
>> >> >> Hi Ville,
>> >> >> Can I keep your RB on this version. We have a clean CI result available now.
>> >> >
>> >> >I'm confused. Why didn't disabling degamma+gamma work?
>> >>
>> >> We need to disable degamma/gamma and also make sure we don't set
>> >> them again with linear values, which was being done currently.
>> >> Hence, disabled it and later made sure it's kept at that.
>> >
>> >Who is turning it back on and why?
>>
>> When we call disable from IGT, it passes a NULL LUT. In this case,
>> default linear LUT is getting applied in kernel. I am not sure if we
>> really disable the gamma/degamma fully in driver. It just works with linear values
>and remains enabled.
>
>We would disable after https://patchwork.freedesktop.org/series/58137/
>
>Hmm. Looks like one patch missing r-b. I should probably go respin that with Matt's
>comment added.

Ok sure, will re-test the patch once your change is merged and update the test. Thanks.

Regards,
Uma Shankar

>--
>Ville Syrjälä
>Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Ville Syrjälä]

On Wed, Mar 27, 2019 at 01:37:31PM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> >Sent: Wednesday, March 27, 2019 5:05 PM
> >To: Shankar, Uma <uma.shankar@intel.com>
> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@intel.com>; Lankhorst,
> >Maarten <maarten.lankhorst@intel.com>
> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
> >
> >On Wed, Mar 27, 2019 at 10:52:48AM +0000, Shankar, Uma wrote:
> >>
> >>
> >> >On Wed, Mar 27, 2019 at 06:20:10AM +0000, Shankar, Uma wrote:
> >> >>
> >> >>
> >> >> >-----Original Message-----
> >> >> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> >> >> >Sent: Tuesday, March 26, 2019 10:16 PM
> >> >> >To: Shankar, Uma <uma.shankar@intel.com>
> >> >> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville
> >> >> ><ville.syrjala@intel.com>; Lankhorst, Maarten
> >> >> ><maarten.lankhorst@intel.com>
> >> >> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch
> >> >> >issues with ctm test
> >> >> >
> >> >> >On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
> >> >> >>
> >> >> >>
> >> >> >> >-----Original Message-----
> >> >> >> >From: Shankar, Uma
> >> >> >> >Sent: Monday, March 25, 2019 2:11 PM
> >> >> >> >To: igt-dev@lists.freedesktop.org
> >> >> >> >Cc: Shankar, Uma <uma.shankar@intel.com>
> >> >> >> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with ctm
> >> >> >> >test
> >> >> >> >
> >> >> >> >Due to Gamma/Degamma limitation with precision (lack of exact
> >> >> >> >1.0
> >> >> >> >representation) due to ABI restriction, applying linear gamma
> >> >> >> >affects crc. This patch fixes the same by making ctm tests
> >> >> >> >independant of
> >> >> >gamma/degamma.
> >> >> >> >
> >> >> >> >v2: Disable degamma/gamma programming for ctm max test as it
> >> >> >> >leads to crc mimsmatch. Limiting it to this test case alone as
> >> >> >> >other tests need it to be enabled, hence not touching those scenarios.
> >> >> >> >
> >> >> >> >v3: Fixed a fumble with compilation.
> >> >> >>
> >> >> >> Hi Ville,
> >> >> >> Can I keep your RB on this version. We have a clean CI result available now.
> >> >> >
> >> >> >I'm confused. Why didn't disabling degamma+gamma work?
> >> >>
> >> >> We need to disable degamma/gamma and also make sure we don't set
> >> >> them again with linear values, which was being done currently.
> >> >> Hence, disabled it and later made sure it's kept at that.
> >> >
> >> >Who is turning it back on and why?
> >>
> >> When we call disable from IGT, it passes a NULL LUT. In this case,
> >> default linear LUT is getting applied in kernel. I am not sure if we
> >> really disable the gamma/degamma fully in driver. It just works with linear values
> >and remains enabled.
> >
> >We would disable after https://patchwork.freedesktop.org/series/58137/
> >
> >Hmm. Looks like one patch missing r-b. I should probably go respin that with Matt's
> >comment added.
> 
> Ok sure, will re-test the patch once your change is merged and update the test. Thanks.

Merged now. Though on GLK the kernel still has to load a linear
degamma ramp whenever the csc is used since the two are
enabled/disabled by the same bit.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Shankar, Uma]

>-----Original Message-----
>From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>Sent: Friday, March 29, 2019 1:09 AM
>To: Shankar, Uma <uma.shankar@intel.com>
>Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@intel.com>; Lankhorst,
>Maarten <maarten.lankhorst@intel.com>
>Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test
>
>On Wed, Mar 27, 2019 at 01:37:31PM +0000, Shankar, Uma wrote:
>>
>>
>> >-----Original Message-----
>> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>> >Sent: Wednesday, March 27, 2019 5:05 PM
>> >To: Shankar, Uma <uma.shankar@intel.com>
>> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville
>> ><ville.syrjala@intel.com>; Lankhorst, Maarten
>> ><maarten.lankhorst@intel.com>
>> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues
>> >with ctm test
>> >
>> >On Wed, Mar 27, 2019 at 10:52:48AM +0000, Shankar, Uma wrote:
>> >>
>> >>
>> >> >On Wed, Mar 27, 2019 at 06:20:10AM +0000, Shankar, Uma wrote:
>> >> >>
>> >> >>
>> >> >> >-----Original Message-----
>> >> >> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>> >> >> >Sent: Tuesday, March 26, 2019 10:16 PM
>> >> >> >To: Shankar, Uma <uma.shankar@intel.com>
>> >> >> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville
>> >> >> ><ville.syrjala@intel.com>; Lankhorst, Maarten
>> >> >> ><maarten.lankhorst@intel.com>
>> >> >> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch
>> >> >> >issues with ctm test
>> >> >> >
>> >> >> >On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
>> >> >> >>
>> >> >> >>
>> >> >> >> >-----Original Message-----
>> >> >> >> >From: Shankar, Uma
>> >> >> >> >Sent: Monday, March 25, 2019 2:11 PM
>> >> >> >> >To: igt-dev@lists.freedesktop.org
>> >> >> >> >Cc: Shankar, Uma <uma.shankar@intel.com>
>> >> >> >> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with
>> >> >> >> >ctm test
>> >> >> >> >
>> >> >> >> >Due to Gamma/Degamma limitation with precision (lack of
>> >> >> >> >exact
>> >> >> >> >1.0
>> >> >> >> >representation) due to ABI restriction, applying linear
>> >> >> >> >gamma affects crc. This patch fixes the same by making ctm
>> >> >> >> >tests independant of
>> >> >> >gamma/degamma.
>> >> >> >> >
>> >> >> >> >v2: Disable degamma/gamma programming for ctm max test as it
>> >> >> >> >leads to crc mimsmatch. Limiting it to this test case alone
>> >> >> >> >as other tests need it to be enabled, hence not touching those scenarios.
>> >> >> >> >
>> >> >> >> >v3: Fixed a fumble with compilation.
>> >> >> >>
>> >> >> >> Hi Ville,
>> >> >> >> Can I keep your RB on this version. We have a clean CI result available
>now.
>> >> >> >
>> >> >> >I'm confused. Why didn't disabling degamma+gamma work?
>> >> >>
>> >> >> We need to disable degamma/gamma and also make sure we don't set
>> >> >> them again with linear values, which was being done currently.
>> >> >> Hence, disabled it and later made sure it's kept at that.
>> >> >
>> >> >Who is turning it back on and why?
>> >>
>> >> When we call disable from IGT, it passes a NULL LUT. In this case,
>> >> default linear LUT is getting applied in kernel. I am not sure if
>> >> we really disable the gamma/degamma fully in driver. It just works
>> >> with linear values
>> >and remains enabled.
>> >
>> >We would disable after
>> >https://patchwork.freedesktop.org/series/58137/
>> >
>> >Hmm. Looks like one patch missing r-b. I should probably go respin
>> >that with Matt's comment added.
>>
>> Ok sure, will re-test the patch once your change is merged and update the test.
>Thanks.
>
>Merged now. Though on GLK the kernel still has to load a linear degamma ramp
>whenever the csc is used since the two are enabled/disabled by the same bit.

Thanks Ville. Will re-try the test and get back.

Regards,
Uma Shankar

>--
>Ville Syrjälä
>Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues with ctm test

[Shankar, Uma]

>>>
>>> >-----Original Message-----
>>> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>>> >Sent: Wednesday, March 27, 2019 5:05 PM
>>> >To: Shankar, Uma <uma.shankar@intel.com>
>>> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville
>>> ><ville.syrjala@intel.com>; Lankhorst, Maarten
>>> ><maarten.lankhorst@intel.com>
>>> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch issues
>>> >with ctm test
>>> >
>>> >On Wed, Mar 27, 2019 at 10:52:48AM +0000, Shankar, Uma wrote:
>>> >>
>>> >>
>>> >> >On Wed, Mar 27, 2019 at 06:20:10AM +0000, Shankar, Uma wrote:
>>> >> >>
>>> >> >>
>>> >> >> >-----Original Message-----
>>> >> >> >From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
>>> >> >> >Sent: Tuesday, March 26, 2019 10:16 PM
>>> >> >> >To: Shankar, Uma <uma.shankar@intel.com>
>>> >> >> >Cc: igt-dev@lists.freedesktop.org; Syrjala, Ville
>>> >> >> ><ville.syrjala@intel.com>; Lankhorst, Maarten
>>> >> >> ><maarten.lankhorst@intel.com>
>>> >> >> >Subject: Re: [igt-dev] [v3] tests/kms_color: Fix CRC mismatch
>>> >> >> >issues with ctm test
>>> >> >> >
>>> >> >> >On Tue, Mar 26, 2019 at 10:31:01AM +0000, Shankar, Uma wrote:
>>> >> >> >>
>>> >> >> >>
>>> >> >> >> >-----Original Message-----
>>> >> >> >> >From: Shankar, Uma
>>> >> >> >> >Sent: Monday, March 25, 2019 2:11 PM
>>> >> >> >> >To: igt-dev@lists.freedesktop.org
>>> >> >> >> >Cc: Shankar, Uma <uma.shankar@intel.com>
>>> >> >> >> >Subject: [v3] tests/kms_color: Fix CRC mismatch issues with
>>> >> >> >> >ctm test
>>> >> >> >> >
>>> >> >> >> >Due to Gamma/Degamma limitation with precision (lack of
>>> >> >> >> >exact
>>> >> >> >> >1.0
>>> >> >> >> >representation) due to ABI restriction, applying linear
>>> >> >> >> >gamma affects crc. This patch fixes the same by making ctm
>>> >> >> >> >tests independant of
>>> >> >> >gamma/degamma.
>>> >> >> >> >
>>> >> >> >> >v2: Disable degamma/gamma programming for ctm max test as
>>> >> >> >> >it leads to crc mimsmatch. Limiting it to this test case
>>> >> >> >> >alone as other tests need it to be enabled, hence not touching those
>scenarios.
>>> >> >> >> >
>>> >> >> >> >v3: Fixed a fumble with compilation.
>>> >> >> >>
>>> >> >> >> Hi Ville,
>>> >> >> >> Can I keep your RB on this version. We have a clean CI
>>> >> >> >> result available
>>now.
>>> >> >> >
>>> >> >> >I'm confused. Why didn't disabling degamma+gamma work?
>>> >> >>
>>> >> >> We need to disable degamma/gamma and also make sure we don't
>>> >> >> set them again with linear values, which was being done currently.
>>> >> >> Hence, disabled it and later made sure it's kept at that.
>>> >> >
>>> >> >Who is turning it back on and why?
>>> >>
>>> >> When we call disable from IGT, it passes a NULL LUT. In this case,
>>> >> default linear LUT is getting applied in kernel. I am not sure if
>>> >> we really disable the gamma/degamma fully in driver. It just works
>>> >> with linear values
>>> >and remains enabled.
>>> >
>>> >We would disable after
>>> >https://patchwork.freedesktop.org/series/58137/
>>> >
>>> >Hmm. Looks like one patch missing r-b. I should probably go respin
>>> >that with Matt's comment added.
>>>
>>> Ok sure, will re-test the patch once your change is merged and update the test.
>>Thanks.
>>
>>Merged now. Though on GLK the kernel still has to load a linear degamma
>>ramp whenever the csc is used since the two are enabled/disabled by the same bit.
>
>Thanks Ville. Will re-try the test and get back.

I have tested and it seems just disabling gamma/degamma is enough after your recent changes.
I will update the test and float the next revised version.

>Regards,
>Uma Shankar
>
>>--
>>Ville Syrjälä
>>Intel
>_______________________________________________
>igt-dev mailing list
>igt-dev@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev