* [U-Boot] [V5 3/3] sunxi: Use clrsetbits_le32 instead of multiple instruction
@ 2019-03-25 11:27 Shyam Saini
0 siblings, 0 replies; only message in thread
From: Shyam Saini @ 2019-03-25 11:27 UTC (permalink / raw)
To: u-boot
From: Michael Trimarchi <michael@amarulasolutions.com>
This will improve code readabilty
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Shyam Saini <shyam.saini@amarulasolutions.com>
---
Changelogs:
V1->V2: none
V2->V3: Fix use of clrsetbits_le32 and setbits_le32 functions
V3->V4: Rebase to original series's patch 2 and 3
v4->V5 Use correct clear bit function
---
arch/arm/mach-sunxi/dram_sun8i_a33.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-sunxi/dram_sun8i_a33.c b/arch/arm/mach-sunxi/dram_sun8i_a33.c
index 63e18f17d0..c159f55c11 100644
--- a/arch/arm/mach-sunxi/dram_sun8i_a33.c
+++ b/arch/arm/mach-sunxi/dram_sun8i_a33.c
@@ -145,11 +145,8 @@ static void auto_set_timing_para(struct dram_para *para)
reg_val = (tcksrx << 24) | (tcksre << 16) | (tckesr << 8) | (tcke << 0);
writel(reg_val, &mctl_ctl->dramtmg5);
/* Set two rank timing and exit self-refresh timing */
- reg_val = readl(&mctl_ctl->dramtmg8);
- reg_val &= ~(0xff << 8);
- reg_val &= ~(0xff << 0);
- reg_val |= (0x33 << 8);
- reg_val |= (0x10 << 0);
+ clrbits_le32(&mctl_ctl->dramtmg8, (0xff << 8) | (0xff << 0));
+ setbits_le32(&mctl_ctl->dramtmg8, (0x33 << 8) | (0x10 << 0));
writel(reg_val, &mctl_ctl->dramtmg8);
/* Set phy interface time */
reg_val = (0x2 << 24) | (t_rdata_en << 16) | (0x1 << 8)
--
2.11.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-03-25 11:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 11:27 [U-Boot] [V5 3/3] sunxi: Use clrsetbits_le32 instead of multiple instruction Shyam Saini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.