All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Cc: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot
Date: Mon, 25 Mar 2019 12:58:44 +0100	[thread overview]
Message-ID: <20190325115844.nqiqoesn7slq6vrz@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAEaD8JNsAVCgZYaVY8KVocY1fngs07r+=9Eot9tJ1GE0b8Xuog@mail.gmail.com>

Sadly this patch does not look complete. ./grub-core/lib/gnulib is still
included. And as Colin pointed out missing SOB.

Could you send the patches in the email body instead of the attachments?
git send-email?

Daniel


  parent reply	other threads:[~2019-03-25 11:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 15:10 [PATCH] POTFILES: Don't include gnulib in grub.pot Vladimir 'phcoder' Serbinenko
2019-03-22 23:46 ` Colin Watson
2019-03-25 11:58 ` Daniel Kiper [this message]
     [not found]   ` <CAEaD8JPviVrSYYO_nS=jRntwWSaS7S2m_SmP=JQcJDjCvWODKw@mail.gmail.com>
2019-03-25 14:24     ` Fwd: " Vladimir 'phcoder' Serbinenko
2019-03-25 17:02       ` Colin Watson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325115844.nqiqoesn7slq6vrz@tomti.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=phcoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.