* [PATCH] POTFILES: Don't include gnulib in grub.pot @ 2019-03-22 15:10 Vladimir 'phcoder' Serbinenko 2019-03-22 23:46 ` Colin Watson 2019-03-25 11:58 ` Daniel Kiper 0 siblings, 2 replies; 5+ messages in thread From: Vladimir 'phcoder' Serbinenko @ 2019-03-22 15:10 UTC (permalink / raw) To: The development of GRUB 2 [-- Attachment #1: Type: text/plain, Size: 42 bytes --] -- Regards Vladimir 'phcoder' Serbinenko [-- Attachment #2: 0001-POTFILES-Don-t-include-gnulib-in-grub.pot.patch --] [-- Type: application/octet-stream, Size: 1355 bytes --] From 9689b39a171657d8a5b3709bc322e85163914c0e Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko <phcoder@gmail.com> Date: Fri, 22 Mar 2019 16:06:18 +0100 Subject: [PATCH 1/2] POTFILES: Don't include gnulib in grub.pot They're translated as a separate project, so we don't want to submit them again. --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index d9df5f9be..93b128d50 100755 --- a/autogen.sh +++ b/autogen.sh @@ -13,7 +13,7 @@ fi export LC_COLLATE=C unset LC_ALL -find . -iname '*.[ch]' ! -ipath './grub-core/lib/libgcrypt-grub/*' ! -ipath './build-aux/*' ! -ipath './grub-core/lib/libgcrypt/src/misc.c' ! -ipath './grub-core/lib/libgcrypt/src/global.c' ! -ipath './grub-core/lib/libgcrypt/src/secmem.c' ! -ipath './util/grub-gen-widthspec.c' ! -ipath './util/grub-gen-asciih.c' |sort > po/POTFILES.in +find . -iname '*.[ch]' ! -ipath './grub-core/lib/libgcrypt-grub/*' ! -ipath './build-aux/*' ! -ipath './grub-core/lib/libgcrypt/src/misc.c' ! -ipath './grub-core/lib/libgcrypt/src/global.c' ! -ipath './grub-core/lib/libgcrypt/src/secmem.c' ! -ipath './util/grub-gen-widthspec.c' ! -ipath './util/grub-gen-asciih.c' ! -ipath './gnulib/*' |sort > po/POTFILES.in find util -iname '*.in' ! -name Makefile.in |sort > po/POTFILES-shell.in echo "Importing unicode..." -- 2.11.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] POTFILES: Don't include gnulib in grub.pot 2019-03-22 15:10 [PATCH] POTFILES: Don't include gnulib in grub.pot Vladimir 'phcoder' Serbinenko @ 2019-03-22 23:46 ` Colin Watson 2019-03-25 11:58 ` Daniel Kiper 1 sibling, 0 replies; 5+ messages in thread From: Colin Watson @ 2019-03-22 23:46 UTC (permalink / raw) To: The development of GNU GRUB (Missing Signed-off-by.) Reviewed-by: Colin Watson <cjwatson@ubuntu.com> -- Colin Watson [cjwatson@ubuntu.com] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] POTFILES: Don't include gnulib in grub.pot 2019-03-22 15:10 [PATCH] POTFILES: Don't include gnulib in grub.pot Vladimir 'phcoder' Serbinenko 2019-03-22 23:46 ` Colin Watson @ 2019-03-25 11:58 ` Daniel Kiper [not found] ` <CAEaD8JPviVrSYYO_nS=jRntwWSaS7S2m_SmP=JQcJDjCvWODKw@mail.gmail.com> 1 sibling, 1 reply; 5+ messages in thread From: Daniel Kiper @ 2019-03-25 11:58 UTC (permalink / raw) To: Vladimir 'phcoder' Serbinenko; +Cc: The development of GRUB 2 Sadly this patch does not look complete. ./grub-core/lib/gnulib is still included. And as Colin pointed out missing SOB. Could you send the patches in the email body instead of the attachments? git send-email? Daniel ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CAEaD8JPviVrSYYO_nS=jRntwWSaS7S2m_SmP=JQcJDjCvWODKw@mail.gmail.com>]
* Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot [not found] ` <CAEaD8JPviVrSYYO_nS=jRntwWSaS7S2m_SmP=JQcJDjCvWODKw@mail.gmail.com> @ 2019-03-25 14:24 ` Vladimir 'phcoder' Serbinenko 2019-03-25 17:02 ` Colin Watson 0 siblings, 1 reply; 5+ messages in thread From: Vladimir 'phcoder' Serbinenko @ 2019-03-25 14:24 UTC (permalink / raw) To: The development of GRUB 2 ---------- Forwarded message --------- From: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com> Date: Mon, Mar 25, 2019 at 3:22 PM Subject: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot To: Daniel Kiper <dkiper@net-space.pl> On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper <dkiper@net-space.pl> wrote: > > Sadly this patch does not look complete. ./grub-core/lib/gnulib is still > included. And as Colin pointed out missing SOB. This directory still exists, at least in my copy. I didn't spend any time figuring out if this is intended or stale. In either case I don't want those file to accidently end up in POTFILES -- Regards Vladimir 'phcoder' Serbinenko -- Regards Vladimir 'phcoder' Serbinenko ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot 2019-03-25 14:24 ` Fwd: " Vladimir 'phcoder' Serbinenko @ 2019-03-25 17:02 ` Colin Watson 0 siblings, 0 replies; 5+ messages in thread From: Colin Watson @ 2019-03-25 17:02 UTC (permalink / raw) To: grub-devel On Mon, Mar 25, 2019 at 03:24:25PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper <dkiper@net-space.pl> wrote: > > Sadly this patch does not look complete. ./grub-core/lib/gnulib is still > > included. And as Colin pointed out missing SOB. > > This directory still exists, at least in my copy. I didn't spend any > time figuring out if this is intended or stale. In either case I don't > want those file to accidently end up in POTFILES grub-core/lib/gnulib/ exists and is supposed to exist; it consists of automatically-maintained copies of the bits of Gnulib that GRUB actually uses, as opposed to the clone of all of Gnulib that lives in the gnulib/ directory. It shouldn't end up in POTFILES; so I think Daniel's point is that you should exclude both gnulib/ and grub-core/lib/gnulib/ in your patch. -- Colin Watson [cjwatson@ubuntu.com] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-25 17:02 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-03-22 15:10 [PATCH] POTFILES: Don't include gnulib in grub.pot Vladimir 'phcoder' Serbinenko 2019-03-22 23:46 ` Colin Watson 2019-03-25 11:58 ` Daniel Kiper [not found] ` <CAEaD8JPviVrSYYO_nS=jRntwWSaS7S2m_SmP=JQcJDjCvWODKw@mail.gmail.com> 2019-03-25 14:24 ` Fwd: " Vladimir 'phcoder' Serbinenko 2019-03-25 17:02 ` Colin Watson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.