Build fails with missing save-cwd.h header

Build fails with missing save-cwd.h header

[John Paul Adrian Glaubitz]

Hi!

I'm currently test-building GRUB on various architectures to make sure it builds
fine when 2.04 is released. Currently, I am always running into an issue with
the "save-cwd.h" header missing:

grub-core/osdep/unix/getroot.c:117:10: fatal error: save-cwd.h: No such file or directory
 #include "save-cwd.h"
          ^~~~~~~~~~~~

I'm building with:

$ make clean && ./autogen.sh && ./configure && make -j16

Before digging through code myself, I was wondering whether I am missing something
obvious, although it looks like we're missing the include path being passed to
the compiler where save-cwd.h is sitting in the source tree.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: Build fails with missing save-cwd.h header

[Daniel Kiper]

On Mon, Mar 25, 2019 at 10:50:30AM +0100, John Paul Adrian Glaubitz wrote:
> Hi!
>
> I'm currently test-building GRUB on various architectures to make sure it builds
> fine when 2.04 is released. Currently, I am always running into an issue with
> the "save-cwd.h" header missing:
>
> grub-core/osdep/unix/getroot.c:117:10: fatal error: save-cwd.h: No such file or directory
>  #include "save-cwd.h"
>           ^~~~~~~~~~~~
>
> I'm building with:
>
> $ make clean && ./autogen.sh && ./configure && make -j16
>
> Before digging through code myself, I was wondering whether I am missing something
> obvious, although it looks like we're missing the include path being passed to
> the compiler where save-cwd.h is sitting in the source tree.

Could you clone clean GRUB git repo and run ./bootstrap instead of ./autogen.sh?

Daniel

Re: Build fails with missing save-cwd.h header

[Colin Watson]

On Mon, Mar 25, 2019 at 12:34:49PM +0100, Daniel Kiper wrote:
> On Mon, Mar 25, 2019 at 10:50:30AM +0100, John Paul Adrian Glaubitz wrote:
> > grub-core/osdep/unix/getroot.c:117:10: fatal error: save-cwd.h: No such file or directory
> >  #include "save-cwd.h"
> >           ^~~~~~~~~~~~
> >
> > I'm building with:
> >
> > $ make clean && ./autogen.sh && ./configure && make -j16
> >
> > Before digging through code myself, I was wondering whether I am missing something
> > obvious, although it looks like we're missing the include path being passed to
> > the compiler where save-cwd.h is sitting in the source tree.
> 
> Could you clone clean GRUB git repo and run ./bootstrap instead of ./autogen.sh?

Right, Adrian, you just need to change your habits to run ./bootstrap
instead of ./autogen.sh as of a few weeks ago.  See:

  https://git.savannah.gnu.org/cgit/grub.git/commit/?id=35b909062e7b334eb4af372be3260d0f62d85375

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

Re: Build fails with missing save-cwd.h header

[John Paul Adrian Glaubitz]

On 3/25/19 12:34 PM, Daniel Kiper wrote:
>> Before digging through code myself, I was wondering whether I am missing something
>> obvious, although it looks like we're missing the include path being passed to
>> the compiler where save-cwd.h is sitting in the source tree.
> 
> Could you clone clean GRUB git repo and run ./bootstrap instead of ./autogen.sh?

Right, for some reason I forgot about that. Builds fine with my patch
on sparc64 on Debian unstable now.

Now for some testing on various PowerPC targets.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913