From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, Jie Yang <yang.jie@linux.intel.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Curtis Malainey <cujomalainey@chromium.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: intel: Fix crash at suspend/resume after failed codec registration
Date: Mon, 25 Mar 2019 15:05:33 +0000 [thread overview]
Message-ID: <20190325150533.GI7284@sirena.org.uk> (raw)
In-Reply-To: <50fafc60-0ee4-ab33-8d24-dfc149215bee@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Mon, Mar 25, 2019 at 07:21:00AM -0700, Guenter Roeck wrote:
> It is actually a bit more complicated than that. The stored pointer (drv->soc_card)
> isn't released. The problem is that dev_get_drvdata(drv->soc_card->dev) is NULL,
> which causes the crash. I don't think there is a UAF involved - I built the
> test image with KASAN enabled and it did not barf at me.
What is a "UAF"?
> Overall the implementation does seem a bit suspicious to me. I don't really
> understand why the platform driver handles suspend/resume for the cards.
> But that may just be my lack of understanding. However, either case, I think the
> Haswell driver (sst-haswell-pcm.c) has a similar problem. I am also not sure if
It's certainly a bit unusual, usually the platform driver would just
deal with suspending itself and the card driver would handle overall
card suspension together with the core.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-25 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 22:39 [PATCH] ASoC: intel: Fix crash at suspend/resume after failed codec registration Guenter Roeck
2019-03-23 13:55 ` [alsa-devel] " Pierre-Louis Bossart
2019-03-23 13:55 ` Pierre-Louis Bossart
2019-03-25 12:12 ` [alsa-devel] " Mark Brown
2019-03-25 13:18 ` Pierre-Louis Bossart
2019-03-25 15:02 ` Mark Brown
2019-03-25 14:21 ` Guenter Roeck
2019-03-25 15:05 ` Mark Brown [this message]
2019-03-25 16:29 ` Guenter Roeck
2019-03-25 12:02 ` Mark Brown
2019-03-25 12:22 ` Applied "ASoC: intel: Fix crash at suspend/resume after failed codec registration" to the asoc tree Mark Brown
2019-03-25 12:22 ` Mark Brown
[not found] ` <20190327140055.8109021773@mail.kernel.org>
2019-03-27 17:08 ` [PATCH] ASoC: intel: Fix crash at suspend/resume after failed codec registration Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325150533.GI7284@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cujomalainey@chromium.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.