From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Jie Yang <yang.jie@linux.intel.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [alsa-devel] [PATCH] ASoC: intel: Fix crash at suspend/resume after failed codec registration
Date: Mon, 25 Mar 2019 09:18:04 -0400 [thread overview]
Message-ID: <b6d2bdc5-d0e8-dee7-52be-fa7f3a36fa9f@linux.intel.com> (raw)
In-Reply-To: <20190325121232.GF7284@sirena.org.uk>
On 3/25/19 8:12 AM, Mark Brown wrote:
> On Sat, Mar 23, 2019 at 09:55:46AM -0400, Pierre-Louis Bossart wrote:
>
>> I'd like to highlight that there is a fundamental flaw in the way the
>> machine drivers are handled. Since we don't have a hook for the machine
>> driver in the BIOS, the DSP driver creates a platform_device which will
>> instantiate the machine driver. When errors happen in the machine driver
>> probe, they are suppressed due to a 'feature' of the device model, so you
>> can end-up with a broken configuration that is still reported as a
>> successful strobe.
>
> These are driver specific issues not device model issues as far as I can
> see? The issue fixed by this as is that you're storing a pointer in the
> ASoC level (not device model level) probe that you don't free when the
> component is unbound, causing you to dereference it later during
> suspend. There is absolutely no problem with the machine driver not
> being guaranteed to bind at the time it's initially registered, that's
> perfectly normal and should cause no problems.
Agree, what I was referring is that if the machine probe and card
registration fails (not just deferred), the parent acpi/pci driver isn't
notified - there is just no means to provide that information and that
leads to all kinds of configuration issues.
next prev parent reply other threads:[~2019-03-25 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 22:39 [PATCH] ASoC: intel: Fix crash at suspend/resume after failed codec registration Guenter Roeck
2019-03-23 13:55 ` [alsa-devel] " Pierre-Louis Bossart
2019-03-23 13:55 ` Pierre-Louis Bossart
2019-03-25 12:12 ` [alsa-devel] " Mark Brown
2019-03-25 13:18 ` Pierre-Louis Bossart [this message]
2019-03-25 15:02 ` Mark Brown
2019-03-25 14:21 ` Guenter Roeck
2019-03-25 15:05 ` Mark Brown
2019-03-25 16:29 ` Guenter Roeck
2019-03-25 12:02 ` Mark Brown
2019-03-25 12:22 ` Applied "ASoC: intel: Fix crash at suspend/resume after failed codec registration" to the asoc tree Mark Brown
2019-03-25 12:22 ` Mark Brown
[not found] ` <20190327140055.8109021773@mail.kernel.org>
2019-03-27 17:08 ` [PATCH] ASoC: intel: Fix crash at suspend/resume after failed codec registration Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6d2bdc5-d0e8-dee7-52be-fa7f3a36fa9f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cujomalainey@chromium.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.