From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
dmaengine@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [v1] Revert "dmaengine: stm32-mdma: Add a check on read_u32_array"
Date: Mon, 25 Mar 2019 20:55:52 +0530 [thread overview]
Message-ID: <20190325152552.GQ5348@vkoul-mobl> (raw)
On 25-03-19, 15:46, Pierre-Yves MORDRET wrote:
Please use the right subsystem name dmaengine, revert is not a subsystem
name!
> This reverts commit 906b40b246b0acb54c4dc97e815cf734761c9820.
This should use the cannonical form for commits commit-sha1: ("title....")
>
> As stated by bindings "st,ahb-addr-masks" is optional.
> The statement inserted by this commit makes this property
> mandatory and prevents MDMA to be probed in case property not present.
>
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
> ---
> drivers/dma/stm32-mdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index 4e0eede..ac0301b 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>
> dmadev->nr_channels = nr_channels;
> dmadev->nr_requests = nr_requests;
> - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> dmadev->ahb_addr_masks,
> count);
> - if (ret)
> - return ret;
> dmadev->nr_ahb_addr_masks = count;
so if st,ahb-addr-masks is not present what value does count contain?
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> --
> 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
dmaengine@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] Revert "dmaengine: stm32-mdma: Add a check on read_u32_array"
Date: Mon, 25 Mar 2019 20:55:52 +0530 [thread overview]
Message-ID: <20190325152552.GQ5348@vkoul-mobl> (raw)
In-Reply-To: <1553525187-13533-1-git-send-email-pierre-yves.mordret@st.com>
On 25-03-19, 15:46, Pierre-Yves MORDRET wrote:
Please use the right subsystem name dmaengine, revert is not a subsystem
name!
> This reverts commit 906b40b246b0acb54c4dc97e815cf734761c9820.
This should use the cannonical form for commits commit-sha1: ("title....")
>
> As stated by bindings "st,ahb-addr-masks" is optional.
> The statement inserted by this commit makes this property
> mandatory and prevents MDMA to be probed in case property not present.
>
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
> ---
> drivers/dma/stm32-mdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index 4e0eede..ac0301b 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>
> dmadev->nr_channels = nr_channels;
> dmadev->nr_requests = nr_requests;
> - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> dmadev->ahb_addr_masks,
> count);
> - if (ret)
> - return ret;
> dmadev->nr_ahb_addr_masks = count;
so if st,ahb-addr-masks is not present what value does count contain?
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> --
> 2.7.4
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
linux-kernel@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
dmaengine@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] Revert "dmaengine: stm32-mdma: Add a check on read_u32_array"
Date: Mon, 25 Mar 2019 20:55:52 +0530 [thread overview]
Message-ID: <20190325152552.GQ5348@vkoul-mobl> (raw)
In-Reply-To: <1553525187-13533-1-git-send-email-pierre-yves.mordret@st.com>
On 25-03-19, 15:46, Pierre-Yves MORDRET wrote:
Please use the right subsystem name dmaengine, revert is not a subsystem
name!
> This reverts commit 906b40b246b0acb54c4dc97e815cf734761c9820.
This should use the cannonical form for commits commit-sha1: ("title....")
>
> As stated by bindings "st,ahb-addr-masks" is optional.
> The statement inserted by this commit makes this property
> mandatory and prevents MDMA to be probed in case property not present.
>
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
> ---
> drivers/dma/stm32-mdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index 4e0eede..ac0301b 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>
> dmadev->nr_channels = nr_channels;
> dmadev->nr_requests = nr_requests;
> - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> dmadev->ahb_addr_masks,
> count);
> - if (ret)
> - return ret;
> dmadev->nr_ahb_addr_masks = count;
so if st,ahb-addr-masks is not present what value does count contain?
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> --
> 2.7.4
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-03-25 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 15:25 Vinod Koul [this message]
2019-03-25 15:25 ` [PATCH v1] Revert "dmaengine: stm32-mdma: Add a check on read_u32_array" Vinod Koul
2019-03-25 15:25 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2019-03-25 16:17 [v1] " Pierre Yves MORDRET
2019-03-25 16:17 ` [PATCH v1] " Pierre Yves MORDRET
2019-03-25 16:17 ` Pierre Yves MORDRET
2019-03-25 14:46 [v1] " Pierre Yves MORDRET
2019-03-25 14:46 ` [PATCH v1] " Pierre-Yves MORDRET
2019-03-25 14:46 ` Pierre-Yves MORDRET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325152552.GQ5348@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.