* [PATCH] staging: tegra-vde: Add comment for the lock declaration
@ 2019-03-25 17:30 Jules Irenge
2019-03-25 19:26 ` Greg KH
2019-03-25 19:26 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Jules Irenge @ 2019-03-25 17:30 UTC (permalink / raw)
To: gregkh; +Cc: mchehab, outreachy-kernel, jules.octave
Add comment for the lock declaration to fix checkpatch warning
Issue found by checkpatch.pl warning:
"CHECK: struct mutex definition without comment".
---
drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c
index a5020dbf6eef..78ad78e03d12 100644
--- a/drivers/staging/media/tegra-vde/tegra-vde.c
+++ b/drivers/staging/media/tegra-vde/tegra-vde.c
@@ -59,7 +59,7 @@ struct tegra_vde {
void __iomem *ppb;
void __iomem *vdma;
void __iomem *frameid;
- struct mutex lock;
+ struct mutex lock; /* generic mutex lock for tegra-vde driver */
struct miscdevice miscdev;
struct reset_control *rst;
struct reset_control *rst_mc;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: tegra-vde: Add comment for the lock declaration
2019-03-25 17:30 [PATCH] staging: tegra-vde: Add comment for the lock declaration Jules Irenge
@ 2019-03-25 19:26 ` Greg KH
2019-03-25 19:26 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-03-25 19:26 UTC (permalink / raw)
To: Jules Irenge; +Cc: mchehab, outreachy-kernel, jules.octave
On Mon, Mar 25, 2019 at 05:30:33PM +0000, Jules Irenge wrote:
> Add comment for the lock declaration to fix checkpatch warning
> Issue found by checkpatch.pl warning:
> "CHECK: struct mutex definition without comment".
> ---
> drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
No signed-off-by?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: tegra-vde: Add comment for the lock declaration
2019-03-25 17:30 [PATCH] staging: tegra-vde: Add comment for the lock declaration Jules Irenge
2019-03-25 19:26 ` Greg KH
@ 2019-03-25 19:26 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-03-25 19:26 UTC (permalink / raw)
To: Jules Irenge; +Cc: mchehab, outreachy-kernel, jules.octave
On Mon, Mar 25, 2019 at 05:30:33PM +0000, Jules Irenge wrote:
> Add comment for the lock declaration to fix checkpatch warning
> Issue found by checkpatch.pl warning:
> "CHECK: struct mutex definition without comment".
> ---
> drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c
> index a5020dbf6eef..78ad78e03d12 100644
> --- a/drivers/staging/media/tegra-vde/tegra-vde.c
> +++ b/drivers/staging/media/tegra-vde/tegra-vde.c
> @@ -59,7 +59,7 @@ struct tegra_vde {
> void __iomem *ppb;
> void __iomem *vdma;
> void __iomem *frameid;
> - struct mutex lock;
> + struct mutex lock; /* generic mutex lock for tegra-vde driver */
Also, we know this is a lock, but what we don't know is _what_ it does :)
You need a much better explaination than this, sorry. I don't recommend
this being a good "first patch" unless you really know this specific
driver's codebase.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-25 20:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 17:30 [PATCH] staging: tegra-vde: Add comment for the lock declaration Jules Irenge
2019-03-25 19:26 ` Greg KH
2019-03-25 19:26 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.