make check fails in coroutine module

make check fails in coroutine module

[Ian Zimmerman]

cc -g3 -ggdb -Wall -Wstrict-prototypes -Wold-style-definition -Wundef -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -DCCAN_STR_DEBUG=1 -I.  -MMD -MP -MFccan/coroutine/coroutine.o.d -MTccan/coroutine/coroutine.o -c ccan/coroutine/coroutine.c -o ccan/coroutine/coroutine.o
tools/ccanlint/ccanlint -s --deps-fail-ignore   ccan/coroutine/ && touch ccan/coroutine/.ok
coroutine: Module's run and api tests pass (tests_pass): FAIL (+0/3)
/home/itz/git/ccan/ccan/coroutine/test/api-2.c:1..10
ok 1 - coroutine_stack_check(stack1, NULL) == stack1
ok 2 - coroutine_stack_size(stack1) == bufsz - COROUTINE_STK_OVERHEAD
ok 3 - coroutine_stack_check(stack2, NULL) == stack2
ok 4 - coroutine_stack_size(stack2) == bufsz - COROUTINE_STK_OVERHEAD
sh: line 1: 24908 Segmentation fault      (core dumped) valgrind -q --leak-check=full --log-fd=3 /tmp/ccanlint-24709.1804289383/api-2 3> /tmp/ccanlint-24709.1804289383/api-2.valgrind-log

... more (use -vv to see them all)
coroutine: Total score: 35/43 FAIL!
make: *** [Makefile:78: ccan/coroutine/.ok] Error 1

Perhaps it is relevant that the configurator check causing the segfault
- as discussed in the other thread - is HAVE_POINTER_SAFE_MAKECONTEXT
which, I believe, is only used by coroutine module.

Platform: x86_64, Fedora 28, gcc 8.3.1, glibc 2.27.  I didn't set any
special build flags or anything.

-- 
Please don't Cc: me privately on mailing lists and Usenet,
if you also post the followup to the list or newsgroup.
To reply privately _only_ on Usenet and on broken lists
which rewrite From, fetch the TXT record for no-use.mooo.com.

Re: make check fails in coroutine module

[David Gibson]

[-- Attachment #1.1: Type: text/plain, Size: 1776 bytes --]

On Sun, Mar 17, 2019 at 03:39:44PM -0700, Ian Zimmerman wrote:
> cc -g3 -ggdb -Wall -Wstrict-prototypes -Wold-style-definition -Wundef -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -DCCAN_STR_DEBUG=1 -I.  -MMD -MP -MFccan/coroutine/coroutine.o.d -MTccan/coroutine/coroutine.o -c ccan/coroutine/coroutine.c -o ccan/coroutine/coroutine.o
> tools/ccanlint/ccanlint -s --deps-fail-ignore   ccan/coroutine/ && touch ccan/coroutine/.ok
> coroutine: Module's run and api tests pass (tests_pass): FAIL (+0/3)
> /home/itz/git/ccan/ccan/coroutine/test/api-2.c:1..10
> ok 1 - coroutine_stack_check(stack1, NULL) == stack1
> ok 2 - coroutine_stack_size(stack1) == bufsz - COROUTINE_STK_OVERHEAD
> ok 3 - coroutine_stack_check(stack2, NULL) == stack2
> ok 4 - coroutine_stack_size(stack2) == bufsz - COROUTINE_STK_OVERHEAD
> sh: line 1: 24908 Segmentation fault      (core dumped) valgrind -q --leak-check=full --log-fd=3 /tmp/ccanlint-24709.1804289383/api-2 3> /tmp/ccanlint-24709.1804289383/api-2.valgrind-log
> 
> ... more (use -vv to see them all)
> coroutine: Total score: 35/43 FAIL!
> make: *** [Makefile:78: ccan/coroutine/.ok] Error 1
> 
> Perhaps it is relevant that the configurator check causing the segfault
> - as discussed in the other thread - is HAVE_POINTER_SAFE_MAKECONTEXT
> which, I believe, is only used by coroutine module.
> 
> Platform: x86_64, Fedora 28, gcc 8.3.1, glibc 2.27.  I didn't set any
> special build flags or anything.

Urgh, yeah, it's broken.  Finding time to debug and fix it is proving
difficult.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan

Re: make check fails in coroutine module

[Ian Zimmerman]

On 2019-03-26 15:31, David Gibson wrote:

> > ... more (use -vv to see them all)
> > coroutine: Total score: 35/43 FAIL!
> > make: *** [Makefile:78: ccan/coroutine/.ok] Error 1
> > 
> > Perhaps it is relevant that the configurator check causing the
> > segfault - as discussed in the other thread - is
> > HAVE_POINTER_SAFE_MAKECONTEXT which, I believe, is only used by
> > coroutine module.

> Urgh, yeah, it's broken.  Finding time to debug and fix it is proving
> difficult.

Ok, I understand that perfectly.  But I'd like to contrbiute to ccan,
and I'll only feel comfortable doing that when I have a clean test suite
to start with.  What would you suggest as a workaround?  Maybe a local
branch with the coroutine module removed?

-- 
Please don't Cc: me privately on mailing lists and Usenet,
if you also post the followup to the list or newsgroup.
To reply privately _only_ on Usenet and on broken lists
which rewrite From, fetch the TXT record for no-use.mooo.com.

Re: make check fails in coroutine module

[David Gibson]

[-- Attachment #1.1: Type: text/plain, Size: 1501 bytes --]

On Tue, Mar 26, 2019 at 12:58:06PM -0700, Ian Zimmerman wrote:
> On 2019-03-26 15:31, David Gibson wrote:
> 
> > > ... more (use -vv to see them all)
> > > coroutine: Total score: 35/43 FAIL!
> > > make: *** [Makefile:78: ccan/coroutine/.ok] Error 1
> > > 
> > > Perhaps it is relevant that the configurator check causing the
> > > segfault - as discussed in the other thread - is
> > > HAVE_POINTER_SAFE_MAKECONTEXT which, I believe, is only used by
> > > coroutine module.
> 
> > Urgh, yeah, it's broken.  Finding time to debug and fix it is proving
> > difficult.
> 
> Ok, I understand that perfectly.  But I'd like to contrbiute to ccan,
> and I'll only feel comfortable doing that when I have a clean test suite
> to start with.  What would you suggest as a workaround?  Maybe a local
> branch with the coroutine module removed?

That would work, assuming you don't want the coroutine module or
anything it relies on.

But, I'm not sure that's the right approach.  ccan isn't really
intended as a monolithic project, each module should be more or less
independent, with the check everything at the top level being just a
convenience.

If you're looking to contribute you can run ccanlint to build and test
a single module (and its dependencies) and that should suffice.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan