All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
	linux-nvme@lists.infradead.org, Yi Zhang <yi.zhang@redhat.com>,
	stable@vger.kernel.org,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH 1/2] nvme: target: fix nvmet_file_init_bvec()
Date: Tue, 26 Mar 2019 08:32:39 +0100	[thread overview]
Message-ID: <20190326073239.GA21571@lst.de> (raw)
In-Reply-To: <20190326021627.GE30669@ming.t460p>

On Tue, Mar 26, 2019 at 10:16:28AM +0800, Ming Lei wrote:
> Also there is the same issue for block device backed target.
> 
> If no one objects, I'd like to take the approach of adjusting segment
> boundary mask.

Just go for the merge of your two patches.  That fixes the issue and
actually makes the code simpler.

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: target: fix nvmet_file_init_bvec()
Date: Tue, 26 Mar 2019 08:32:39 +0100	[thread overview]
Message-ID: <20190326073239.GA21571@lst.de> (raw)
In-Reply-To: <20190326021627.GE30669@ming.t460p>

On Tue, Mar 26, 2019@10:16:28AM +0800, Ming Lei wrote:
> Also there is the same issue for block device backed target.
> 
> If no one objects, I'd like to take the approach of adjusting segment
> boundary mask.

Just go for the merge of your two patches.  That fixes the issue and
actually makes the code simpler.

  reply	other threads:[~2019-03-26  7:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 10:07 [PATCH 0/2] nvme: target: build bvec from sg directly Ming Lei
2019-03-25 10:07 ` [PATCH 1/2] nvme: target: fix nvmet_file_init_bvec() Ming Lei
2019-03-25 10:07   ` Ming Lei
2019-03-25 10:52   ` Christoph Hellwig
2019-03-25 10:52     ` Christoph Hellwig
2019-03-26  1:39     ` Ming Lei
2019-03-26  1:39       ` Ming Lei
2019-03-26  2:03       ` Sagi Grimberg
2019-03-26  2:03         ` Sagi Grimberg
2019-03-26  2:16         ` Ming Lei
2019-03-26  2:16           ` Ming Lei
2019-03-26  7:32           ` Christoph Hellwig [this message]
2019-03-26  7:32             ` Christoph Hellwig
2019-03-27 14:00   ` Sasha Levin
2019-03-25 10:07 ` [PATCH 2/2] nvme: target: build bvec from sg directly Ming Lei
2019-03-25 10:55   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190326073239.GA21571@lst.de \
    --to=hch@lst.de \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.