* [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled
@ 2019-03-25 17:01 Liviu Dudau
2019-03-26 11:08 ` james qian wang (Arm Technology China)
0 siblings, 1 reply; 3+ messages in thread
From: Liviu Dudau @ 2019-03-25 17:01 UTC (permalink / raw)
To: James (Qian) Wang
Cc: Brian Starkey, Daniel Vetter, DRI-devel, LKML, Liviu Dudau
We don't call this function if CONFIG_DEBUG_FS is not defined, but we
should not be compiling it either, as the declaration of the debugfs
core functions is not included.
Reported by the kbuild test robot.
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index b420c6205d6bf..24548b87e1827 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -44,6 +44,7 @@ static const struct file_operations komeda_register_fops = {
.release = single_release,
};
+#ifdef CONFIG_DEBUG_FS
static void komeda_debugfs_init(struct komeda_dev *mdev)
{
if (!debugfs_initialized())
@@ -56,6 +57,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
debugfs_create_file("register", 0444, mdev->debugfs_root,
mdev, &komeda_register_fops);
}
+#endif
static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
{
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled
2019-03-25 17:01 [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled Liviu Dudau
@ 2019-03-26 11:08 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 3+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-03-26 11:08 UTC (permalink / raw)
To: Liviu Dudau; +Cc: Brian Starkey, Daniel Vetter, DRI-devel, LKML, nd
On Mon, Mar 25, 2019 at 05:01:14PM +0000, Liviu Dudau wrote:
> We don't call this function if CONFIG_DEBUG_FS is not defined, but we
> should not be compiling it either, as the declaration of the debugfs
> core functions is not included.
>
> Reported by the kbuild test robot.
>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index b420c6205d6bf..24548b87e1827 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -44,6 +44,7 @@ static const struct file_operations komeda_register_fops = {
> .release = single_release,
> };
>
> +#ifdef CONFIG_DEBUG_FS
> static void komeda_debugfs_init(struct komeda_dev *mdev)
> {
> if (!debugfs_initialized())
> @@ -56,6 +57,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
> debugfs_create_file("register", 0444, mdev->debugfs_root,
> mdev, &komeda_register_fops);
> }
> +#endif
>
> static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
> {
> --
> 2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled
@ 2019-03-26 11:08 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 3+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-03-26 11:08 UTC (permalink / raw)
To: Liviu Dudau; +Cc: DRI-devel, nd, LKML
On Mon, Mar 25, 2019 at 05:01:14PM +0000, Liviu Dudau wrote:
> We don't call this function if CONFIG_DEBUG_FS is not defined, but we
> should not be compiling it either, as the declaration of the debugfs
> core functions is not included.
>
> Reported by the kbuild test robot.
>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index b420c6205d6bf..24548b87e1827 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -44,6 +44,7 @@ static const struct file_operations komeda_register_fops = {
> .release = single_release,
> };
>
> +#ifdef CONFIG_DEBUG_FS
> static void komeda_debugfs_init(struct komeda_dev *mdev)
> {
> if (!debugfs_initialized())
> @@ -56,6 +57,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
> debugfs_create_file("register", 0444, mdev->debugfs_root,
> mdev, &komeda_register_fops);
> }
> +#endif
>
> static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
> {
> --
> 2.21.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-26 11:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 17:01 [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled Liviu Dudau
2019-03-26 11:08 ` james qian wang (Arm Technology China)
2019-03-26 11:08 ` james qian wang (Arm Technology China)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.