All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Sandy Huang <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 17/21] drm/rockchip: Use drm_fb_helper_fill_info
Date: Tue, 26 Mar 2019 14:20:04 +0100	[thread overview]
Message-ID: <20190326132008.11781-17-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190326132008.11781-1-daniel.vetter@ffwll.ch>

This will set an fb name for the first time!

v2: Rebase

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
---
 drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
index 0cbcef88d4d7..30459de66b67 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
@@ -90,12 +90,10 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper,
 		goto out;
 	}
 
-	fbi->par = helper;
 	fbi->fbops = &rockchip_drm_fbdev_ops;
 
 	fb = helper->fb;
-	drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth);
-	drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height);
+	drm_fb_helper_fill_info(fbi, helper, sizes);
 
 	offset = fbi->var.xoffset * bytes_per_pixel;
 	offset += fbi->var.yoffset * fb->pitches[0];
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Sandy Huang <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 17/21] drm/rockchip: Use drm_fb_helper_fill_info
Date: Tue, 26 Mar 2019 14:20:04 +0100	[thread overview]
Message-ID: <20190326132008.11781-17-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190326132008.11781-1-daniel.vetter@ffwll.ch>

This will set an fb name for the first time!

v2: Rebase

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
---
 drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
index 0cbcef88d4d7..30459de66b67 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
@@ -90,12 +90,10 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper,
 		goto out;
 	}
 
-	fbi->par = helper;
 	fbi->fbops = &rockchip_drm_fbdev_ops;
 
 	fb = helper->fb;
-	drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth);
-	drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height);
+	drm_fb_helper_fill_info(fbi, helper, sizes);
 
 	offset = fbi->var.xoffset * bytes_per_pixel;
 	offset += fbi->var.yoffset * fb->pitches[0];
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-03-26 13:20 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 13:19 [PATCH 01/21] drm/fb-helper: Add fill_info() functions Daniel Vetter
2019-03-26 13:19 ` [PATCH 02/21] drm/fb-helper: set fbi->fix.id in fill_info() Daniel Vetter
2019-03-26 13:56   ` Noralf Trønnes
2019-03-26 13:19 ` [PATCH 03/21] drm/fb_helper: set info->par " Daniel Vetter
2019-03-26 13:57   ` Noralf Trønnes
2019-03-26 13:19 ` [PATCH 04/21] drm/amdgpu: Use drm_fb_helper_fill_info Daniel Vetter
2019-03-26 14:04   ` Noralf Trønnes
2019-03-26 13:19 ` [PATCH 05/21] drm/armada: " Daniel Vetter
2019-03-26 14:06   ` Noralf Trønnes
2019-03-26 13:19 ` [PATCH 06/21] drm/ast: " Daniel Vetter
2019-03-26 14:21   ` Noralf Trønnes
2019-03-26 13:19 ` [PATCH 07/21] drm/cirrus: " Daniel Vetter
2019-03-26 14:24   ` Noralf Trønnes
2019-03-26 13:19 ` [PATCH 08/21] drm/exynos: " Daniel Vetter
2019-03-26 13:19   ` Daniel Vetter
2019-03-26 14:27   ` Noralf Trønnes
2019-03-26 14:27     ` Noralf Trønnes
2019-03-27 22:57   ` Inki Dae
2019-03-27 22:57     ` Inki Dae
2019-03-26 13:19 ` [PATCH 09/21] drm/gma500: " Daniel Vetter
2019-03-26 14:31   ` Noralf Trønnes
2019-03-26 13:19 ` [PATCH 10/21] drm/hibmc: " Daniel Vetter
2019-03-26 14:32   ` Noralf Trønnes
2019-03-26 13:19 ` [PATCH 11/21] drm/i915: " Daniel Vetter
2019-03-26 14:34   ` Noralf Trønnes
2019-03-27 11:10   ` Joonas Lahtinen
2019-03-27 11:15     ` Daniel Vetter
2019-03-26 13:19 ` [PATCH 12/21] drm/mga200g: " Daniel Vetter
2019-03-26 14:41   ` Noralf Trønnes
2019-03-26 13:20 ` [PATCH 14/21] drm/nouveau: " Daniel Vetter
2019-03-26 14:47   ` Noralf Trønnes
2019-03-26 13:20 ` [PATCH 15/21] drm/omap: " Daniel Vetter
2019-03-26 14:49   ` Noralf Trønnes
     [not found] ` <20190326132008.11781-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2019-03-26 13:20   ` [PATCH 13/21] drm/bochs: " Daniel Vetter
2019-03-26 14:42     ` Noralf Trønnes
2019-03-26 14:45       ` Noralf Trønnes
2019-03-26 13:20   ` [PATCH 16/21] drm/radeon: " Daniel Vetter
2019-03-26 14:51     ` Noralf Trønnes
2019-03-26 13:20 ` Daniel Vetter [this message]
2019-03-26 13:20   ` [PATCH 17/21] drm/rockchip: " Daniel Vetter
2019-03-26 14:52   ` Noralf Trønnes
2019-03-26 14:52     ` Noralf Trønnes
2019-03-26 13:20 ` [PATCH 18/21] drm/tegra: " Daniel Vetter
2019-03-26 14:53   ` Noralf Trønnes
2019-03-26 14:55   ` Thierry Reding
2019-03-26 13:20 ` [PATCH 19/21] drm/udl: " Daniel Vetter
2019-03-26 14:58   ` Noralf Trønnes
2019-03-26 13:20 ` [PATCH 20/21] drm/vboxvideo: " Daniel Vetter
2019-03-26 14:59   ` Noralf Trønnes
2019-03-26 13:20 ` [PATCH 21/21] drm/fb-helper: Unexport fill_{var,info} Daniel Vetter
2019-03-26 14:34   ` Alex Deucher
2019-03-26 15:01   ` [PATCH 21/21] drm/fb-helper: Unexport fill_{var, info} Noralf Trønnes
2019-03-27  9:13     ` Daniel Vetter
2019-03-26 13:50 ` [PATCH 01/21] drm/fb-helper: Add fill_info() functions Noralf Trønnes
2019-03-26 17:40 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/21] " Patchwork
2019-03-26 17:46 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-03-26 18:19 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-27  1:57 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190326132008.11781-17-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.