* [PATCH] fstests: Don't delete seqres.full file in generic/077
@ 2019-03-26 15:01 Nikolay Borisov
2019-03-26 15:46 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Nikolay Borisov @ 2019-03-26 15:01 UTC (permalink / raw)
To: guaneryu; +Cc: fstests, Nikolay Borisov
When this test finishes there is no 079.full file with output from commands.
Sometimes this information is useful for post mortem so stop deleting the
file upon test completion.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
tests/generic/077 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/generic/077 b/tests/generic/077
index 284e25253c9e..d11b49c6ff15 100755
--- a/tests/generic/077
+++ b/tests/generic/077
@@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
_check_scratch_fs
echo "*** all done"
-rm -f $seqres.full
status=0
exit
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fstests: Don't delete seqres.full file in generic/077
2019-03-26 15:01 [PATCH] fstests: Don't delete seqres.full file in generic/077 Nikolay Borisov
@ 2019-03-26 15:46 ` Darrick J. Wong
2019-03-28 15:40 ` Nikolay Borisov
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2019-03-26 15:46 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: guaneryu, fstests
On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
> When this test finishes there is no 079.full file with output from commands.
"077.full" ?
> Sometimes this information is useful for post mortem so stop deleting the
> file upon test completion.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Looks ok to me otherwise,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/generic/077 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/077 b/tests/generic/077
> index 284e25253c9e..d11b49c6ff15 100755
> --- a/tests/generic/077
> +++ b/tests/generic/077
> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
> _check_scratch_fs
>
> echo "*** all done"
> -rm -f $seqres.full
I had wondered about this myself... :)
--D
> status=0
> exit
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fstests: Don't delete seqres.full file in generic/077
2019-03-26 15:46 ` Darrick J. Wong
@ 2019-03-28 15:40 ` Nikolay Borisov
2019-03-30 8:33 ` Eryu Guan
0 siblings, 1 reply; 4+ messages in thread
From: Nikolay Borisov @ 2019-03-28 15:40 UTC (permalink / raw)
To: guaneryu; +Cc: Darrick J. Wong, fstests
On 26.03.19 г. 17:46 ч., Darrick J. Wong wrote:
> On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
>> When this test finishes there is no 079.full file with output from commands.
>
> "077.full" ?
Eryu, would you fold this when merging or shall I resend?
>
>> Sometimes this information is useful for post mortem so stop deleting the
>> file upon test completion.
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>
> Looks ok to me otherwise,
>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
>> ---
>> tests/generic/077 | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/generic/077 b/tests/generic/077
>> index 284e25253c9e..d11b49c6ff15 100755
>> --- a/tests/generic/077
>> +++ b/tests/generic/077
>> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
>> _check_scratch_fs
>>
>> echo "*** all done"
>> -rm -f $seqres.full
>
> I had wondered about this myself... :)
>
> --D
>
>> status=0
>> exit
>> --
>> 2.7.4
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fstests: Don't delete seqres.full file in generic/077
2019-03-28 15:40 ` Nikolay Borisov
@ 2019-03-30 8:33 ` Eryu Guan
0 siblings, 0 replies; 4+ messages in thread
From: Eryu Guan @ 2019-03-30 8:33 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: Darrick J. Wong, fstests
On Thu, Mar 28, 2019 at 05:40:31PM +0200, Nikolay Borisov wrote:
>
>
> On 26.03.19 г. 17:46 ч., Darrick J. Wong wrote:
> > On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
> >> When this test finishes there is no 079.full file with output from commands.
> >
> > "077.full" ?
>
> Eryu, would you fold this when merging or shall I resend?
I'll fix it on merge, thanks!
Eryu
>
> >
> >> Sometimes this information is useful for post mortem so stop deleting the
> >> file upon test completion.
> >>
> >> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> >
> > Looks ok to me otherwise,
> >
> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> >
> >> ---
> >> tests/generic/077 | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/tests/generic/077 b/tests/generic/077
> >> index 284e25253c9e..d11b49c6ff15 100755
> >> --- a/tests/generic/077
> >> +++ b/tests/generic/077
> >> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
> >> _check_scratch_fs
> >>
> >> echo "*** all done"
> >> -rm -f $seqres.full
> >
> > I had wondered about this myself... :)
> >
> > --D
> >
> >> status=0
> >> exit
> >> --
> >> 2.7.4
> >>
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-30 8:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-26 15:01 [PATCH] fstests: Don't delete seqres.full file in generic/077 Nikolay Borisov
2019-03-26 15:46 ` Darrick J. Wong
2019-03-28 15:40 ` Nikolay Borisov
2019-03-30 8:33 ` Eryu Guan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.