All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] dpaa2-eth: use netif_receive_skb_list
@ 2019-03-25 13:42 Ioana Ciornei
  2019-03-26 14:43 ` Jesper Dangaard Brouer
  2019-03-26 18:47 ` David Miller
  0 siblings, 2 replies; 6+ messages in thread
From: Ioana Ciornei @ 2019-03-25 13:42 UTC (permalink / raw)
  To: davem; +Cc: netdev, Ioana Ciocoi Radulescu, Ioana Ciornei

Take advantage of the software Rx batching by using
netif_receive_skb_list instead of napi_gro_receive.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 8 +++++++-
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 1 +
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index 2ba49e9..e923e5c 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -435,7 +435,7 @@ static void dpaa2_eth_rx(struct dpaa2_eth_priv *priv,
 	percpu_stats->rx_packets++;
 	percpu_stats->rx_bytes += dpaa2_fd_get_len(fd);
 
-	napi_gro_receive(&ch->napi, skb);
+	list_add_tail(&skb->list, ch->rx_list);
 
 	return;
 
@@ -1108,12 +1108,16 @@ static int dpaa2_eth_poll(struct napi_struct *napi, int budget)
 	struct dpaa2_eth_fq *fq, *txc_fq = NULL;
 	struct netdev_queue *nq;
 	int store_cleaned, work_done;
+	struct list_head rx_list;
 	int err;
 
 	ch = container_of(napi, struct dpaa2_eth_channel, napi);
 	ch->xdp.res = 0;
 	priv = ch->priv;
 
+	INIT_LIST_HEAD(&rx_list);
+	ch->rx_list = &rx_list;
+
 	do {
 		err = pull_channel(ch);
 		if (unlikely(err))
@@ -1157,6 +1161,8 @@ static int dpaa2_eth_poll(struct napi_struct *napi, int budget)
 	work_done = max(rx_cleaned, 1);
 
 out:
+	netif_receive_skb_list(ch->rx_list);
+
 	if (txc_fq && txc_fq->dq_frames) {
 		nq = netdev_get_tx_queue(priv->net_dev, txc_fq->flowid);
 		netdev_tx_completed_queue(nq, txc_fq->dq_frames,
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
index 7879622..a11ebfd 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
@@ -334,6 +334,7 @@ struct dpaa2_eth_channel {
 	struct dpaa2_eth_ch_stats stats;
 	struct dpaa2_eth_ch_xdp xdp;
 	struct xdp_rxq_info xdp_rxq;
+	struct list_head *rx_list;
 };
 
 struct dpaa2_eth_dist_fields {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list
  2019-03-25 13:42 [PATCH net-next] dpaa2-eth: use netif_receive_skb_list Ioana Ciornei
@ 2019-03-26 14:43 ` Jesper Dangaard Brouer
  2019-03-26 14:54   ` Eric Dumazet
  2019-03-27 12:02   ` Edward Cree
  2019-03-26 18:47 ` David Miller
  1 sibling, 2 replies; 6+ messages in thread
From: Jesper Dangaard Brouer @ 2019-03-26 14:43 UTC (permalink / raw)
  To: Ioana Ciornei
  Cc: brouer, davem, netdev, Ioana Ciocoi Radulescu, Florian Westphal,
	Edward Cree

On Mon, 25 Mar 2019 13:42:39 +0000
Ioana Ciornei <ioana.ciornei@nxp.com> wrote:

> Take advantage of the software Rx batching by using
> netif_receive_skb_list instead of napi_gro_receive.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---

Nice to see more people/drivers using: netif_receive_skb_list()

We should likely add a similar napi_gro_receive_list() function.


>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 8 +++++++-
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 1 +
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> index 2ba49e9..e923e5c 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> @@ -435,7 +435,7 @@ static void dpaa2_eth_rx(struct dpaa2_eth_priv *priv,
>  	percpu_stats->rx_packets++;
>  	percpu_stats->rx_bytes += dpaa2_fd_get_len(fd);
>  
> -	napi_gro_receive(&ch->napi, skb);
> +	list_add_tail(&skb->list, ch->rx_list);
>  
>  	return;
>  
> @@ -1108,12 +1108,16 @@ static int dpaa2_eth_poll(struct napi_struct *napi, int budget)
>  	struct dpaa2_eth_fq *fq, *txc_fq = NULL;
>  	struct netdev_queue *nq;
>  	int store_cleaned, work_done;
> +	struct list_head rx_list;
>  	int err;
>  
>  	ch = container_of(napi, struct dpaa2_eth_channel, napi);
>  	ch->xdp.res = 0;
>  	priv = ch->priv;
>  
> +	INIT_LIST_HEAD(&rx_list);
> +	ch->rx_list = &rx_list;
> +
>  	do {
>  		err = pull_channel(ch);
>  		if (unlikely(err))
> @@ -1157,6 +1161,8 @@ static int dpaa2_eth_poll(struct napi_struct *napi, int budget)
>  	work_done = max(rx_cleaned, 1);
>  
>  out:
> +	netif_receive_skb_list(ch->rx_list);
> +
>  	if (txc_fq && txc_fq->dq_frames) {
>  		nq = netdev_get_tx_queue(priv->net_dev, txc_fq->flowid);
>  		netdev_tx_completed_queue(nq, txc_fq->dq_frames,
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
> index 7879622..a11ebfd 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
> @@ -334,6 +334,7 @@ struct dpaa2_eth_channel {
>  	struct dpaa2_eth_ch_stats stats;
>  	struct dpaa2_eth_ch_xdp xdp;
>  	struct xdp_rxq_info xdp_rxq;
> +	struct list_head *rx_list;
>  };
>  
>  struct dpaa2_eth_dist_fields {



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list
  2019-03-26 14:43 ` Jesper Dangaard Brouer
@ 2019-03-26 14:54   ` Eric Dumazet
  2019-03-27 12:02   ` Edward Cree
  1 sibling, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2019-03-26 14:54 UTC (permalink / raw)
  To: Jesper Dangaard Brouer, Ioana Ciornei
  Cc: davem, netdev, Ioana Ciocoi Radulescu, Florian Westphal, Edward Cree



On 03/26/2019 07:43 AM, Jesper Dangaard Brouer wrote:
> On Mon, 25 Mar 2019 13:42:39 +0000
> Ioana Ciornei <ioana.ciornei@nxp.com> wrote:
> 
>> Take advantage of the software Rx batching by using
>> netif_receive_skb_list instead of napi_gro_receive.
>>
>> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
>> ---
> 
> Nice to see more people/drivers using: netif_receive_skb_list()
> 
> We should likely add a similar napi_gro_receive_list() function.

GRO is essentially processing one frame at a time, and recycling
one sk_buff. (one sk_buff per aggregated train)

Having to allocate one sk_buff per MSS just to provide a list
would likely be slower, as far as GRO is concerned.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list
  2019-03-25 13:42 [PATCH net-next] dpaa2-eth: use netif_receive_skb_list Ioana Ciornei
  2019-03-26 14:43 ` Jesper Dangaard Brouer
@ 2019-03-26 18:47 ` David Miller
  1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2019-03-26 18:47 UTC (permalink / raw)
  To: ioana.ciornei; +Cc: netdev, ruxandra.radulescu

From: Ioana Ciornei <ioana.ciornei@nxp.com>
Date: Mon, 25 Mar 2019 13:42:39 +0000

> Take advantage of the software Rx batching by using
> netif_receive_skb_list instead of napi_gro_receive.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list
  2019-03-26 14:43 ` Jesper Dangaard Brouer
  2019-03-26 14:54   ` Eric Dumazet
@ 2019-03-27 12:02   ` Edward Cree
  2019-03-27 14:20     ` Jesper Dangaard Brouer
  1 sibling, 1 reply; 6+ messages in thread
From: Edward Cree @ 2019-03-27 12:02 UTC (permalink / raw)
  To: Jesper Dangaard Brouer, Ioana Ciornei
  Cc: davem, netdev, Ioana Ciocoi Radulescu, Florian Westphal

On 26/03/2019 14:43, Jesper Dangaard Brouer wrote:
> On Mon, 25 Mar 2019 13:42:39 +0000
> Ioana Ciornei <ioana.ciornei@nxp.com> wrote:
>
>> Take advantage of the software Rx batching by using
>> netif_receive_skb_list instead of napi_gro_receive.
>>
>> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
>> ---
> Nice to see more people/drivers using: netif_receive_skb_list()
>
> We should likely add a similar napi_gro_receive_list() function.
I had a patch series that did that; last posting was v3 back in
November: https://marc.info/?l=linux-netdev&m=154221888012410&w=2
However, Eric raised some issues, also some Mellanox folks privately
reported that using it in their driver regressed performance, and
I've been too busy since to make progress with it.  Since you seem
to be much better than me at perf investigations, Jesper, maybe you
could take over the series?

-Ed

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list
  2019-03-27 12:02   ` Edward Cree
@ 2019-03-27 14:20     ` Jesper Dangaard Brouer
  0 siblings, 0 replies; 6+ messages in thread
From: Jesper Dangaard Brouer @ 2019-03-27 14:20 UTC (permalink / raw)
  To: Edward Cree
  Cc: Ioana Ciornei, davem, netdev, Ioana Ciocoi Radulescu,
	Florian Westphal, brouer, Felix Fietkau

On Wed, 27 Mar 2019 12:02:13 +0000
Edward Cree <ecree@solarflare.com> wrote:

> On 26/03/2019 14:43, Jesper Dangaard Brouer wrote:
> > On Mon, 25 Mar 2019 13:42:39 +0000
> > Ioana Ciornei <ioana.ciornei@nxp.com> wrote:
> >  
> >> Take advantage of the software Rx batching by using
> >> netif_receive_skb_list instead of napi_gro_receive.
> >>
> >> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> >> ---  
> > Nice to see more people/drivers using: netif_receive_skb_list()
> >
> > We should likely add a similar napi_gro_receive_list() function.  
>
> I had a patch series that did that; last posting was v3 back in
> November: https://marc.info/?l=linux-netdev&m=154221888012410&w=2
> However, Eric raised some issues, also some Mellanox folks privately
> reported that using it in their driver regressed performance, and
> I've been too busy since to make progress with it.  Since you seem
> to be much better than me at perf investigations, Jesper, maybe you
> could take over the series?

I'm hoping Florian Westphal might also have some cycles for this?

(We talked about doing this during NetDevConf-0x13, because if we can
make more driver use these SKB-lists, then it makes sense to let
iptables/nftables build a SKB-list of packets to drop, instead of doing
it individually, and then we leverage Felix'es work on bulk free in
kfree_skb_list).

I'm currently coding up use of netif_receive_skb_list() in CPUMAP
redirect.  As this makes is easier for e.g. Florian (and others) to
play with this API, as we no-longer depend on a device driver having
this (although we do depend on XDP_REDIRECT in a driver).

And the trick to get this as faster than GRO (that basically recycle the
same SKB) is to use the slub/kmem_cache bulk API for SKBs.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-27 14:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 13:42 [PATCH net-next] dpaa2-eth: use netif_receive_skb_list Ioana Ciornei
2019-03-26 14:43 ` Jesper Dangaard Brouer
2019-03-26 14:54   ` Eric Dumazet
2019-03-27 12:02   ` Edward Cree
2019-03-27 14:20     ` Jesper Dangaard Brouer
2019-03-26 18:47 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.