* [PATCH lttng-tools v2 2/2] Tests: plan_tests must be called before running tests/skipping
[not found] <20190328210221.27662-1-jonathan.rajotte-julien@efficios.com>
@ 2019-03-28 21:02 ` Jonathan Rajotte
[not found] ` <20190328210221.27662-2-jonathan.rajotte-julien@efficios.com>
1 sibling, 0 replies; 2+ messages in thread
From: Jonathan Rajotte @ 2019-03-28 21:02 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
Otherwise tap parsers can complain that there was no test plan and
report a failure.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
---
tests/regression/tools/notification/test_notification_kernel | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/regression/tools/notification/test_notification_kernel b/tests/regression/tools/notification/test_notification_kernel
index e7368df26..604cc48cf 100755
--- a/tests/regression/tools/notification/test_notification_kernel
+++ b/tests/regression/tools/notification/test_notification_kernel
@@ -107,12 +107,13 @@ function kernel_test
rm -rf ${consumerd_pipe[@]} 2> /dev/null
}
+plan_tests $NUM_TESTS
+
if [ "$(id -u)" == "0" ]; then
validate_lttng_modules_present
kernel_test
else
# Kernel tests are skipped.
- plan_tests $NUM_TESTS
skip 0 "Root access is needed. Skipping all kernel notification tests." $NUM_TESTS
fi
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH lttng-tools v2 2/2] Tests: plan_tests must be called before running tests/skipping
[not found] ` <20190328210221.27662-2-jonathan.rajotte-julien@efficios.com>
@ 2019-03-29 20:27 ` Jonathan Rajotte-Julien
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Rajotte-Julien @ 2019-03-29 20:27 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
Do not consider this patch, it is bogus.
The test plan is already defined inside the notification executable runned in
kernel_test.
Thanks
On Thu, Mar 28, 2019 at 05:02:21PM -0400, Jonathan Rajotte wrote:
> Otherwise tap parsers can complain that there was no test plan and
> report a failure.
>
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
> tests/regression/tools/notification/test_notification_kernel | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/regression/tools/notification/test_notification_kernel b/tests/regression/tools/notification/test_notification_kernel
> index e7368df26..604cc48cf 100755
> --- a/tests/regression/tools/notification/test_notification_kernel
> +++ b/tests/regression/tools/notification/test_notification_kernel
> @@ -107,12 +107,13 @@ function kernel_test
> rm -rf ${consumerd_pipe[@]} 2> /dev/null
> }
>
> +plan_tests $NUM_TESTS
> +
> if [ "$(id -u)" == "0" ]; then
> validate_lttng_modules_present
> kernel_test
> else
> # Kernel tests are skipped.
> - plan_tests $NUM_TESTS
> skip 0 "Root access is needed. Skipping all kernel notification tests." $NUM_TESTS
> fi
>
> --
> 2.17.1
>
--
Jonathan Rajotte-Julien
EfficiOS
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-29 20:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190328210221.27662-1-jonathan.rajotte-julien@efficios.com>
2019-03-28 21:02 ` [PATCH lttng-tools v2 2/2] Tests: plan_tests must be called before running tests/skipping Jonathan Rajotte
[not found] ` <20190328210221.27662-2-jonathan.rajotte-julien@efficios.com>
2019-03-29 20:27 ` Jonathan Rajotte-Julien
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.