* [PATCH] bonding: show full hw address in sysfs for slave entries
@ 2019-03-28 10:29 Konstantin Khorenko
2019-03-29 20:33 ` David Miller
2019-03-29 20:43 ` Jay Vosburgh
0 siblings, 2 replies; 3+ messages in thread
From: Konstantin Khorenko @ 2019-03-28 10:29 UTC (permalink / raw)
To: Jarod Wilson, Jay Vosburgh
Cc: Konstantin Khorenko, netdev, linux-kernel, Veaceslav Falico,
Andy Gospodarek, David S . Miller
Bond expects ethernet hwaddr for its slave, but it can be longer than 6
bytes - infiniband interface for example.
# cat /sys/devices/<skipped>/net/ib0/address
80:00:02:08:fe:80:00:00:00:00:00:00:7c:fe:90:03:00:be:5d:e1
# cat /sys/devices/<skipped>/net/ib0/bonding_slave/perm_hwaddr
80:00:02:08:fe:80
So print full hwaddr in sysfs "bonding_slave/perm_hwaddr" as well.
Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
drivers/net/bonding/bond_sysfs_slave.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/bond_sysfs_slave.c
index 2f120b2ffef0..4985268e2273 100644
--- a/drivers/net/bonding/bond_sysfs_slave.c
+++ b/drivers/net/bonding/bond_sysfs_slave.c
@@ -55,7 +55,9 @@ static SLAVE_ATTR_RO(link_failure_count);
static ssize_t perm_hwaddr_show(struct slave *slave, char *buf)
{
- return sprintf(buf, "%pM\n", slave->perm_hwaddr);
+ return sprintf(buf, "%*phC\n",
+ slave->dev->addr_len,
+ slave->perm_hwaddr);
}
static SLAVE_ATTR_RO(perm_hwaddr);
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bonding: show full hw address in sysfs for slave entries
2019-03-28 10:29 [PATCH] bonding: show full hw address in sysfs for slave entries Konstantin Khorenko
@ 2019-03-29 20:33 ` David Miller
2019-03-29 20:43 ` Jay Vosburgh
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-03-29 20:33 UTC (permalink / raw)
To: khorenko; +Cc: jarod, j.vosburgh, netdev, linux-kernel, vfalico, andy
From: Konstantin Khorenko <khorenko@virtuozzo.com>
Date: Thu, 28 Mar 2019 13:29:21 +0300
> Bond expects ethernet hwaddr for its slave, but it can be longer than 6
> bytes - infiniband interface for example.
>
> # cat /sys/devices/<skipped>/net/ib0/address
> 80:00:02:08:fe:80:00:00:00:00:00:00:7c:fe:90:03:00:be:5d:e1
>
> # cat /sys/devices/<skipped>/net/ib0/bonding_slave/perm_hwaddr
> 80:00:02:08:fe:80
>
> So print full hwaddr in sysfs "bonding_slave/perm_hwaddr" as well.
>
> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bonding: show full hw address in sysfs for slave entries
2019-03-28 10:29 [PATCH] bonding: show full hw address in sysfs for slave entries Konstantin Khorenko
2019-03-29 20:33 ` David Miller
@ 2019-03-29 20:43 ` Jay Vosburgh
1 sibling, 0 replies; 3+ messages in thread
From: Jay Vosburgh @ 2019-03-29 20:43 UTC (permalink / raw)
To: Konstantin Khorenko
Cc: Jarod Wilson, netdev, linux-kernel, Veaceslav Falico,
Andy Gospodarek, David S . Miller
Konstantin Khorenko <khorenko@virtuozzo.com> wrote:
>Bond expects ethernet hwaddr for its slave, but it can be longer than 6
>bytes - infiniband interface for example.
>
> # cat /sys/devices/<skipped>/net/ib0/address
> 80:00:02:08:fe:80:00:00:00:00:00:00:7c:fe:90:03:00:be:5d:e1
>
> # cat /sys/devices/<skipped>/net/ib0/bonding_slave/perm_hwaddr
> 80:00:02:08:fe:80
>
>So print full hwaddr in sysfs "bonding_slave/perm_hwaddr" as well.
>
>Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
>---
> drivers/net/bonding/bond_sysfs_slave.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/bond_sysfs_slave.c
>index 2f120b2ffef0..4985268e2273 100644
>--- a/drivers/net/bonding/bond_sysfs_slave.c
>+++ b/drivers/net/bonding/bond_sysfs_slave.c
>@@ -55,7 +55,9 @@ static SLAVE_ATTR_RO(link_failure_count);
>
> static ssize_t perm_hwaddr_show(struct slave *slave, char *buf)
> {
>- return sprintf(buf, "%pM\n", slave->perm_hwaddr);
>+ return sprintf(buf, "%*phC\n",
>+ slave->dev->addr_len,
>+ slave->perm_hwaddr);
> }
> static SLAVE_ATTR_RO(perm_hwaddr);
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
-J
---
-Jay Vosburgh, jay.vosburgh@canonical.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-01 18:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-28 10:29 [PATCH] bonding: show full hw address in sysfs for slave entries Konstantin Khorenko
2019-03-29 20:33 ` David Miller
2019-03-29 20:43 ` Jay Vosburgh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.