* [PATCH] staging: rtl8192e: Line over 80 characters.
@ 2019-03-27 16:16 Sanjana Sanikommu
2019-03-29 16:06 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sanjana Sanikommu @ 2019-03-27 16:16 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index ae8f44fd4550..389e7406f30b 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -81,7 +81,8 @@ void rtl92e_set_bb_reg(struct net_device *dev, u32 dwRegAddr, u32 dwBitMask,
if (dwBitMask != bMaskDWord) {
OriginalValue = rtl92e_readl(dev, dwRegAddr);
BitShift = _rtl92e_calculate_bit_shift(dwBitMask);
- NewValue = (OriginalValue & ~dwBitMask) | (dwData << BitShift);
+ NewValue = (OriginalValue & ~dwBitMask) |
+ (dwData << BitShift);
rtl92e_writel(dev, dwRegAddr, NewValue);
} else
rtl92e_writel(dev, dwRegAddr, dwData);
@@ -222,7 +223,8 @@ void rtl92e_set_rf_reg(struct net_device *dev, enum rf90_radio_path eRFPath,
Original_Value = _rtl92e_phy_rf_fw_read(dev, eRFPath,
RegAddr);
BitShift = _rtl92e_calculate_bit_shift(BitMask);
- New_Value = (Original_Value & ~BitMask) | (Data << BitShift);
+ New_Value = (Original_Value & ~BitMask) |
+ (Data << BitShift);
_rtl92e_phy_rf_fw_write(dev, eRFPath, RegAddr,
New_Value);
@@ -235,7 +237,8 @@ void rtl92e_set_rf_reg(struct net_device *dev, enum rf90_radio_path eRFPath,
Original_Value = _rtl92e_phy_rf_read(dev, eRFPath,
RegAddr);
BitShift = _rtl92e_calculate_bit_shift(BitMask);
- New_Value = (Original_Value & ~BitMask) | (Data << BitShift);
+ New_Value = (Original_Value & ~BitMask) |
+ (Data << BitShift);
_rtl92e_phy_rf_write(dev, eRFPath, RegAddr, New_Value);
} else
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: Line over 80 characters.
2019-03-27 16:16 [PATCH] staging: rtl8192e: Line over 80 characters Sanjana Sanikommu
@ 2019-03-29 16:06 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-29 16:06 UTC (permalink / raw)
To: Sanjana Sanikommu; +Cc: outreachy-kernel
On Wed, Mar 27, 2019 at 09:46:56PM +0530, Sanjana Sanikommu wrote:
> Fix coding style issues, which solves checkpatch.pl warning:
> "WARNING: line over 80 characters".
>
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> index ae8f44fd4550..389e7406f30b 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> @@ -81,7 +81,8 @@ void rtl92e_set_bb_reg(struct net_device *dev, u32 dwRegAddr, u32 dwBitMask,
> if (dwBitMask != bMaskDWord) {
> OriginalValue = rtl92e_readl(dev, dwRegAddr);
> BitShift = _rtl92e_calculate_bit_shift(dwBitMask);
> - NewValue = (OriginalValue & ~dwBitMask) | (dwData << BitShift);
> + NewValue = (OriginalValue & ~dwBitMask) |
> + (dwData << BitShift);
This should line up with the ( above it. Please fix for all of these.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-29 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-27 16:16 [PATCH] staging: rtl8192e: Line over 80 characters Sanjana Sanikommu
2019-03-29 16:06 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.