Re: [PATCH lttng-tools] tap-driver.sh: flush stdout after each test result

Re: [PATCH lttng-tools] tap-driver.sh: flush stdout after each test result

[Jonathan Rajotte-Julien]

On Thu, Mar 14, 2019 at 11:41:34AM -0400, Michael Jeanson wrote:
> This is useful in a CI system where stdout is fully buffered and you
> look at the console output to see which test is hanging.
> 
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

Acked-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>

> ---
>  config/tap-driver.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/config/tap-driver.sh b/config/tap-driver.sh
> index 32521614..65037ab6 100755
> --- a/config/tap-driver.sh
> +++ b/config/tap-driver.sh
> @@ -275,6 +275,9 @@ function report(result, details)
>      msg = msg " " details
>    # Output on console might be colorized.
>    print decorate_result(result) msg
> +  # Flush stdout after each test result, this is useful when stdout
> +  # is buffered, for example in a CI system.
> +  fflush()
>    # Log the result in the log file too, to help debugging (this is
>    # especially true when said result is a TAP error or "Bail out!").
>    print result msg | "cat >&3";
> -- 
> 2.17.1
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Jonathan Rajotte-Julien
EfficiOS

Re: [PATCH lttng-tools] tap-driver.sh: flush stdout after each test result

[Jérémie Galarneau]

Merged in master, stable-2.11, stable-2.10, and stable-2.9.

Thanks!
Jérémie

On Thu, Mar 14, 2019 at 11:41:34AM -0400, Michael Jeanson wrote:
> This is useful in a CI system where stdout is fully buffered and you
> look at the console output to see which test is hanging.
> 
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> ---
>  config/tap-driver.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/config/tap-driver.sh b/config/tap-driver.sh
> index 32521614..65037ab6 100755
> --- a/config/tap-driver.sh
> +++ b/config/tap-driver.sh
> @@ -275,6 +275,9 @@ function report(result, details)
>      msg = msg " " details
>    # Output on console might be colorized.
>    print decorate_result(result) msg
> +  # Flush stdout after each test result, this is useful when stdout
> +  # is buffered, for example in a CI system.
> +  fflush()
>    # Log the result in the log file too, to help debugging (this is
>    # especially true when said result is a TAP error or "Bail out!").
>    print result msg | "cat >&3";
> -- 
> 2.17.1
> 

[PATCH lttng-tools] tap-driver.sh: flush stdout after each test result

[Michael Jeanson]

This is useful in a CI system where stdout is fully buffered and you
look at the console output to see which test is hanging.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
---
 config/tap-driver.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/config/tap-driver.sh b/config/tap-driver.sh
index 32521614..65037ab6 100755
--- a/config/tap-driver.sh
+++ b/config/tap-driver.sh
@@ -275,6 +275,9 @@ function report(result, details)
     msg = msg " " details
   # Output on console might be colorized.
   print decorate_result(result) msg
+  # Flush stdout after each test result, this is useful when stdout
+  # is buffered, for example in a CI system.
+  fflush()
   # Log the result in the log file too, to help debugging (this is
   # especially true when said result is a TAP error or "Bail out!").
   print result msg | "cat >&3";
-- 
2.17.1