* [PATCH i-g-t] i915/perf_pmu: Idle before measuring idle
@ 2019-03-31 21:09 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2019-03-31 21:09 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Before trying to measure the busyness reporting for the idle state, make
sure the gpu is actually idle and not still running any backgound system
task.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/perf_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 1a08f564b..ef61c4d40 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -264,6 +264,7 @@ single(int gem_fd, const struct intel_execution_engine2 *e, unsigned int flags)
uint64_t val;
int fd;
+ gem_quiescent_gpu(gem_fd);
fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
if (flags & TEST_BUSY)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/perf_pmu: Idle before measuring idle
@ 2019-03-31 21:09 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2019-03-31 21:09 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Tvrtko Ursulin
Before trying to measure the busyness reporting for the idle state, make
sure the gpu is actually idle and not still running any backgound system
task.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/perf_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 1a08f564b..ef61c4d40 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -264,6 +264,7 @@ single(int gem_fd, const struct intel_execution_engine2 *e, unsigned int flags)
uint64_t val;
int fd;
+ gem_quiescent_gpu(gem_fd);
fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
if (flags & TEST_BUSY)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/perf_pmu: Idle before measuring idle
2019-03-31 21:09 ` [igt-dev] " Chris Wilson
(?)
@ 2019-03-31 21:57 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-03-31 21:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/perf_pmu: Idle before measuring idle
URL : https://patchwork.freedesktop.org/series/58798/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5847 -> IGTPW_2745
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58798/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2745 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@i915_selftest@live_hangcheck:
- fi-ilk-650: PASS -> INCOMPLETE [fdo#109723]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]
#### Possible fixes ####
* igt@i915_selftest@live_uncore:
- fi-kbl-8809g: DMESG-FAIL -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#109723]: https://bugs.freedesktop.org/show_bug.cgi?id=109723
Participating hosts (49 -> 38)
------------------------------
Missing (11): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bdw-gvtdvm fi-byt-squawks fi-bsw-cyan fi-whl-u fi-bxt-j4205 fi-icl-u3 fi-skl-lmem fi-bdw-samus
Build changes
-------------
* IGT: IGT_4914 -> IGTPW_2745
CI_DRM_5847: a1e7e8ca746c6b4e6e5103bf722b81adc70064c8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2745: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2745/
IGT_4914: b93309b7823dcbbd2c52adb4ebb98e3cb060f910 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2745/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/perf_pmu: Idle before measuring idle
2019-03-31 21:09 ` [igt-dev] " Chris Wilson
(?)
(?)
@ 2019-03-31 23:18 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-03-31 23:18 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/perf_pmu: Idle before measuring idle
URL : https://patchwork.freedesktop.org/series/58798/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5847_full -> IGTPW_2745_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2745_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2745_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58798/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2745_full:
### IGT changes ###
#### Warnings ####
* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-snb: ( 2 PASS ) -> PASS +36
Known issues
------------
Here are the changes found in IGTPW_2745_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-clear:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@gem_userptr_blits@process-exit-gtt:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +134
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP [fdo#109271]
* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: PASS -> DMESG-WARN [fdo#110222] +1
- shard-snb: PASS -> DMESG-WARN [fdo#110222] +1
- shard-hsw: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-hsw: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#110222] +1
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +42
* igt@kms_chv_cursor_fail@pipe-c-128x128-right-edge:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +12
* igt@kms_concurrent@pipe-e:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +13
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232] +5
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-kbl: PASS -> DMESG-FAIL [fdo#103232] / [fdo#103558] / [fdo#105602]
* igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +115
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +100
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: NOTRUN -> FAIL [fdo#108145] +3
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +14
* igt@kms_setmode@basic:
- shard-apl: NOTRUN -> FAIL [fdo#99912]
- shard-glk: NOTRUN -> FAIL [fdo#99912]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-c:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +3
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6
* igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
- shard-apl: PASS -> FAIL [fdo#104894]
- shard-kbl: PASS -> FAIL [fdo#104894]
* igt@v3d_mmap@mmap-bad-handle:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +56
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-snb: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-kbl: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-glk: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
- shard-apl: FAIL [fdo#104894] -> PASS +2
* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-kbl: FAIL [fdo#104894] -> PASS
* igt@perf@sysctl-defaults:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
#### Warnings ####
* igt@kms_vblank@pipe-c-wait-busy:
- shard-snb: ( 2 SKIP ) [fdo#109271] / [fdo#109278] -> SKIP [fdo#109271] / [fdo#109278] +7
* igt@prime_busy@wait-after-vebox:
- shard-snb: ( 2 SKIP ) [fdo#109271] -> SKIP [fdo#109271] +33
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (8 -> 5)
------------------------------
Missing (3): shard-skl pig-glk-j5005 shard-iclb
Build changes
-------------
* IGT: IGT_4914 -> IGTPW_2745
* Piglit: piglit_4509 -> None
CI_DRM_5847: a1e7e8ca746c6b4e6e5103bf722b81adc70064c8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2745: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2745/
IGT_4914: b93309b7823dcbbd2c52adb4ebb98e3cb060f910 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2745/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf_pmu: Idle before measuring idle
2019-03-31 21:09 ` [igt-dev] " Chris Wilson
@ 2019-04-01 8:15 ` Tvrtko Ursulin
-1 siblings, 0 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2019-04-01 8:15 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 31/03/2019 22:09, Chris Wilson wrote:
> Before trying to measure the busyness reporting for the idle state, make
> sure the gpu is actually idle and not still running any backgound system
> task.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tests/perf_pmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 1a08f564b..ef61c4d40 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -264,6 +264,7 @@ single(int gem_fd, const struct intel_execution_engine2 *e, unsigned int flags)
> uint64_t val;
> int fd;
>
> + gem_quiescent_gpu(gem_fd);
> fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
>
> if (flags & TEST_BUSY)
>
It's okay but where did it fail? Because subtest has quiescent at the
end, and IGT has it at start.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf_pmu: Idle before measuring idle
@ 2019-04-01 8:15 ` Tvrtko Ursulin
0 siblings, 0 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2019-04-01 8:15 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev, Tvrtko Ursulin
On 31/03/2019 22:09, Chris Wilson wrote:
> Before trying to measure the busyness reporting for the idle state, make
> sure the gpu is actually idle and not still running any backgound system
> task.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tests/perf_pmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 1a08f564b..ef61c4d40 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -264,6 +264,7 @@ single(int gem_fd, const struct intel_execution_engine2 *e, unsigned int flags)
> uint64_t val;
> int fd;
>
> + gem_quiescent_gpu(gem_fd);
> fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
>
> if (flags & TEST_BUSY)
>
It's okay but where did it fail? Because subtest has quiescent at the
end, and IGT has it at start.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf_pmu: Idle before measuring idle
2019-04-01 8:15 ` Tvrtko Ursulin
@ 2019-04-01 8:45 ` Chris Wilson
-1 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2019-04-01 8:45 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev
Quoting Tvrtko Ursulin (2019-04-01 09:15:18)
>
> On 31/03/2019 22:09, Chris Wilson wrote:
> > Before trying to measure the busyness reporting for the idle state, make
> > sure the gpu is actually idle and not still running any backgound system
> > task.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > tests/perf_pmu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> > index 1a08f564b..ef61c4d40 100644
> > --- a/tests/perf_pmu.c
> > +++ b/tests/perf_pmu.c
> > @@ -264,6 +264,7 @@ single(int gem_fd, const struct intel_execution_engine2 *e, unsigned int flags)
> > uint64_t val;
> > int fd;
> >
> > + gem_quiescent_gpu(gem_fd);
> > fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
> >
> > if (flags & TEST_BUSY)
> >
>
> It's okay but where did it fail? Because subtest has quiescent at the
> end, and IGT has it at start.
Honestly, not sure. I suspect it was just another idle worker. Other
than the selftest who's mission it is to detect such errors, this might
be the only test that is sensitive to stray requests being run in the
background. So it might be just shooting the canary.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf_pmu: Idle before measuring idle
@ 2019-04-01 8:45 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2019-04-01 8:45 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev, Tvrtko Ursulin
Quoting Tvrtko Ursulin (2019-04-01 09:15:18)
>
> On 31/03/2019 22:09, Chris Wilson wrote:
> > Before trying to measure the busyness reporting for the idle state, make
> > sure the gpu is actually idle and not still running any backgound system
> > task.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > tests/perf_pmu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> > index 1a08f564b..ef61c4d40 100644
> > --- a/tests/perf_pmu.c
> > +++ b/tests/perf_pmu.c
> > @@ -264,6 +264,7 @@ single(int gem_fd, const struct intel_execution_engine2 *e, unsigned int flags)
> > uint64_t val;
> > int fd;
> >
> > + gem_quiescent_gpu(gem_fd);
> > fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
> >
> > if (flags & TEST_BUSY)
> >
>
> It's okay but where did it fail? Because subtest has quiescent at the
> end, and IGT has it at start.
Honestly, not sure. I suspect it was just another idle worker. Other
than the selftest who's mission it is to detect such errors, this might
be the only test that is sensitive to stray requests being run in the
background. So it might be just shooting the canary.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-01 8:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-31 21:09 [PATCH i-g-t] i915/perf_pmu: Idle before measuring idle Chris Wilson
2019-03-31 21:09 ` [igt-dev] " Chris Wilson
2019-03-31 21:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-31 23:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-01 8:15 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2019-04-01 8:15 ` Tvrtko Ursulin
2019-04-01 8:45 ` Chris Wilson
2019-04-01 8:45 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.