Re: [Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry

Re: [Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

On Sun, Mar 31, 2019 at 11:39:17AM +0300, n.alekseev2104@gmail.com wrote:
> From: nickaleks <n.alekseev2104@gmail.com>

Hi Nikita,
Thanks for the patch!  Do you want to adjust your email From field
("nickaleks") so it matches your full name and Signed-off-by ("Nikita
Alekseev")?

Stefan

> 
> bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function.
> Thus, it also needs to be marked as a coroutine.
> 
> Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
> ---
>  block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block.c b/block.c
> index 0a93ee9ac8..776c43f177 100644
> --- a/block.c
> +++ b/block.c
> @@ -4121,7 +4121,7 @@ typedef struct CheckCo {
>      int ret;
>  } CheckCo;
>  
> -static void bdrv_check_co_entry(void *opaque)
> +static void coroutine_fn bdrv_check_co_entry(void *opaque)
>  {
>      CheckCo *cco = opaque;
>      cco->ret = bdrv_co_check(cco->bs, cco->res, cco->fix);
> -- 
> 2.21.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry

[Nikita]

On 01.04.2019 12:15, Stefan Hajnoczi wrote:
> On Sun, Mar 31, 2019 at 11:39:17AM +0300, n.alekseev2104@gmail.com wrote:
>> From: nickaleks <n.alekseev2104@gmail.com>
> 
> Hi Nikita,
> Thanks for the patch!  Do you want to adjust your email From field
> ("nickaleks") so it matches your full name and Signed-off-by ("Nikita
> Alekseev")?
> 
> Stefan
> 

Hi, I've sent the same patch again. I have changed the email and added 
[Qemu-devel] to the subject.

Re: [Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

On Mon, Apr 01, 2019 at 12:30:51PM +0300, n.alekseev2104@gmail.com wrote:
> From: Nikita Alekseev <n.alekseev2104@gmail.com>
> 
> bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function.
> Thus, it also needs to be marked as a coroutine.
> 
> Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
> ---
>  block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thank you!  I prefixed the commit message with "block: ".  Most commits
have a subsystem prefix to make browsing/searching git log easier.  In
the future you can add it yourself - look at git log for a file to
discover what prefix other people recently used.

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry

[n.alekseev2104]

From: Nikita Alekseev <n.alekseev2104@gmail.com>

bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function.
Thus, it also needs to be marked as a coroutine.

Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
---
 block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index 0a93ee9ac8..776c43f177 100644
--- a/block.c
+++ b/block.c
@@ -4121,7 +4121,7 @@ typedef struct CheckCo {
     int ret;
 } CheckCo;
 
-static void bdrv_check_co_entry(void *opaque)
+static void coroutine_fn bdrv_check_co_entry(void *opaque)
 {
     CheckCo *cco = opaque;
     cco->ret = bdrv_co_check(cco->bs, cco->res, cco->fix);
-- 
2.21.0