From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] arm64: compat: Refactor aarch32_alloc_vdso_pages()
Date: Mon, 1 Apr 2019 15:43:56 +0100 [thread overview]
Message-ID: <20190401144355.GI14874@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190401112025.40807-4-vincenzo.frascino@arm.com>
On Mon, Apr 01, 2019 at 12:20:24PM +0100, Vincenzo Frascino wrote:
> +static int __init aarch32_alloc_vdso_pages(void)
> +{
> + return aarch32_alloc_kuser_vdso_page() &
> + aarch32_alloc_sigreturn_vdso_page();
> }
> arch_initcall(aarch32_alloc_vdso_pages);
It probably doesn't matter much but I'd rather not bit-and two error
codes. Just return the non-zero one or pick the first (your choice) if
both are wrong.
(normally, if you want a non-zero random value if any of them failed,
you'd use bit-or)
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 3/4] arm64: compat: Refactor aarch32_alloc_vdso_pages()
Date: Mon, 1 Apr 2019 15:43:56 +0100 [thread overview]
Message-ID: <20190401144355.GI14874@arrakis.emea.arm.com> (raw)
Message-ID: <20190401144356.5aDxi1Z6CJe9d0ZscZLBwCYhv2aff5l0zAx8IP7dFyM@z> (raw)
In-Reply-To: <20190401112025.40807-4-vincenzo.frascino@arm.com>
On Mon, Apr 01, 2019 at 12:20:24PM +0100, Vincenzo Frascino wrote:
> +static int __init aarch32_alloc_vdso_pages(void)
> +{
> + return aarch32_alloc_kuser_vdso_page() &
> + aarch32_alloc_sigreturn_vdso_page();
> }
> arch_initcall(aarch32_alloc_vdso_pages);
It probably doesn't matter much but I'd rather not bit-and two error
codes. Just return the non-zero one or pick the first (your choice) if
both are wrong.
(normally, if you want a non-zero random value if any of them failed,
you'd use bit-or)
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] arm64: compat: Refactor aarch32_alloc_vdso_pages()
Date: Mon, 1 Apr 2019 15:43:56 +0100 [thread overview]
Message-ID: <20190401144355.GI14874@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190401112025.40807-4-vincenzo.frascino@arm.com>
On Mon, Apr 01, 2019 at 12:20:24PM +0100, Vincenzo Frascino wrote:
> +static int __init aarch32_alloc_vdso_pages(void)
> +{
> + return aarch32_alloc_kuser_vdso_page() &
> + aarch32_alloc_sigreturn_vdso_page();
> }
> arch_initcall(aarch32_alloc_vdso_pages);
It probably doesn't matter much but I'd rather not bit-and two error
codes. Just return the non-zero one or pick the first (your choice) if
both are wrong.
(normally, if you want a non-zero random value if any of them failed,
you'd use bit-or)
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-01 14:43 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 11:20 [PATCH 0/4] arm64: compat: Add kuser helpers config option Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 11:20 ` [PATCH 1/4] arm64: compat: Alloc separate pages for vectors and sigpage Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 14:27 ` Catalin Marinas
2019-04-01 14:27 ` Catalin Marinas
2019-04-01 14:27 ` Catalin Marinas
2019-04-02 10:01 ` Vincenzo Frascino
2019-04-02 10:01 ` Vincenzo Frascino
2019-04-02 10:01 ` Vincenzo Frascino
2019-04-02 10:06 ` Catalin Marinas
2019-04-02 10:06 ` Catalin Marinas
2019-04-02 10:06 ` Catalin Marinas
2019-04-02 10:08 ` Vincenzo Frascino
2019-04-02 10:08 ` Vincenzo Frascino
2019-04-02 10:08 ` Vincenzo Frascino
2019-04-01 11:20 ` [PATCH 2/4] arm64: compat: Split kuser32 Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 14:30 ` Catalin Marinas
2019-04-01 14:30 ` Catalin Marinas
2019-04-01 14:30 ` Catalin Marinas
2019-04-02 9:47 ` Vincenzo Frascino
2019-04-02 9:47 ` Vincenzo Frascino
2019-04-02 9:47 ` Vincenzo Frascino
2019-04-01 11:20 ` [PATCH 3/4] arm64: compat: Refactor aarch32_alloc_vdso_pages() Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 14:43 ` Catalin Marinas [this message]
2019-04-01 14:43 ` Catalin Marinas
2019-04-01 14:43 ` Catalin Marinas
2019-04-02 10:06 ` Vincenzo Frascino
2019-04-02 10:06 ` Vincenzo Frascino
2019-04-02 10:06 ` Vincenzo Frascino
2019-04-01 11:20 ` [PATCH 4/4] arm64: compat: Add KUSER_HELPERS config option Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 11:20 ` Vincenzo Frascino
2019-04-01 14:48 ` Catalin Marinas
2019-04-01 14:48 ` Catalin Marinas
2019-04-01 14:48 ` Catalin Marinas
2019-04-02 10:12 ` Vincenzo Frascino
2019-04-02 10:12 ` Vincenzo Frascino
2019-04-02 10:12 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401144355.GI14874@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.