From: Tom Li <tomli@tomli.me>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>,
linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/7] fbdev: sm712fb: add 2D-related I/O headers and functions.
Date: Tue, 2 Apr 2019 00:04:05 +0800 [thread overview]
Message-ID: <20190401160404.GA15736@localhost.localdomain> (raw)
In-Reply-To: <20190331172558.ndvtilm7c2cy6xa4@debian>
On Sun, Mar 31, 2019 at 06:25:58PM +0100, Sudip Mukherjee wrote:
> On Fri, Mar 22, 2019 at 01:17:54PM +0800, Yifeng Li wrote:
> > +#define DE_CTRL_COMMAND_SHIFT 16
> > +#define DE_CTRL_COMMAND_BITBLT 0x00
> > +#define DE_CTRL_COMMAND_SOLIDFILL 0x01
> > +#define DE_CTRL_COMMAND_HOSTWRITE 0x08
> > +#define DE_CTRL_ROP2_SELECT 0x00008000
> > +#define DE_CTRL_ROP2_SRC_IS_PATTERN 0x00004000
> > +#define DE_CTRL_ROP2_SHIFT 0
> > +#define DE_CTRL_ROP2_COPY 0x0c
> > +#define DE_CTRL_HOST_SHIFT 22
> > +#define DE_CTRL_HOST_SRC_IS_MONO 0x01
> > +#define DE_CTRL_FORMAT_XY 0x00
> > +#define DE_CTRL_FORMAT_24BIT 0x30
>
> Please fix the alignment. Some of them are right aligned and some are left.
Noted. It will be fixed in PATCH v3.
Thanks,
Tom Li
WARNING: multiple messages have this Message-ID (diff)
From: Tom Li <tomli@tomli.me>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>,
linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/7] fbdev: sm712fb: add 2D-related I/O headers and functions.
Date: Mon, 01 Apr 2019 16:04:05 +0000 [thread overview]
Message-ID: <20190401160404.GA15736@localhost.localdomain> (raw)
In-Reply-To: <20190331172558.ndvtilm7c2cy6xa4@debian>
On Sun, Mar 31, 2019 at 06:25:58PM +0100, Sudip Mukherjee wrote:
> On Fri, Mar 22, 2019 at 01:17:54PM +0800, Yifeng Li wrote:
> > +#define DE_CTRL_COMMAND_SHIFT 16
> > +#define DE_CTRL_COMMAND_BITBLT 0x00
> > +#define DE_CTRL_COMMAND_SOLIDFILL 0x01
> > +#define DE_CTRL_COMMAND_HOSTWRITE 0x08
> > +#define DE_CTRL_ROP2_SELECT 0x00008000
> > +#define DE_CTRL_ROP2_SRC_IS_PATTERN 0x00004000
> > +#define DE_CTRL_ROP2_SHIFT 0
> > +#define DE_CTRL_ROP2_COPY 0x0c
> > +#define DE_CTRL_HOST_SHIFT 22
> > +#define DE_CTRL_HOST_SRC_IS_MONO 0x01
> > +#define DE_CTRL_FORMAT_XY 0x00
> > +#define DE_CTRL_FORMAT_24BIT 0x30
>
> Please fix the alignment. Some of them are right aligned and some are left.
Noted. It will be fixed in PATCH v3.
Thanks,
Tom Li
next prev parent reply other threads:[~2019-04-01 16:04 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 5:17 [PATCH v2 0/7] implement 2D acceleration, minor cleanups, doc updates Yifeng Li
2019-03-22 5:17 ` Yifeng Li
2019-03-22 5:17 ` [PATCH v2 1/7] fbdev: sm712fb: use type "u8" for 8-bit I/O Yifeng Li
2019-03-22 5:17 ` Yifeng Li
2019-03-31 17:16 ` Sudip Mukherjee
2019-03-31 17:16 ` Sudip Mukherjee
2019-03-31 17:16 ` Sudip Mukherjee
2019-03-22 5:17 ` [PATCH v2 2/7] fbdev: sm712fb: add 2D-related I/O headers and functions Yifeng Li
2019-03-22 5:17 ` Yifeng Li
2019-03-31 17:25 ` Sudip Mukherjee
2019-03-31 17:25 ` Sudip Mukherjee
2019-04-01 16:04 ` Tom Li [this message]
2019-04-01 16:04 ` Tom Li
2019-03-22 5:17 ` [PATCH v2 3/7] fbdev: sm712fb: support 2D acceleration on SM712 w/ Little-Endian CPU Yifeng Li
2019-03-22 5:17 ` Yifeng Li
2019-03-31 18:09 ` Sudip Mukherjee
2019-03-31 18:09 ` Sudip Mukherjee
2019-04-01 16:26 ` Tom Li
2019-04-01 16:26 ` Tom Li
2019-04-02 20:53 ` Sudip Mukherjee
2019-04-02 20:53 ` Sudip Mukherjee
2019-03-22 5:17 ` [PATCH v2 4/7] fbdev: sm712fb: add 32-bit color modes, drops some other modes Yifeng Li
2019-03-22 5:17 ` Yifeng Li
2019-03-31 18:33 ` Sudip Mukherjee
2019-03-31 18:33 ` Sudip Mukherjee
2019-04-01 16:41 ` Tom Li
2019-04-01 16:41 ` Tom Li
2019-04-02 20:59 ` Sudip Mukherjee
2019-04-02 20:59 ` Sudip Mukherjee
2019-03-22 5:17 ` [PATCH v2 5/7] Documentation: fb: sm712fb: add information mainly about 2D Yifeng Li
2019-03-22 5:17 ` Yifeng Li
2019-03-31 18:54 ` Sudip Mukherjee
2019-03-31 18:54 ` Sudip Mukherjee
2019-03-31 18:54 ` Sudip Mukherjee
2019-04-01 17:30 ` Tom Li
2019-04-01 17:30 ` Tom Li
2019-04-02 21:03 ` Sudip Mukherjee
2019-04-02 21:03 ` Sudip Mukherjee
2019-04-02 21:03 ` Sudip Mukherjee
2019-03-22 5:17 ` [PATCH v2 6/7] fbdev: sm712fb: Kconfig: add information about docs Yifeng Li
2019-03-22 5:17 ` Yifeng Li
2019-03-31 19:01 ` Sudip Mukherjee
2019-03-31 19:01 ` Sudip Mukherjee
2019-04-01 17:33 ` Tom Li
2019-04-01 17:33 ` Tom Li
2019-03-22 5:17 ` [PATCH v2 7/7] MAINTAINERS: sm712fb: list myself as one maintainer Yifeng Li
2019-03-22 5:17 ` Yifeng Li
2019-03-31 19:08 ` Sudip Mukherjee
2019-03-31 19:08 ` Sudip Mukherjee
2019-03-31 19:08 ` Sudip Mukherjee
2019-04-01 17:41 ` Tom Li
2019-04-01 17:41 ` Tom Li
2019-04-02 21:09 ` Sudip Mukherjee
2019-04-02 21:09 ` Sudip Mukherjee
2019-04-02 21:09 ` Sudip Mukherjee
2019-04-03 13:53 ` Bartlomiej Zolnierkiewicz
2019-04-03 13:53 ` Bartlomiej Zolnierkiewicz
2019-04-05 22:11 ` Sudip Mukherjee
2019-04-05 22:11 ` Sudip Mukherjee
2019-04-05 22:11 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401160404.GA15736@localhost.localdomain \
--to=tomli@tomli.me \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.