All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Balaji Pothunoori <bpothuno@codeaurora.org>
Cc: johannes@sipsolutions.net, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org,
	Ashok Raj Nagarajan <arnagara@codeaurora.org>
Subject: Re: [PATCH v4 1/3] cfg80211: Add support to set tx power for a station associated
Date: Mon, 1 Apr 2019 16:46:12 -0400	[thread overview]
Message-ID: <20190401204611.GA8910@localhost> (raw)
In-Reply-To: <1553856501-21492-1-git-send-email-bpothuno@codeaurora.org>

Hi Balaji,

I started playing with these patches a bit -- they could be useful for
my use case, but I had a question:

> + * @power: tx power (in dBm) to be used for sending data traffic. If tx power
> + *	is not provided, the default per-interface tx power setting will be
> + *	overriding. Driver should be picking up the lowest tx power, either tx
> + *	power per-interface or per-station.

Should this really dBm?  It's a bit asymmetric for WIPHY_TX_POWER_LEVEL to
use mBm and this to use dBm, and I might want to adjust in half-dB steps if
supported by hardware.  Also allocating an s16 is a bit much for dBm.

-- 
Bob Copeland %% https://bobcopeland.com/

WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: Balaji Pothunoori <bpothuno@codeaurora.org>
Cc: johannes@sipsolutions.net,
	Ashok Raj Nagarajan <arnagara@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v4 1/3] cfg80211: Add support to set tx power for a station associated
Date: Mon, 1 Apr 2019 16:46:12 -0400	[thread overview]
Message-ID: <20190401204611.GA8910@localhost> (raw)
In-Reply-To: <1553856501-21492-1-git-send-email-bpothuno@codeaurora.org>

Hi Balaji,

I started playing with these patches a bit -- they could be useful for
my use case, but I had a question:

> + * @power: tx power (in dBm) to be used for sending data traffic. If tx power
> + *	is not provided, the default per-interface tx power setting will be
> + *	overriding. Driver should be picking up the lowest tx power, either tx
> + *	power per-interface or per-station.

Should this really dBm?  It's a bit asymmetric for WIPHY_TX_POWER_LEVEL to
use mBm and this to use dBm, and I might want to adjust in half-dB steps if
supported by hardware.  Also allocating an s16 is a bit much for dBm.

-- 
Bob Copeland %% https://bobcopeland.com/

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2019-04-01 20:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 10:48 [PATCH v4 1/3] cfg80211: Add support to set tx power for a station associated Balaji Pothunoori
2019-03-29 10:48 ` Balaji Pothunoori
2019-03-31  6:00 ` kbuild test robot
2019-03-31  6:00   ` kbuild test robot
2019-04-01 20:46 ` Bob Copeland [this message]
2019-04-01 20:46   ` Bob Copeland
2019-04-02  6:30   ` Balaji Pothunoori
2019-04-02  6:30     ` Balaji Pothunoori
2019-04-02 12:59     ` Bob Copeland
2019-04-02 12:59       ` Bob Copeland
2019-04-02 13:04       ` Johannes Berg
2019-04-02 13:04         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401204611.GA8910@localhost \
    --to=me@bobcopeland.com \
    --cc=arnagara@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=bpothuno@codeaurora.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.