* [PATCH] staging: rtl8723bs: include: Remove typedef for struct.
@ 2019-04-02 6:27 Sanjana Sanikommu
2019-04-02 6:42 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Sanjana Sanikommu @ 2019-04-02 6:27 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Challenge suggested by coccinelle.
Linux kernel coding style guidelines suggest not using typedefs for
structure.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
drivers/staging/rtl8723bs/include/ieee80211.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 9efb4dcb9d3a..ce523dfb6faf 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -202,7 +202,7 @@ enum NETWORK_TYPE
#define IsSupportedVHT(NetType) (((NetType) & (WIRELESS_11AC)) ? true : false)
-typedef struct ieee_param {
+struct ieee_param {
u32 cmd;
u8 sta_addr[ETH_ALEN];
union {
@@ -240,13 +240,13 @@ typedef struct ieee_param {
u8 buf[0];
} bcn_ie;
} u;
-}ieee_param;
+};
-typedef struct ieee_param_ex {
+struct ieee_param_ex {
u32 cmd;
u8 sta_addr[ETH_ALEN];
u8 data[0];
-}ieee_param_ex;
+};
struct sta_data{
u16 aid;
@@ -870,10 +870,10 @@ static inline int is_zero_mac_addr(const u8 *addr)
#define CFG_IEEE80211_RESERVE_FCS (1<<0)
#define CFG_IEEE80211_COMPUTE_FCS (1<<1)
-typedef struct tx_pending_t{
+struct tx_pending_t {
int frag;
struct ieee80211_txb *txb;
-}tx_pending_t;
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: include: Remove typedef for struct.
2019-04-02 6:27 [PATCH] staging: rtl8723bs: include: Remove typedef for struct Sanjana Sanikommu
@ 2019-04-02 6:42 ` Greg KH
2019-04-02 6:44 ` Sanjana Sanikommu
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-04-02 6:42 UTC (permalink / raw)
To: Sanjana Sanikommu; +Cc: outreachy-kernel
On Tue, Apr 02, 2019 at 11:57:06AM +0530, Sanjana Sanikommu wrote:
> Challenge suggested by coccinelle.
>
> Linux kernel coding style guidelines suggest not using typedefs for
> structure.
>
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/ieee80211.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
> index 9efb4dcb9d3a..ce523dfb6faf 100644
> --- a/drivers/staging/rtl8723bs/include/ieee80211.h
> +++ b/drivers/staging/rtl8723bs/include/ieee80211.h
> @@ -202,7 +202,7 @@ enum NETWORK_TYPE
> #define IsSupportedVHT(NetType) (((NetType) & (WIRELESS_11AC)) ? true : false)
>
>
> -typedef struct ieee_param {
> +struct ieee_param {
> u32 cmd;
> u8 sta_addr[ETH_ALEN];
> union {
> @@ -240,13 +240,13 @@ typedef struct ieee_param {
> u8 buf[0];
> } bcn_ie;
> } u;
> -}ieee_param;
> +};
>
> -typedef struct ieee_param_ex {
> +struct ieee_param_ex {
> u32 cmd;
> u8 sta_addr[ETH_ALEN];
> u8 data[0];
> -}ieee_param_ex;
> +};
>
> struct sta_data{
> u16 aid;
> @@ -870,10 +870,10 @@ static inline int is_zero_mac_addr(const u8 *addr)
> #define CFG_IEEE80211_RESERVE_FCS (1<<0)
> #define CFG_IEEE80211_COMPUTE_FCS (1<<1)
>
> -typedef struct tx_pending_t{
> +struct tx_pending_t {
> int frag;
> struct ieee80211_txb *txb;
> -}tx_pending_t;
> +};
This structure isn't used anywhere, right? So why not just submit a
patch to delete it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: include: Remove typedef for struct.
2019-04-02 6:42 ` Greg KH
@ 2019-04-02 6:44 ` Sanjana Sanikommu
0 siblings, 0 replies; 3+ messages in thread
From: Sanjana Sanikommu @ 2019-04-02 6:44 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1892 bytes --]
On Tue, 2 Apr 2019, 12:12 Greg KH, <gregkh@linuxfoundation.org> wrote:
> On Tue, Apr 02, 2019 at 11:57:06AM +0530, Sanjana Sanikommu wrote:
> > Challenge suggested by coccinelle.
> >
> > Linux kernel coding style guidelines suggest not using typedefs for
> > structure.
> >
> > Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/include/ieee80211.h | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h
> b/drivers/staging/rtl8723bs/include/ieee80211.h
> > index 9efb4dcb9d3a..ce523dfb6faf 100644
> > --- a/drivers/staging/rtl8723bs/include/ieee80211.h
> > +++ b/drivers/staging/rtl8723bs/include/ieee80211.h
> > @@ -202,7 +202,7 @@ enum NETWORK_TYPE
> > #define IsSupportedVHT(NetType) (((NetType) & (WIRELESS_11AC)) ? true :
> false)
> >
> >
> > -typedef struct ieee_param {
> > +struct ieee_param {
> > u32 cmd;
> > u8 sta_addr[ETH_ALEN];
> > union {
> > @@ -240,13 +240,13 @@ typedef struct ieee_param {
> > u8 buf[0];
> > } bcn_ie;
> > } u;
> > -}ieee_param;
> > +};
> >
> > -typedef struct ieee_param_ex {
> > +struct ieee_param_ex {
> > u32 cmd;
> > u8 sta_addr[ETH_ALEN];
> > u8 data[0];
> > -}ieee_param_ex;
> > +};
> >
> > struct sta_data{
> > u16 aid;
> > @@ -870,10 +870,10 @@ static inline int is_zero_mac_addr(const u8 *addr)
> > #define CFG_IEEE80211_RESERVE_FCS (1<<0)
> > #define CFG_IEEE80211_COMPUTE_FCS (1<<1)
> >
> > -typedef struct tx_pending_t{
> > +struct tx_pending_t {
> > int frag;
> > struct ieee80211_txb *txb;
> > -}tx_pending_t;
> > +};
>
> This structure isn't used anywhere, right? So why not just submit a
> patch to delete it?
>
Sure, I will remove and sumbit again :)
Thanks
Sanjana
>
> thanks,
>
> greg k-h
>
[-- Attachment #2: Type: text/html, Size: 3118 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-02 6:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 6:27 [PATCH] staging: rtl8723bs: include: Remove typedef for struct Sanjana Sanikommu
2019-04-02 6:42 ` Greg KH
2019-04-02 6:44 ` Sanjana Sanikommu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.