All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Behun <marek.behun@nic.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [RFC PATCH 5/5] leds: multicolor: Introduce a multicolor class definition
Date: Tue, 2 Apr 2019 07:44:06 +0200	[thread overview]
Message-ID: <20190402074406.0860994a@nic.cz> (raw)
In-Reply-To: <20190401173400.14238-6-dmurphy@ti.com>

Hi Dan,

On Mon, 1 Apr 2019 12:34:00 -0500
Dan Murphy <dmurphy@ti.com> wrote:

> +static ssize_t sync_store(struct device *dev,
> +			  struct device_attribute *sync_attr,
> +			  const char *buf, size_t size)
> +{
> +	struct led_classdev_mc_data *data = container_of(sync_attr,
> +						      struct led_classdev_mc_data,
> +						      sync_attr);
> +	struct led_classdev_mc *mcled_cdev = data->mcled_cdev;
> +	struct led_classdev *led_cdev = &mcled_cdev->led_cdev;
> +	const struct led_multicolor_ops *ops = mcled_cdev->ops;
> +	struct led_classdev_mc_priv *priv;
> +	unsigned long sync_value;
> +	ssize_t ret = -EINVAL;
> +
> +	mutex_lock(&led_cdev->led_access);
> +
> +	if (!mcled_cdev->sync_enabled)
> +		goto unlock;

This lock is redundant, you could just put
  if (mcled_cdev->sync_enabled)
    return ret;
before the lock.

WARNING: multiple messages have this Message-ID (diff)
From: Marek Behun <marek.behun@nic.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>,
	<pavel@ucw.cz>, <linux-kernel@vger.kernel.org>,
	<linux-leds@vger.kernel.org>
Subject: Re: [RFC PATCH 5/5] leds: multicolor: Introduce a multicolor class definition
Date: Tue, 2 Apr 2019 07:44:06 +0200	[thread overview]
Message-ID: <20190402074406.0860994a@nic.cz> (raw)
In-Reply-To: <20190401173400.14238-6-dmurphy@ti.com>

Hi Dan,

On Mon, 1 Apr 2019 12:34:00 -0500
Dan Murphy <dmurphy@ti.com> wrote:

> +static ssize_t sync_store(struct device *dev,
> +			  struct device_attribute *sync_attr,
> +			  const char *buf, size_t size)
> +{
> +	struct led_classdev_mc_data *data = container_of(sync_attr,
> +						      struct led_classdev_mc_data,
> +						      sync_attr);
> +	struct led_classdev_mc *mcled_cdev = data->mcled_cdev;
> +	struct led_classdev *led_cdev = &mcled_cdev->led_cdev;
> +	const struct led_multicolor_ops *ops = mcled_cdev->ops;
> +	struct led_classdev_mc_priv *priv;
> +	unsigned long sync_value;
> +	ssize_t ret = -EINVAL;
> +
> +	mutex_lock(&led_cdev->led_access);
> +
> +	if (!mcled_cdev->sync_enabled)
> +		goto unlock;

This lock is redundant, you could just put
  if (mcled_cdev->sync_enabled)
    return ret;
before the lock.

  parent reply	other threads:[~2019-04-02  5:44 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 17:33 [RFC PATCH 0/5] MultiColor LED framework Documentation Dan Murphy
2019-04-01 17:33 ` Dan Murphy
2019-04-01 17:33 ` [RFC PATCH 1/5] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-04-01 17:33   ` Dan Murphy
2019-04-01 17:33 ` [RFC PATCH 2/5] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-04-01 17:33   ` Dan Murphy
2019-04-01 21:29   ` Pavel Machek
2019-04-02 11:40     ` Dan Murphy
2019-04-02 11:40       ` Dan Murphy
2019-04-02 16:17       ` Marek Behun
2019-04-02 16:17         ` Marek Behun
2019-04-02 17:06         ` Dan Murphy
2019-04-02 20:40       ` Jacek Anaszewski
2019-04-02 19:51     ` Jacek Anaszewski
2019-04-01 17:33 ` [RFC PATCH 3/5] documention: leds: Add multicolor class documentation Dan Murphy
2019-04-01 17:33   ` Dan Murphy
2019-04-01 21:18   ` Randy Dunlap
2019-04-01 21:27   ` Pavel Machek
2019-04-02  5:55     ` Marek Behun
2019-04-02 11:53     ` Dan Murphy
2019-04-02 11:53       ` Dan Murphy
2019-04-02 15:56       ` Marek Behun
2019-04-02 15:56         ` Marek Behun
2019-04-01 17:33 ` [RFC PATCH 4/5] dt-bindings: leds: Add LED_COLOR_ID and COLOR_NAME definitions Dan Murphy
2019-04-01 17:33   ` Dan Murphy
2019-04-01 17:34 ` [RFC PATCH 5/5] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-04-01 17:34   ` Dan Murphy
2019-04-01 21:10   ` Randy Dunlap
2019-04-02 19:07     ` Dan Murphy
2019-04-02 19:07       ` Dan Murphy
2019-04-02  5:44   ` Marek Behun [this message]
2019-04-02  5:44     ` Marek Behun
2019-04-02 11:55     ` Dan Murphy
2019-04-02 11:55       ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402074406.0860994a@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.