* [1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer
@ 2019-04-02 10:39 Jules Maselbas
0 siblings, 0 replies; 5+ messages in thread
From: Jules Maselbas @ 2019-04-02 10:39 UTC (permalink / raw)
To: Minas Harutyunyan
Cc: Greg Kroah-Hartman, Pierre-Yves Kerbrat, linux-usb, Jules Maselbas
Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and
mask defines to improve readability.
Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
drivers/usb/dwc2/hw.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc2/hw.h
index 98af924a9a5c..7dbf392783c4 100644
--- a/drivers/usb/dwc2/hw.h
+++ b/drivers/usb/dwc2/hw.h
@@ -310,12 +310,12 @@
#define GHWCFG4_NUM_DEV_MODE_CTRL_EP_SHIFT 16
#define GHWCFG4_UTMI_PHY_DATA_WIDTH_MASK (0x3 << 14)
#define GHWCFG4_UTMI_PHY_DATA_WIDTH_SHIFT 14
-#define GHWCFG4_ACG_SUPPORTED BIT(12)
-#define GHWCFG4_IPG_ISOC_SUPPORTED BIT(11)
-#define GHWCFG4_SERVICE_INTERVAL_SUPPORTED BIT(10)
#define GHWCFG4_UTMI_PHY_DATA_WIDTH_8 0
#define GHWCFG4_UTMI_PHY_DATA_WIDTH_16 1
#define GHWCFG4_UTMI_PHY_DATA_WIDTH_8_OR_16 2
+#define GHWCFG4_ACG_SUPPORTED BIT(12)
+#define GHWCFG4_IPG_ISOC_SUPPORTED BIT(11)
+#define GHWCFG4_SERVICE_INTERVAL_SUPPORTED BIT(10)
#define GHWCFG4_XHIBER BIT(7)
#define GHWCFG4_HIBER BIT(6)
#define GHWCFG4_MIN_AHB_FREQ BIT(5)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer
@ 2019-04-25 12:52 ` Felipe Balbi
0 siblings, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2019-04-25 12:52 UTC (permalink / raw)
To: Jules Maselbas, Minas Harutyunyan
Cc: Greg Kroah-Hartman, Pierre-Yves Kerbrat, linux-usb
Jules Maselbas <jmaselbas@kalray.eu> writes:
> Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and
> mask defines to improve readability.
>
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
Doesn't apply. Please make sure to rebase on testing/next
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer
@ 2019-04-25 12:52 ` Felipe Balbi
0 siblings, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2019-04-25 12:52 UTC (permalink / raw)
To: Jules Maselbas, Minas Harutyunyan
Cc: Greg Kroah-Hartman, Pierre-Yves Kerbrat, linux-usb, Jules Maselbas
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
Jules Maselbas <jmaselbas@kalray.eu> writes:
> Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and
> mask defines to improve readability.
>
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
Doesn't apply. Please make sure to rebase on testing/next
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer
@ 2019-04-25 15:33 ` Jules Maselbas
0 siblings, 0 replies; 5+ messages in thread
From: Jules Maselbas @ 2019-04-25 15:33 UTC (permalink / raw)
To: Felipe Balbi
Cc: Minas Harutyunyan, Greg Kroah-Hartman, Pierre-Yves Kerbrat, linux-usb
Hi Felipe,
On Thu, Apr 25, 2019 at 03:52:16PM +0300, Felipe Balbi wrote:
> Jules Maselbas <jmaselbas@kalray.eu> writes:
>
> > Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and
> > mask defines to improve readability.
> >
> > Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
>
> Doesn't apply. Please make sure to rebase on testing/next
I've applied this patch serie on v5.1-rc6 and I didn't saw any problems.
I also found that theses patchs are already included in testing/next.
Did I miss something?
Regards,
---
Jules
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer
@ 2019-04-25 15:33 ` Jules Maselbas
0 siblings, 0 replies; 5+ messages in thread
From: Jules Maselbas @ 2019-04-25 15:33 UTC (permalink / raw)
To: Felipe Balbi
Cc: Minas Harutyunyan, Greg Kroah-Hartman, Pierre-Yves Kerbrat, linux-usb
Hi Felipe,
On Thu, Apr 25, 2019 at 03:52:16PM +0300, Felipe Balbi wrote:
> Jules Maselbas <jmaselbas@kalray.eu> writes:
>
> > Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and
> > mask defines to improve readability.
> >
> > Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
>
> Doesn't apply. Please make sure to rebase on testing/next
I've applied this patch serie on v5.1-rc6 and I didn't saw any problems.
I also found that theses patchs are already included in testing/next.
Did I miss something?
Regards,
--
Jules
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-25 15:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 10:39 [1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer Jules Maselbas
2019-04-25 12:52 Felipe Balbi
2019-04-25 12:52 ` [PATCH 1/5] " Felipe Balbi
2019-04-25 15:33 [1/5] " Jules Maselbas
2019-04-25 15:33 ` [PATCH 1/5] " Jules Maselbas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.