* [PATCH v1 1/2] dt-bindings: mmc: sdhci-fujitsu.txt: add miilbeaut driver
@ 2019-03-26 5:53 Takao Orito
2019-03-31 6:42 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Takao Orito @ 2019-03-26 5:53 UTC (permalink / raw)
To: ulf.hansson, robh+dt, mark.rutland
Cc: linux-mmc, devicetree, linux-kernel, masami.hiramatsu,
jaswinder.singh, sugaya.taichi, kasai.kazuhiro, kanematsu.shinji,
orito.takao
Add new compatible description for Milbeaut SoC. Socionext
inherits F_SDH30 IP from Fujitsu. Then new Soc series "Milbeaut"
has F_SDH30 controller specified by "socionext,milbeaut-m10v-sdhci-3.0".
Signed-off-by: Takao Orito <orito.takao@socionext.com>
---
.../devicetree/bindings/mmc/sdhci-fujitsu.txt | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
index 3ee9263..405811f 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
@@ -1,10 +1,10 @@
-* Fujitsu SDHCI controller
+* Fujitsu/Socionext SDHCI controller
This file documents differences between the core properties in mmc.txt
-and the properties used by the sdhci_f_sdh30 driver.
+and the properties used by the sdhci_f_sdh30.
Required properties:
-- compatible: "fujitsu,mb86s70-sdhci-3.0"
+- compatible: "fujitsu,mb86s70-sdhci-3.0", "socionext,milbeaut-m10v-sdhci-3.0"
- clocks: Must contain an entry for each entry in clock-names. It is a
list of phandles and clock-specifier pairs.
See ../clocks/clock-bindings.txt for details.
@@ -17,6 +17,8 @@ Optional properties:
as the VCCQ/VDD_IO supply in the eMMC/SD specs.
- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
requires the CMD_DAT_DELAY control to be enabled.
+- sni,mmc-power-gpio: set property indicating that power on or off needs
+ control of gpio. This is for only "socionext,milbeaut-m10v-sdhci-3.0".
Example:
@@ -30,3 +32,17 @@ Example:
clocks = <&clock 2 2 0>, <&clock 2 3 0>;
clock-names = "iface", "core";
};
+
+Exsample2:
+ sdhci3: mmc@1b010000 {
+ compatible = "socionext,milbeaut-m10v-sdhci-3.0";
+ reg = <0x1b010000 0x10000>;
+ interrupts = <0 265 0x4>;
+ voltage-ranges = <3300 3300>;
+ bus-width = <4>;
+ clocks = <&uhs1clk2>, <&ahb_clk>;
+ clock-names = "core", "iface";
+ cap-sdio-irq;
+ sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
+ fujitsu,cmd-dat-delay-select;
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-fujitsu.txt: add miilbeaut driver
2019-03-26 5:53 [PATCH v1 1/2] dt-bindings: mmc: sdhci-fujitsu.txt: add miilbeaut driver Takao Orito
@ 2019-03-31 6:42 ` Rob Herring
2019-04-02 2:05 ` orito.takao
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2019-03-31 6:42 UTC (permalink / raw)
To: Takao Orito
Cc: ulf.hansson, mark.rutland, linux-mmc, devicetree, linux-kernel,
masami.hiramatsu, jaswinder.singh, sugaya.taichi, kasai.kazuhiro,
kanematsu.shinji
On Tue, Mar 26, 2019 at 02:53:37PM +0900, Takao Orito wrote:
> Add new compatible description for Milbeaut SoC. Socionext
> inherits F_SDH30 IP from Fujitsu. Then new Soc series "Milbeaut"
> has F_SDH30 controller specified by "socionext,milbeaut-m10v-sdhci-3.0".
Subject is wrong, you're not adding a driver.
>
> Signed-off-by: Takao Orito <orito.takao@socionext.com>
> ---
> .../devicetree/bindings/mmc/sdhci-fujitsu.txt | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> index 3ee9263..405811f 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> @@ -1,10 +1,10 @@
> -* Fujitsu SDHCI controller
> +* Fujitsu/Socionext SDHCI controller
>
> This file documents differences between the core properties in mmc.txt
> -and the properties used by the sdhci_f_sdh30 driver.
> +and the properties used by the sdhci_f_sdh30.
>
> Required properties:
> -- compatible: "fujitsu,mb86s70-sdhci-3.0"
> +- compatible: "fujitsu,mb86s70-sdhci-3.0", "socionext,milbeaut-m10v-sdhci-3.0"
One per line please.
> - clocks: Must contain an entry for each entry in clock-names. It is a
> list of phandles and clock-specifier pairs.
> See ../clocks/clock-bindings.txt for details.
> @@ -17,6 +17,8 @@ Optional properties:
> as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> - fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> requires the CMD_DAT_DELAY control to be enabled.
> +- sni,mmc-power-gpio: set property indicating that power on or off needs
> + control of gpio. This is for only "socionext,milbeaut-m10v-sdhci-3.0".
s/-gpio/-gpios/
>
> Example:
>
> @@ -30,3 +32,17 @@ Example:
> clocks = <&clock 2 2 0>, <&clock 2 3 0>;
> clock-names = "iface", "core";
> };
> +
> +Exsample2:
> + sdhci3: mmc@1b010000 {
> + compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> + reg = <0x1b010000 0x10000>;
> + interrupts = <0 265 0x4>;
> + voltage-ranges = <3300 3300>;
> + bus-width = <4>;
> + clocks = <&uhs1clk2>, <&ahb_clk>;
> + clock-names = "core", "iface";
> + cap-sdio-irq;
> + sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
> + fujitsu,cmd-dat-delay-select;
Indentation problem.
> + };
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-fujitsu.txt: add miilbeaut driver
2019-03-31 6:42 ` Rob Herring
@ 2019-04-02 2:05 ` orito.takao
0 siblings, 0 replies; 4+ messages in thread
From: orito.takao @ 2019-04-02 2:05 UTC (permalink / raw)
To: robh
Cc: ulf.hansson, mark.rutland, linux-mmc, devicetree, linux-kernel,
masami.hiramatsu, jaswinder.singh, sugaya.taichi, kasai.kazuhiro,
kanematsu.shinji
Hi
> On Tue, Mar 26, 2019 at 02:53:37PM +0900, Takao Orito wrote:
> > Add new compatible description for Milbeaut SoC. Socionext
> > inherits F_SDH30 IP from Fujitsu. Then new Soc series "Milbeaut"
> > has F_SDH30 controller specified by "socionext,milbeaut-m10v-sdhci-3.0".
>
> Subject is wrong, you're not adding a driver.
OK, I will change "dt-bindings: mmc: sdhci-fujitsu.txt: add milbeaut support"
>
> >
> > Signed-off-by: Takao Orito <orito.takao@socionext.com>
> > ---
> > .../devicetree/bindings/mmc/sdhci-fujitsu.txt | 22 +++++++++++++++++++---
> > 1 file changed, 19 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> > index 3ee9263..405811f 100644
> > --- a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> > @@ -1,10 +1,10 @@
> > -* Fujitsu SDHCI controller
> > +* Fujitsu/Socionext SDHCI controller
> >
> > This file documents differences between the core properties in mmc.txt
> > -and the properties used by the sdhci_f_sdh30 driver.
> > +and the properties used by the sdhci_f_sdh30.
> >
> > Required properties:
> > -- compatible: "fujitsu,mb86s70-sdhci-3.0"
> > +- compatible: "fujitsu,mb86s70-sdhci-3.0", "socionext,milbeaut-m10v-sdhci-3.0"
>
> One per line please.
I see, I will fix.
>
> > - clocks: Must contain an entry for each entry in clock-names. It is a
> > list of phandles and clock-specifier pairs.
> > See ../clocks/clock-bindings.txt for details.
> > @@ -17,6 +17,8 @@ Optional properties:
> > as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> > - fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> > requires the CMD_DAT_DELAY control to be enabled.
> > +- sni,mmc-power-gpio: set property indicating that power on or off needs
> > + control of gpio. This is for only "socionext,milbeaut-m10v-sdhci-3.0".
>
> s/-gpio/-gpios/
I will fix.
>
> >
> > Example:
> >
> > @@ -30,3 +32,17 @@ Example:
> > clocks = <&clock 2 2 0>, <&clock 2 3 0>;
> > clock-names = "iface", "core";
> > };
> > +
> > +Exsample2:
> > + sdhci3: mmc@1b010000 {
> > + compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> > + reg = <0x1b010000 0x10000>;
> > + interrupts = <0 265 0x4>;
> > + voltage-ranges = <3300 3300>;
> > + bus-width = <4>;
> > + clocks = <&uhs1clk2>, <&ahb_clk>;
> > + clock-names = "core", "iface";
> > + cap-sdio-irq;
> > + sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
> > + fujitsu,cmd-dat-delay-select;
>
> Indentation problem.
Sorry, I will fix.
Thank you
Orito
>
> > + };
> > --
> > 1.9.1
> >
> >
--
Takao Orito <orito.takao@socionext.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-fujitsu.txt: add miilbeaut driver
@ 2019-04-02 2:05 ` orito.takao
0 siblings, 0 replies; 4+ messages in thread
From: orito.takao @ 2019-04-02 2:05 UTC (permalink / raw)
To: robh
Cc: ulf.hansson, mark.rutland, linux-mmc, devicetree, linux-kernel,
masami.hiramatsu, jaswinder.singh, sugaya.taichi, kasai.kazuhiro,
kanematsu.shinji
Hi
> On Tue, Mar 26, 2019 at 02:53:37PM +0900, Takao Orito wrote:
> > Add new compatible description for Milbeaut SoC. Socionext
> > inherits F_SDH30 IP from Fujitsu. Then new Soc series "Milbeaut"
> > has F_SDH30 controller specified by "socionext,milbeaut-m10v-sdhci-3.0".
>
> Subject is wrong, you're not adding a driver.
OK, I will change "dt-bindings: mmc: sdhci-fujitsu.txt: add milbeaut support"
>
> >
> > Signed-off-by: Takao Orito <orito.takao@socionext.com>
> > ---
> > .../devicetree/bindings/mmc/sdhci-fujitsu.txt | 22 +++++++++++++++++++---
> > 1 file changed, 19 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> > index 3ee9263..405811f 100644
> > --- a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt
> > @@ -1,10 +1,10 @@
> > -* Fujitsu SDHCI controller
> > +* Fujitsu/Socionext SDHCI controller
> >
> > This file documents differences between the core properties in mmc.txt
> > -and the properties used by the sdhci_f_sdh30 driver.
> > +and the properties used by the sdhci_f_sdh30.
> >
> > Required properties:
> > -- compatible: "fujitsu,mb86s70-sdhci-3.0"
> > +- compatible: "fujitsu,mb86s70-sdhci-3.0", "socionext,milbeaut-m10v-sdhci-3.0"
>
> One per line please.
I see, I will fix.
>
> > - clocks: Must contain an entry for each entry in clock-names. It is a
> > list of phandles and clock-specifier pairs.
> > See ../clocks/clock-bindings.txt for details.
> > @@ -17,6 +17,8 @@ Optional properties:
> > as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> > - fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> > requires the CMD_DAT_DELAY control to be enabled.
> > +- sni,mmc-power-gpio: set property indicating that power on or off needs
> > + control of gpio. This is for only "socionext,milbeaut-m10v-sdhci-3.0".
>
> s/-gpio/-gpios/
I will fix.
>
> >
> > Example:
> >
> > @@ -30,3 +32,17 @@ Example:
> > clocks = <&clock 2 2 0>, <&clock 2 3 0>;
> > clock-names = "iface", "core";
> > };
> > +
> > +Exsample2:
> > + sdhci3: mmc@1b010000 {
> > + compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> > + reg = <0x1b010000 0x10000>;
> > + interrupts = <0 265 0x4>;
> > + voltage-ranges = <3300 3300>;
> > + bus-width = <4>;
> > + clocks = <&uhs1clk2>, <&ahb_clk>;
> > + clock-names = "core", "iface";
> > + cap-sdio-irq;
> > + sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
> > + fujitsu,cmd-dat-delay-select;
>
> Indentation problem.
Sorry, I will fix.
Thank you
Orito
>
> > + };
> > --
> > 1.9.1
> >
> >
--
Takao Orito <orito.takao@socionext.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-02 2:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-26 5:53 [PATCH v1 1/2] dt-bindings: mmc: sdhci-fujitsu.txt: add miilbeaut driver Takao Orito
2019-03-31 6:42 ` Rob Herring
2019-04-02 2:05 ` orito.takao
2019-04-02 2:05 ` orito.takao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.