* [PATCH 2/4] staging: iio: ad9832: add SPDX identifier
@ 2019-04-01 14:37 Marcelo Schmitt
[not found] ` <ac167cc8-4236-2e15-d5f2-fa222d95da49@codeaurora.org>
0 siblings, 1 reply; 5+ messages in thread
From: Marcelo Schmitt @ 2019-04-01 14:37 UTC (permalink / raw)
To: lars, Michael.Hennerich, stefan.popa, jic23, knaack.h, pmeerw, gregkh
Cc: linux-iio, devel, linux-kernel, kernel-usp
Add SPDX identifier of GPL-2.0 for the ad9832 driver.
Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
---
drivers/staging/iio/frequency/ad9832.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
index 50a583020072..d8d4a7936275 100644
--- a/drivers/staging/iio/frequency/ad9832.c
+++ b/drivers/staging/iio/frequency/ad9832.c
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* AD9832 SPI DDS driver
*
* Copyright 2011 Analog Devices Inc.
- *
- * Licensed under the GPL-2.
*/
#include <asm/div64.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <ac167cc8-4236-2e15-d5f2-fa222d95da49@codeaurora.org>]
* Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier [not found] ` <ac167cc8-4236-2e15-d5f2-fa222d95da49@codeaurora.org> @ 2019-04-01 17:13 ` Greg KH 2019-04-01 19:54 ` Mukesh Ojha 2019-04-02 14:40 ` Marcelo Schmitt 0 siblings, 2 replies; 5+ messages in thread From: Greg KH @ 2019-04-01 17:13 UTC (permalink / raw) To: Mukesh Ojha Cc: Marcelo Schmitt, lars, Michael.Hennerich, stefan.popa, jic23, knaack.h, pmeerw, linux-iio, devel, linux-kernel, kernel-usp On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: > > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: > > Add SPDX identifier of GPL-2.0 for the ad9832 driver. > > > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > > --- > > drivers/staging/iio/frequency/ad9832.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > > index 50a583020072..d8d4a7936275 100644 > > --- a/drivers/staging/iio/frequency/ad9832.c > > +++ b/drivers/staging/iio/frequency/ad9832.c > > @@ -1,9 +1,8 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > FYI > > Use C notations here as per https://lkml.org/lkml/2019/2/13/570. > > <https://lkml.org/lkml/2019/2/13/570> > > Once you fix it then you can take mine > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Did you read the documentation about how to put a proper SPDX line in the kernel documentation? For .c files, you have to use "//", not "/* */" Please read: Documentation/process/license-rules.rst and see the section "Style" for all of the details. thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier 2019-04-01 17:13 ` Greg KH @ 2019-04-01 19:54 ` Mukesh Ojha 2019-04-02 14:40 ` Marcelo Schmitt 1 sibling, 0 replies; 5+ messages in thread From: Mukesh Ojha @ 2019-04-01 19:54 UTC (permalink / raw) To: Greg KH Cc: Marcelo Schmitt, lars, Michael.Hennerich, stefan.popa, jic23, knaack.h, pmeerw, linux-iio, devel, linux-kernel, kernel-usp On 4/1/2019 10:43 PM, Greg KH wrote: > On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: >> On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: >>> Add SPDX identifier of GPL-2.0 for the ad9832 driver. >>> >>> Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> >>> --- >>> drivers/staging/iio/frequency/ad9832.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c >>> index 50a583020072..d8d4a7936275 100644 >>> --- a/drivers/staging/iio/frequency/ad9832.c >>> +++ b/drivers/staging/iio/frequency/ad9832.c >>> @@ -1,9 +1,8 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >> FYI >> >> Use C notations here as per https://lkml.org/lkml/2019/2/13/570. >> >> <https://lkml.org/lkml/2019/2/13/570> >> >> Once you fix it then you can take mine >> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> > Did you read the documentation about how to put a proper SPDX line in > the kernel documentation? For .c files, you have to use "//", not "/* */" > > Please read: > Documentation/process/license-rules.rst > and see the section "Style" for all of the details. Thanks for the detail Greg. Missed the fact. Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier 2019-04-01 17:13 ` Greg KH 2019-04-01 19:54 ` Mukesh Ojha @ 2019-04-02 14:40 ` Marcelo Schmitt 2019-04-07 11:26 ` Jonathan Cameron 1 sibling, 1 reply; 5+ messages in thread From: Marcelo Schmitt @ 2019-04-02 14:40 UTC (permalink / raw) To: Greg KH Cc: Mukesh Ojha, lars, Michael.Hennerich, stefan.popa, jic23, knaack.h, pmeerw, linux-iio, devel, linux-kernel, kernel-usp On 04/01, Greg KH wrote: > On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: > > > > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: > > > Add SPDX identifier of GPL-2.0 for the ad9832 driver. > > > > > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > > > --- > > > drivers/staging/iio/frequency/ad9832.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > > > index 50a583020072..d8d4a7936275 100644 > > > --- a/drivers/staging/iio/frequency/ad9832.c > > > +++ b/drivers/staging/iio/frequency/ad9832.c > > > @@ -1,9 +1,8 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > > FYI > > > > Use C notations here as per https://lkml.org/lkml/2019/2/13/570. > > > > <https://lkml.org/lkml/2019/2/13/570> OK, I'll check it out. > > > > Once you fix it then you can take mine > > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> > > Did you read the documentation about how to put a proper SPDX line in > the kernel documentation? For .c files, you have to use "//", not "/* */" > > Please read: > Documentation/process/license-rules.rst > and see the section "Style" for all of the details. Thanks, I'll read it to understand the details. > > thanks, > > greg k-h Thanks for the advises, Marcelo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier 2019-04-02 14:40 ` Marcelo Schmitt @ 2019-04-07 11:26 ` Jonathan Cameron 0 siblings, 0 replies; 5+ messages in thread From: Jonathan Cameron @ 2019-04-07 11:26 UTC (permalink / raw) To: Marcelo Schmitt Cc: Greg KH, Mukesh Ojha, lars, Michael.Hennerich, stefan.popa, knaack.h, pmeerw, linux-iio, devel, linux-kernel, kernel-usp On Tue, 2 Apr 2019 11:40:00 -0300 Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote: > On 04/01, Greg KH wrote: > > On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: > > > > > > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: > > > > Add SPDX identifier of GPL-2.0 for the ad9832 driver. > > > > > > > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > > > > --- > > > > drivers/staging/iio/frequency/ad9832.c | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > > > > index 50a583020072..d8d4a7936275 100644 > > > > --- a/drivers/staging/iio/frequency/ad9832.c > > > > +++ b/drivers/staging/iio/frequency/ad9832.c > > > > @@ -1,9 +1,8 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > > FYI > > > > > > Use C notations here as per https://lkml.org/lkml/2019/2/13/570. > > > > > > <https://lkml.org/lkml/2019/2/13/570> > > OK, I'll check it out. > > > > > > > Once you fix it then you can take mine > > > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> > > > > Did you read the documentation about how to put a proper SPDX line in > > the kernel documentation? For .c files, you have to use "//", not "/* */" > > > > Please read: > > Documentation/process/license-rules.rst > > and see the section "Style" for all of the details. > > Thanks, I'll read it to understand the details. > > > > > thanks, > > > > greg k-h > > Thanks for the advises, > > Marcelo Greg cleaned up all the remaining IIO staging drivers SPDX entries later in the week, so this one is no longer needed. Thanks, Jonathan ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-07 11:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 14:37 [PATCH 2/4] staging: iio: ad9832: add SPDX identifier Marcelo Schmitt
[not found] ` <ac167cc8-4236-2e15-d5f2-fa222d95da49@codeaurora.org>
2019-04-01 17:13 ` Greg KH
2019-04-01 19:54 ` Mukesh Ojha
2019-04-02 14:40 ` Marcelo Schmitt
2019-04-07 11:26 ` Jonathan Cameron
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.